Skip to content

Change contentType parameter in GetSupportedContentTypes to nullable #63040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2025
Merged

Change contentType parameter in GetSupportedContentTypes to nullable #63040

merged 1 commit into from
Aug 5, 2025

Conversation

bkoelman
Copy link
Contributor

@bkoelman bkoelman commented Aug 1, 2025

Description

Change the contentType parameter in GetSupportedContentTypes to nullable.

Fixes #62405

@github-actions github-actions bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Aug 1, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 1, 2025
@bkoelman bkoelman force-pushed the content-types-nullable branch from 84bbcd2 to d8f1415 Compare August 1, 2025 15:43
@bkoelman bkoelman marked this pull request as ready for review August 1, 2025 18:34
@bkoelman bkoelman requested a review from a team as a code owner August 1, 2025 18:34
@bkoelman
Copy link
Contributor Author

bkoelman commented Aug 1, 2025 •
edited
Loading

@captainsafia How can I fix the build errors? I used the quick-fix from VS, which added the entries to PublicAPI.Unshipped.txt. Am I supposed to hand-edit PublicAPI.Shipped.txt now?

@martincostello
Copy link
Member

#62935 (comment)

@bkoelman bkoelman mentioned this pull request Aug 1, 2025
Closed
@captainsafia
Copy link
Member

@bkoelman This change looks overall good! The test failures in your branch appear related to the fact that new snapshot tests were to main after you forked. A rebase of this branch on your fork should address the issue assuming your hunch is correct.

@bkoelman bkoelman force-pushed the content-types-nullable branch from 098ee94 to 112cd54 Compare August 2, 2025 08:31
@build-analysis build-analysis bot mentioned this pull request Aug 2, 2025
Open
@bkoelman
Copy link
Contributor Author

bkoelman commented Aug 2, 2025

Rebased, but still failing.

@captainsafia
Copy link
Member

It looks like the issue is related to the tests introduced in #63052.

They appear to have triggered some test failures on main as well in commits like 9720579 and 9cdd601. The test failures don't appear persistent so it looks like some sort of aggressive flake :/

@captainsafia captainsafia enabled auto-merge (squash) August 3, 2025 04:45
@captainsafia
Copy link
Member

captainsafia commented Aug 3, 2025 •
edited
Loading

/ba-g Test failures are tests that need to be quarantined per #63073.

1 similar comment
@captainsafia
Copy link
Member

/ba-g Test failures are tests that need to be quarantined per #63073.

auto-merge was automatically disabled August 4, 2025 20:41

Head branch was pushed to by a user without write access

@bkoelman bkoelman force-pushed the content-types-nullable branch from 112cd54 to d975aeb Compare August 4, 2025 20:41
captainsafia
captainsafia approved these changes Aug 5, 2025
View reviewed changes
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR and your patience with the builds ⚒️

@captainsafia captainsafia merged commit fab448a into dotnet:main Aug 5, 2025
30 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-rc1 milestone Aug 5, 2025
@bkoelman bkoelman deleted the content-types-nullable branch August 5, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainsafia captainsafia captainsafia approved these changes

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
10.0-rc1
Development

Successfully merging this pull request may close these issues.

Incorrect nullability on IApiRequestFormatMetadataProvider.GetSupportedContentTypes
3 participants
@bkoelman @martincostello @captainsafia