Skip to content

Update the --info output #8839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KathleenDollard opened this issue Oct 28, 2017 · 7 comments
Closed

Update the --info output #8839

KathleenDollard opened this issue Oct 28, 2017 · 7 comments
Milestone

Comments

@KathleenDollard
Copy link

Update --info to the following scheme:

$ dotnet --info
.NET Core SDK Information:
  SDK Version:  x.y.z
  SDK Build:    e8b8861ac7faf042c87a5c2f9f2d04c98b69f28d

Runtime Environment:
  OS Name:      Mac OS X
  OS Version:   10.12
  OS Platform:  Darwin
  RID:          osx.10.12-x64
  Base Path:    /usr/local/share/dotnet/sdk/2.0.0/

.NET Core Host (dotnet) Information:
  Host Version: x.y.z
  Host Build:   fab8861ac7faf042c87a5c2f9f2d04c98b69f297
@rkeithhill
Copy link

Indeed. The current output makes it hard to determine which "SDK" is being used.

@tmds
Copy link
Member

tmds commented Oct 28, 2017

A system can have multiple sdks installed.
If info only shows one, probably it's the one that is relevant to the current working directory?
It would be good to add this to the output:

when picking up global.json:

.NET Core SDK Information (global.json):

when no global.json:

.NET Core SDK Information (latest):

@rkeithhill
Copy link

A few other points. I don't care too much whether the build info is listed as <mumble> Build: <full sha-1 hash> or Commit SHA-1 hash: <short-hash> as long is you pick one and stick with it for both the SDK and the host.

Also, if we're going to call it .NET Core SDK (instead of just SDK) then shouldn't it be .NET Core Runtime Environment: to be consistent e.g.:

$ dotnet --info
.NET Core SDK Information:
  SDK Version:  x.y.z
  SDK Build:    e8b8861ac7faf042c87a5c2f9f2d04c98b69f28d

.NET Core Runtime Environment:
  OS Name:      Mac OS X
  OS Version:   10.12
  OS Platform:  Darwin
  RID:          osx.10.12-x64
  Base Path:    /usr/local/share/dotnet/sdk/2.0.0/

.NET Core Host (dotnet) Information:
  Host Version: x.y.z
  Host Build:   fab8861ac7faf042c87a5c2f9f2d04c98b69f297

But when you look at all the repeated ".NET Core" text above and observe that using dotnet implies .NET Core, maybe it should just be:

$ dotnet --info
SDK Information:
  SDK Version:  x.y.z
  SDK Build:    e8b8861ac7faf042c87a5c2f9f2d04c98b69f28d

Runtime Environment:
  OS Name:      Mac OS X
  OS Version:   10.12
  OS Platform:  Darwin
  RID:          osx.10.12-x64
  Base Path:    /usr/local/share/dotnet/sdk/2.0.0/

Host (dotnet) Information:
  Host Version: x.y.z
  Host Build:   fab8861ac7faf042c87a5c2f9f2d04c98b69f297

I could go either way on that but more important is to be consistent. Either consistently use .NET Core or consistently not use it. :-)

@KathleenDollard
Copy link
Author

If we can display whether there is a global.json that is a win (like @tmds comment)
If we can display the path to the global.json that is in use, that is a bigger win (like suggested in #8599)

@KathleenDollard
Copy link
Author

This issue is associated with a similar issue in dotnet/cores-setup.

Both will remain as coordinated action is probable in both repos

@KathleenDollard
Copy link
Author

OK, I put on my "don't make me think too much about such trivia" hat and came up with this. It needs polish, but let's start by asking if it seems a good idea to explain clearly to the reader what each value means. I think it will come out casual.

And also: Pick build or hash, don't continue with both. I was told they exist here to help support. I just didn't do that yet as I don't know which is better.

$ dotnet --info
SDK: dotnet version, reflecting any global.json:
  SDK Version:  2.1.300-preview1-002525
  SDK Build:    e8b8861ac7faf042c87a5c2f9f2d04c98b69f28d

Runtime environment:
  OS Name:      Mac OS X
  OS Version:   10.12
  OS Platform:  Darwin
  RID:          osx.10.12-x64
  Base Path:    /usr/local/share/dotnet/sdk/2.0.0/

dotnet host (useful for support):
  Version  : 2.1.0-preview2-26129-0
  Build    : 5c7b2d33e76ee8052a6941a090fcd21252ce2ea8

.NET Core SDKs installed:
  2.0.0 [/usr/local/share/dotnet/sdk]
  2.0.3 [/usr/local/share/dotnet/sdk]
  2.1.3 [/usr/local/share/dotnet/sdk]
  2.1.300-preview1-002525 [/usr/local/share/dotnet/sdk]


.NET Core runtimes installed:
  Microsoft.AspNetCore.All 1.0.1 [C:\Program Files\dotnet\shared]
  Microsoft.NETCore.App 2.0.4 [C:\Program Files\dotnet\shared]
  Microsoft.NETCore.App 2.0.5 [C:\Program Files\dotnet\shared]
  Microsoft.NETCore.App 2.1.0 [C:\Program Files\dotnet\shared]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download

If we are able to include global.json presence, then one of the following (desirable, but may not fit the current timeframe):

SDK: dotnet version (latest):
SDK: dotnet version (global.json):
SDK: dotnet version ([path]/global.json):

Thoughts?

@livarcocc
Copy link
Contributor

Fixed by dotnet/cli#8736.

@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the 2.1.3xx milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants