Skip to content

.NET Core December Update - 2.2.101 and 2.1.502 SDK #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vivmishra opened this issue Dec 11, 2018 · 30 comments
Closed

.NET Core December Update - 2.2.101 and 2.1.502 SDK #2134

vivmishra opened this issue Dec 11, 2018 · 30 comments

Comments

@vivmishra
Copy link
Contributor

Please report any issues you find with 2.1.502/2.2.101, either responding to this issue, creating a new issue or creating a new issue in one of the following repos:

@Nothing-Works
Copy link

Nothing-Works commented Dec 11, 2018

@vivmishra Hi I just updated to Visual Studio 2017 version 15.9.4 and I just got .NET Core SDK 2.1.502 no .NET Core SDK 2.2.101 is this the expected version?

According to this Release Notes I should have .NET Core SDK 2.2.101 as well right?

Or this is a Visual Studio issue?

@vivmishra
Copy link
Contributor Author

@Nothing-Works, thanks for pointing out the mistake -- rel note is updated.
2.2.101 is not yet included in any released VS version.

@mrsquish
Copy link

mrsquish commented Dec 12, 2018

Here I was thinking this was just me!

Mind you, even after installing SDK 2.1.502 I can't seem to workout how to upgrade my projects to use this version.

@UweKeim
Copy link

UweKeim commented Dec 12, 2018

Did IIS in-process hosting make it into 2.2 as stated here?

@Rutix
Copy link
Contributor

Rutix commented Dec 12, 2018

@UweKeim yes it did. See also https://blogs.msdn.microsoft.com/webdev/2018/12/04/asp-net-core-2-2-available-today/

@tristanbarcelon
Copy link

tristanbarcelon commented Dec 12, 2018

Could this 2.1.502 update of the SDK have introduced an inconsistent pattern with the 2.1 releases.json file? I posted the issue here. Having analyzed the releases.json files for prior releases, this 2.1.502 sdk entry would have previously ended up in the sdk field of the 2.1.6 release instead of having its own release entry. Can we get some clarification please?

@tristanbarcelon
Copy link

tristanbarcelon commented Dec 13, 2018

@leecow I looked over the shape of 2.0's releases.json and it's missing latest-runtime and latest-sdk fields. Granted its maintenance status is EOL, would it hurt to show these two fields across all releases so we don't have to code for missing fields/exceptions when parsing the json file?

Thanks for providing the runtime-version field in sdk. That should help sort out the differing "version" fields. If I'm searching for hosting bundles, I typically find it by filtering any release that has the aspnetcore-runtime field and then iterating through the files. That currently only has version and version-display fields but no runtime-version, like the sdk. Can I safely assume that the aspnetcore-runtime version field will always be equal to the runtime version? Edit: I think this is not true especially for the combined hosting bundle for 1.1 and 1.0 runtimes.

My main motivation here in writing the script is to facilitate searches of available/applicable sdk, runtime, hosting bundle assets given a known version of a dotnetcore tfm (netcoreapp20, netcoreapp21, etc) and being able to show the channel's (1.0, 1.1, 2.0, 2.1, 2.2, 3.0, etc) maintenance status. We can typically scan through csproj and vbproj files looking for TargetFramework/TargetFrameworks tags to look for the highest compatible channel which will support all the apps and then finding the associated assets (sdk, runtime, hosting bundle) necessary to support these apps at runtime or development time.

@leecow
Copy link
Member

leecow commented Dec 13, 2018

@tristanbarcelon, I hadn't planned on updated the 2.0 file but, as you say, having it structurally in line with everything else could be helpful. Will add that to the list.

aspnet and net core runtime version version alignment from 2.0 onward will be stable.

@tristanbarcelon
Copy link

Thanks @leecow for your consideration.

@leecow
Copy link
Member

leecow commented Dec 14, 2018

@tristanbarcelon - most of the changes have been implemented and you can see them from https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/releases-index.json. We'll be using this azure storage rather than github to host the 'production' json files. Something will be added to the github files to make it clear they should not be used as the production endpoint for the data.

@tristanbarcelon
Copy link

tristanbarcelon commented Dec 14, 2018

Awesome @leecow! This removes one of the hacks I have in replacing portions of the URL to the rawgithubcontent link to be able to pull the json back properly into a powershell object :) Edit: I switched to the new url and got rid of some of my conditional branches for handling 2.0 releases.json. So far so good. SDK 2.1.100 is missing just the runtime-version and I'm curious about release 2.0.3 being released twice: once on 2017-12-04 and another on 2017-11-14. The hosting bundle link appears to be the same for both. The data I'm able to pull down is a lot more accurate than before. One more thing.. are all these hash values all calculated using sha512 algorithm?

@leecow
Copy link
Member

leecow commented Dec 14, 2018

@tristanbarcelon

  • added runtime-version to 2.1.100 so should be good there now.
  • looks like I switched to sha512 last November.

2.0.3 was released with the 2.0.3 SDK in November then again with the 2.1.2 SDK in December. The minor version bump was lIkely due to updated toolset features for VS but would have to dig a little to know for sure. At any rate, toolset changes would not result in changes to the hosting bundle which is why that's the same as well.

Now that we're tracking runtime and sdk versions in all the right places, the release-version field is really starting to bother me ;-)

@tristanbarcelon
Copy link

tristanbarcelon commented Dec 14, 2018

@leecow did something just change in https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/releases-index.json? The 'releases.json' property for each channel now points back to github instead of the azure blob. Edit: I've temporarily re-added the url substitution logic I had if releases.json contains github url instead of the azure blob.

@leecow
Copy link
Member

leecow commented Dec 14, 2018

@tristanbarcelon ... sorry about that - fixed up.

@CumpsD
Copy link

CumpsD commented Dec 15, 2018

So, what exactly changed between 2.2.100 and 2.2.101? I dont see anything in https://github.com/dotnet/core/blob/master/release-notes/2.2/2.2.101-SDK/2.2.101.md

@karelz karelz changed the title # .NET Core December Update - 2.2.101 and 2.1.502 SDK .NET Core December Update - 2.2.101 and 2.1.502 SDK Dec 18, 2018
@kevindqc
Copy link

The changes are here: https://github.com/dotnet/core/blob/master/release-notes/2.2/2.2.101-SDK/2.2.101-commits.md

@CumpsD
Copy link

CumpsD commented Dec 19, 2018

Thanks!

@TristanApc
Copy link

In 2.2.101 I'm receiving a System.ObjectDisposedException: 'The CancellationTokenSource has been disposed.' exception from System.Private.CoreLib, resulting in a hard crash. The issue is intermittent. Full exception detail below:

System.ObjectDisposedException
  HResult=0x80131622
  Message=The CancellationTokenSource has been disposed.
  Source=System.Private.CoreLib
  StackTrace:
   at System.Threading.CancellationTokenSource.ThrowObjectDisposedException()
   at System.IO.FileStream.FileStreamCompletionSource.CompleteCallback(UInt64 packedResult)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Threading._IOCompletionCallback.PerformIOCompletionCallback(UInt32 errorCode, UInt32 numBytes, NativeOverlapped* pOVERLAP)

@karelz
Copy link
Member

karelz commented Dec 20, 2018

@TristanApc it is not clear from the callstack if it is a bug in your code, some 3rd party library or in .NET Core itself. You will likely need to root-cause it first or at least do deeper investigation, then file a bug.

@sepehr1014
Copy link

@TristanApc @karelz It might be related to dotnet/aspnetcore#4422 which should be fixed in the next minor release dotnet/coreclr#21417

@TristanApc
Copy link

@sepehr1014 thanks! That definitively seems related since CoreLib directly throws the exception that I'm getting. The application is indeed ASP MVC using kestrel.

@johnkwaters
Copy link

Still no ANCM for Azure App Services?

@karelz
Copy link
Member

karelz commented Jan 8, 2019

@johnkwaters what is ANCM? In general, we recommend to watch Azure App Services announcement repo: https://github.com/Azure/app-service-announcements

@johnkwaters
Copy link

johnkwaters commented Jan 8, 2019

Thanks @karelz - it is the new AspNetCoreModule. I had asked previously, and was also told to monitor for announcements,. but there have been none, and it was supposed to roll out in December. However I was told in another thread that it is out there now, and sure enough, it is - so maybe someone should announce it?

@karelz
Copy link
Member

karelz commented Jan 8, 2019

@johnkwaters good idea to raise it to App Service team ...

@leecow
Copy link
Member

leecow commented Jan 10, 2019

@shirhatti for ideas on ANCM announcement channels.

@tristanbarcelon
Copy link

tristanbarcelon commented Jan 19, 2019

Hi @vivmishra @leecow, did anything change in the dotnetcore release index yesterday or today? My script which was working just fine yesterday now gets an error when used today. After a little bit more debug, it appears that the channel-specific releases.json file is an invalid JSON file. Here's how 2.2 looks like.

image

@leecow
Copy link
Member

leecow commented Jan 19, 2019

@tristanbarcelon - there was a refresh of the sdk yesterday. Looks like an errant comma slipped into the file. Fixed.

@tristanbarcelon
Copy link

Thank you @leecow

@leecow
Copy link
Member

leecow commented Feb 12, 2019

Closing this release discussion issue in favor of #2304.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests