Fix watson bucketing/broken triage dumps (#26714)

Mike McLaughlin · jkotas · commit c7071577a4d9 · 2019-09-14T07:00:00.000-07:00
The DAC EnumMemoryRegions needs to include some missing code version
manager memory.
diff --git a/src/vm/method.cpp b/src/vm/method.cpp
@@ -5494,6 +5494,11 @@ MethodDesc::EnumMemoryRegions(CLRDataEnumMemoryFlags flags)
         }
     }
 
+#ifdef FEATURE_CODE_VERSIONING
+    // Make sure the active IL and native code version are in triage dumps.
+    GetCodeVersionManager()->GetActiveILCodeVersion(dac_cast<PTR_MethodDesc>(this)).GetActiveNativeCodeVersion(dac_cast<PTR_MethodDesc>(this));
+#endif
+
     // Also, call DacValidateMD to dump the memory it needs. !clrstack calls 
     // DacValidateMD before it retrieves the method name. We don't expect 
     // DacValidateMD to fail, but if it does, ignore the failure and try to assemble the 

Original file line number	Diff line number	Diff line change
`@@ -5494,6 +5494,11 @@ MethodDesc::EnumMemoryRegions(CLRDataEnumMemoryFlags flags)`
`5494`	`5494`	`}`
`5495`	`5495`	`}`
`5496`	`5496`
	`5497`	`+#ifdef FEATURE_CODE_VERSIONING`
	`5498`	`+ // Make sure the active IL and native code version are in triage dumps.`
	`5499`	`+ GetCodeVersionManager()->GetActiveILCodeVersion(dac_cast<PTR_MethodDesc>(this)).GetActiveNativeCodeVersion(dac_cast<PTR_MethodDesc>(this));`
	`5500`	`+#endif`
	`5501`	`+`
`5497`	`5502`	`// Also, call DacValidateMD to dump the memory it needs. !clrstack calls`
`5498`	`5503`	`// DacValidateMD before it retrieves the method name. We don't expect`
`5499`	`5504`	`// DacValidateMD to fail, but if it does, ignore the failure and try to assemble the`