test for GITHUB_OUTPUT (#973)

* test for GITHUB_OUTPUT

When running locally, the environment variables set by GH actions aren't set. Check for their existence before writing to them.

* Add checks around all GITUB_OUTPUT

Check for the existence of the environment so our scripts don't fail when run locally.

* remove testing code.

* simplify

* fix syntax error

* respond to feedback

Because we're using `set -e`, we don't need to check the most recent error code before determining that it completed successfully.

* remove duplicate line

Author: BillWagner

tools/run-converter.sh

@@ -21,11 +21,7 @@ dotnet run --project $CONVERTER_PROJECT -- \
   $SPEC_DIRECTORY/*.md $TEMPLATE \
   -o $OUTPUT_DIRECTORY/standard.docx
 
-if [ "$?" -eq "0" ]
+if [ -n "$GITHUB_OUTPUT" ]
 then
-    # Success: Write key/value for GitHub action to read:
     echo "status=success" >> $GITHUB_OUTPUT 
-else
-    # Failed: report the error to the GitHub action:
-    echo "status=failed" >> $GITHUB_OUTPUT 
 fi

tools/run-section-renumber.sh

@@ -11,11 +11,7 @@ fi
 
 dotnet run --project $PROJECT -- $1
 
-if [ "$?" -eq "0" ]
+if [ -n "$GITHUB_OUTPUT" ]
 then
-    # Success: Write key/value for GitHub action to read:
     echo "status=success" >> $GITHUB_OUTPUT 
-else
-    # Failed: report the error to the GitHub action:
-    echo "status=failed" >> $GITHUB_OUTPUT 
 fi

tools/run-smarten.sh

@@ -17,4 +17,7 @@ done
 rm -rf smarten
 
 # I think always success, but echo the success output anyway:
-echo "status=success" >> $GITHUB_OUTPUT
+if [ -n "$GITHUB_OUTPUT" ]
+then
+    echo "status=success" >> $GITHUB_OUTPUT
+fi

tools/update-grammar-annex.sh

@@ -49,4 +49,7 @@ echo Insert EOF Stuff
 cat $GRAMMAR_PROJECT/grammar-eof-insert.md >>$OUTPUT_FILE
 
 # I think always success, but echo the success output anyway:
-echo "status=success" >> $GITHUB_OUTPUT 
+if [ -n "$GITHUB_OUTPUT" ]
+then
+    echo "status=success" >> $GITHUB_OUTPUT
+fi