Skip to content

Address outstanding comments on patterns #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jskeet opened this issue Apr 13, 2023 · 2 comments · Fixed by #934
Closed

Address outstanding comments on patterns #774

jskeet opened this issue Apr 13, 2023 · 2 comments · Fixed by #934
Assignees
@gafter
Labels
type: process This issue relates to processes
Milestone
C# 7.x

Comments

@jskeet
Copy link
Contributor

jskeet commented Apr 13, 2023

We merged #757 with several comments still open, in order to get the first draft to ECMA members.

This issue is basically a reminder that we should still go through them. Neal, feel free to just resolve any that have been addressed, or @ people for more details if they're insufficient. I'd expect that a single PR could address a bunch of the niggles that were left as comments.
@jskeet jskeet added this to the C# 7.x milestone Apr 13, 2023
@jskeet jskeet added the type: process This issue relates to processes label Apr 13, 2023
@jskeet
Copy link
Contributor Author

jskeet commented Aug 7, 2023

@gafter: Are you able to look at these during August at all?

@gafter
Copy link
Member

gafter commented Sep 14, 2023 •
edited
Loading

Adressing this now. I will resolve or comment on each open comment on that PR.

@BillWagner BillWagner mentioned this issue Sep 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gafter gafter

Labels
type: process This issue relates to processes
Projects
None yet
Milestone
C# 7.x
Development

Successfully merging a pull request may close this issue.

Edits suggested for patterns dotnet/csharpstandard
2 participants
@jskeet @gafter