From 0635e879acd48a68cd78d4ce8ddd2e1bcd313ab8 Mon Sep 17 00:00:00 2001 From: Noah Falk Date: Thu, 31 Oct 2024 13:35:43 -0700 Subject: [PATCH 1/4] Add System.Diagnostics.DiagnosticSource netstandard guidance --- .../distributed-tracing-instrumentation-walkthroughs.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/core/diagnostics/distributed-tracing-instrumentation-walkthroughs.md b/docs/core/diagnostics/distributed-tracing-instrumentation-walkthroughs.md index 6351d5e1b3f3d..0895a4951313e 100644 --- a/docs/core/diagnostics/distributed-tracing-instrumentation-walkthroughs.md +++ b/docs/core/diagnostics/distributed-tracing-instrumentation-walkthroughs.md @@ -29,7 +29,7 @@ dotnet new console Applications that target .NET 5 and later already have the necessary distributed tracing APIs included. For apps targeting older .NET versions, add the [System.Diagnostics.DiagnosticSource NuGet package](https://www.nuget.org/packages/System.Diagnostics.DiagnosticSource/) -version 5 or greater. +version 5 or greater. For libraries targetting netstandard, we recommend referencing the latest version of NuGet package. ```dotnetcli dotnet add package System.Diagnostics.DiagnosticSource From 2338a1d3b2373e9837c938399d56c9d3870fc0e3 Mon Sep 17 00:00:00 2001 From: Noah Falk Date: Thu, 31 Oct 2024 13:37:33 -0700 Subject: [PATCH 2/4] Update docs/core/diagnostics/distributed-tracing-instrumentation-walkthroughs.md --- .../distributed-tracing-instrumentation-walkthroughs.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/core/diagnostics/distributed-tracing-instrumentation-walkthroughs.md b/docs/core/diagnostics/distributed-tracing-instrumentation-walkthroughs.md index 0895a4951313e..f026e49d4aa48 100644 --- a/docs/core/diagnostics/distributed-tracing-instrumentation-walkthroughs.md +++ b/docs/core/diagnostics/distributed-tracing-instrumentation-walkthroughs.md @@ -29,7 +29,7 @@ dotnet new console Applications that target .NET 5 and later already have the necessary distributed tracing APIs included. For apps targeting older .NET versions, add the [System.Diagnostics.DiagnosticSource NuGet package](https://www.nuget.org/packages/System.Diagnostics.DiagnosticSource/) -version 5 or greater. For libraries targetting netstandard, we recommend referencing the latest version of NuGet package. +version 5 or greater. For libraries targetting netstandard, we recommend referencing the latest version of the NuGet package. ```dotnetcli dotnet add package System.Diagnostics.DiagnosticSource From 591c1eca3e5beb0ad1edfb99fdd712176533fb63 Mon Sep 17 00:00:00 2001 From: Noah Falk Date: Fri, 1 Nov 2024 14:58:35 -0700 Subject: [PATCH 3/4] Update docs/core/diagnostics/distributed-tracing-instrumentation-walkthroughs.md --- .../distributed-tracing-instrumentation-walkthroughs.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/core/diagnostics/distributed-tracing-instrumentation-walkthroughs.md b/docs/core/diagnostics/distributed-tracing-instrumentation-walkthroughs.md index f026e49d4aa48..b362711a036d9 100644 --- a/docs/core/diagnostics/distributed-tracing-instrumentation-walkthroughs.md +++ b/docs/core/diagnostics/distributed-tracing-instrumentation-walkthroughs.md @@ -29,7 +29,7 @@ dotnet new console Applications that target .NET 5 and later already have the necessary distributed tracing APIs included. For apps targeting older .NET versions, add the [System.Diagnostics.DiagnosticSource NuGet package](https://www.nuget.org/packages/System.Diagnostics.DiagnosticSource/) -version 5 or greater. For libraries targetting netstandard, we recommend referencing the latest version of the NuGet package. +version 5 or greater. For libraries targetting netstandard, we recommend referencing the oldest version of the package which is still supported and contains the APIs your library needs. ```dotnetcli dotnet add package System.Diagnostics.DiagnosticSource From a4bca80431d1dc21dff0c0d6e086982565c299d6 Mon Sep 17 00:00:00 2001 From: Noah Falk Date: Fri, 1 Nov 2024 15:03:53 -0700 Subject: [PATCH 4/4] Update docs/core/diagnostics/distributed-tracing-instrumentation-walkthroughs.md --- .../distributed-tracing-instrumentation-walkthroughs.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/core/diagnostics/distributed-tracing-instrumentation-walkthroughs.md b/docs/core/diagnostics/distributed-tracing-instrumentation-walkthroughs.md index b362711a036d9..6a0f350db2407 100644 --- a/docs/core/diagnostics/distributed-tracing-instrumentation-walkthroughs.md +++ b/docs/core/diagnostics/distributed-tracing-instrumentation-walkthroughs.md @@ -29,7 +29,7 @@ dotnet new console Applications that target .NET 5 and later already have the necessary distributed tracing APIs included. For apps targeting older .NET versions, add the [System.Diagnostics.DiagnosticSource NuGet package](https://www.nuget.org/packages/System.Diagnostics.DiagnosticSource/) -version 5 or greater. For libraries targetting netstandard, we recommend referencing the oldest version of the package which is still supported and contains the APIs your library needs. +version 5 or greater. For libraries targeting netstandard, we recommend referencing the oldest version of the package which is still supported and contains the APIs your library needs. ```dotnetcli dotnet add package System.Diagnostics.DiagnosticSource