Skip to content

Commit af2ebfa

Browse files
T-GroT-Gro
authored
Re-enable unused bindings detection (#18420)
* reenable unused binding detection * fantomas * vsintegration/tests - ignored unused bindings in selected test projects
1 parent a3181c4 commit af2ebfa

39 files changed

+83
-116
lines changed

‎Directory.Build.props

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,6 @@
1010
<IgnoreMibc Condition="'$(IgnoreMibc)' == ''">$(DotNetBuildSourceOnly)</IgnoreMibc>
1111
</PropertyGroup>
1212

13-
<PropertyGroup>
14-
<!-- TODO: These need to be removed once we merge/release the new SDK with noward and line fixes. -->
15-
<NoWarn>$(NoWarn);FS0064;FS1182</NoWarn>
16-
</PropertyGroup>
17-
1813
<!--
1914
When developers load the FSharp.Compiler.Service solution we set FSHARPCORE_USE_PACKAGE to true if it hasn't already been set to a value.
2015
This option ensures that building and testing uses the specified FSharp.Core nuget package instead of the local FSharp.Core project.

‎FSharp.sln

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ Project("{6EC3EE1D-3C4E-46DD-8F32-0CC8E7565705}") = "FSharp.Compiler.Benchmarks"
106106
EndProject
107107
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{D58BFE8B-7C85-4D3B-B5F3-9A7BB90FF1EE}"
108108
ProjectSection(SolutionItems) = preProject
109+
src\Compiler\default.win32manifest = src\Compiler\default.win32manifest
109110
src\Compiler\FSComp.txt = src\Compiler\FSComp.txt
110111
src\Compiler\FSCompCheck.fsx = src\Compiler\FSCompCheck.fsx
111112
EndProjectSection

‎FSharpBuild.Directory.Build.props

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@
2727
<SymStoreDirectory>$(ArtifactsDir)\SymStore</SymStoreDirectory>
2828
<ProtoOutputPath>$(ArtifactsDir)\Bootstrap</ProtoOutputPath>
2929
<ValueTupleImplicitPackageVersion>4.4.0</ValueTupleImplicitPackageVersion>
30-
<WarningsAsErrors>1182;0025;$(WarningsAsErrors)</WarningsAsErrors>
30+
<WarnOn>$(WarnOn);1182</WarnOn>
31+
<WarningsAsErrors>0025;$(WarningsAsErrors)</WarningsAsErrors>
3132
<OtherFlags>$(OtherFlags) --nowarn:3384</OtherFlags>
3233
<OtherFlags>$(OtherFlags) --times --nowarn:75</OtherFlags>
3334
<OtherFlags Condition="$(AdditionalFscCmdFlags) != ''">$(OtherFlags) $(AdditionalFscCmdFlags)</OtherFlags>

‎src/Compiler/Checking/Expressions/CheckExpressions.fs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -813,7 +813,7 @@ let TcConst (cenv: cenv) (overallTy: TType) m env synConst =
813813
warning(Error(FSComp.SR.tcImplicitMeasureFollowingSlash(), m))
814814
let factor1 = ms1 |> Option.defaultValue (SynMeasure.One Range.Zero)
815815
Measure.Prod(tcMeasure factor1, Measure.Inv (tcMeasure ms2), ms.Range)
816-
| SynMeasure.Divide(measure1 = ms1; measure2 = ms2; range= m) ->
816+
| SynMeasure.Divide(measure1 = ms1; measure2 = ms2) ->
817817
let factor1 = ms1 |> Option.defaultValue (SynMeasure.One Range.Zero)
818818
Measure.Prod(tcMeasure factor1, Measure.Inv (tcMeasure ms2), ms.Range)
819819
| SynMeasure.Seq(mss, _) -> ProdMeasures (List.map tcMeasure mss)
@@ -10686,7 +10686,7 @@ and TcMatchClauses cenv inputTy (resultTy: OverallTy) env tpenv clauses =
1068610686
resultList,tpEnv
1068710687

1068810688
and TcMatchClause cenv inputTy (resultTy: OverallTy) env isFirst tpenv synMatchClause =
10689-
let (SynMatchClause(synPat, synWhenExprOpt, synResultExpr, patm, spTgt, trivia)) = synMatchClause
10689+
let (SynMatchClause(synPat, synWhenExprOpt, synResultExpr, patm, spTgt, _trivia)) = synMatchClause
1069010690

1069110691
let isTrueMatchClause =
1069210692
if synMatchClause.IsTrueMatchClause then

‎src/Compiler/Checking/Expressions/CheckSequenceExpressions.fs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ let TcSequenceExpression (cenv: TcFileState) env tpenv comp (overallTy: OverallT
270270

271271
let tclauses, tpenv =
272272
(tpenv, clauses)
273-
||> List.mapFold (fun tpenv (SynMatchClause(pat, cond, innerComp, _, sp, trivia) as clause) ->
273+
||> List.mapFold (fun tpenv (SynMatchClause(pat, cond, innerComp, _, sp, _trivia) as clause) ->
274274
let isTrueMatchClause =
275275
if clause.IsTrueMatchClause then
276276
TcTrueMatchClause.Yes
@@ -319,7 +319,7 @@ let TcSequenceExpression (cenv: TcFileState) env tpenv comp (overallTy: OverallT
319319
// Compile the pattern twice, once as a filter with all succeeding targets returning "1", and once as a proper catch block.
320320
let clauses, tpenv =
321321
(tpenv, withList)
322-
||> List.mapFold (fun tpenv (SynMatchClause(pat, cond, innerComp, m, sp, trivia) as clause) ->
322+
||> List.mapFold (fun tpenv (SynMatchClause(pat, cond, innerComp, m, sp, _trivia) as clause) ->
323323
let isTrueMatchClause =
324324
if clause.IsTrueMatchClause then
325325
TcTrueMatchClause.Yes

‎src/Compiler/Checking/TailCallChecks.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -794,7 +794,7 @@ let CheckModuleBinding cenv (isRec: bool) (TBind _ as bind) =
794794
| Expr.Op(args = exprs) -> exprs |> Seq.iter (checkTailCall insideSubBindingOrTry)
795795
| Expr.Sequential(expr1 = expr1; expr2 = expr2) ->
796796
match expr1 with
797-
| Expr.Op(args = exprs; op = TOp.IntegerForLoop _) -> checkTailCall insideSubBindingOrTry expr1
797+
| Expr.Op(op = TOp.IntegerForLoop _) -> checkTailCall insideSubBindingOrTry expr1
798798
| _ -> ()
799799

800800
checkTailCall insideSubBindingOrTry expr2

‎src/Compiler/Checking/infos.fs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1438,10 +1438,10 @@ type MethInfo =
14381438
match retTy with
14391439
| Some retTy -> isTyparTy g retTy
14401440
| None -> false
1441-
| MethInfoWithModifiedReturnType(_,retTy) -> false
1441+
| MethInfoWithModifiedReturnType _ -> false
14421442
| DefaultStructCtor _ -> false
14431443
#if !NO_TYPEPROVIDERS
1444-
| ProvidedMeth(amap, mi, _, m) -> false
1444+
| ProvidedMeth _ -> false
14451445
#endif
14461446

14471447
/// Get the ParamData objects for the parameters of a MethInfo

‎src/Compiler/CodeGen/EraseUnions.fs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1211,7 +1211,6 @@ let convAlternativeDef
12111211
let basicCtorFields =
12121212
basicFields
12131213
|> List.map (fun fdef ->
1214-
let existingAttrs = fdef.CustomAttrs.AsArray()
12151214
let nullableAttr = getFieldsNullability g fdef |> Option.toList
12161215
fdef.Name, fdef.FieldType, nullableAttr)
12171216

‎src/Compiler/Driver/CompilerDiagnostics.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -678,7 +678,7 @@ type Exception with
678678
showNullnessAnnotations = Some true
679679
}
680680

681-
let t1, t2, _cxs = NicePrint.minimalStringsOfTwoTypes denv ty1 ty2
681+
let t1, _t2, _cxs = NicePrint.minimalStringsOfTwoTypes denv ty1 ty2
682682

683683
os.Append(ConstraintSolverNullnessWarningEquivWithTypesE().Format t1) |> ignore
684684

‎src/Compiler/FSharp.Compiler.Service.fsproj

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@
1010
<NoWarn>$(NoWarn);75</NoWarn> <!-- InternalCommandLineOption -->
1111
<NoWarn>$(NoWarn);1204</NoWarn> <!-- This construct is for use in the FSharp.Core library and should not be used directly -->
1212
<NoWarn>$(NoWarn);NU5125</NoWarn>
13-
<NoWarn>$(NoWarn);64;1182;1204</NoWarn> <!--Temporary fix for sourcebuild -->
14-
<OtherFlags>$(OtherFlags) --warnaserror-:1182</OtherFlags> <!--Temporary fix for sourcebuild -->
13+
<NoWarn>$(NoWarn);64;1204</NoWarn> <!--Temporary fix for sourcebuild -->
1514
<AssemblyName>FSharp.Compiler.Service</AssemblyName>
1615
<AllowCrossTargeting>true</AllowCrossTargeting>
1716
<DefineConstants>$(DefineConstants);COMPILER</DefineConstants>
@@ -26,11 +25,6 @@
2625
<TargetFrameworks Condition=" '$(OfficialBuildId)' == '' AND '$(FSharpNetCoreProductTargetFramework)' != '' AND '$(Configuration)' != 'Proto' AND '$(SKIP_NETCURRENT_FSC_BUILD)' != 'true' ">$(FSharpNetCoreProductTargetFramework);$(TargetFrameworks)</TargetFrameworks>
2726
<DefineConstants Condition="'$(FSHARPCORE_USE_PACKAGE)' == 'true'">$(DefineConstants);FSHARPCORE_USE_PACKAGE</DefineConstants>
2827
<OtherFlags>$(OtherFlags) --extraoptimizationloops:1</OtherFlags>
29-
30-
<!-- TODO: This needs to be re-enabled once we merge/release the new SDK with noward and line fixes. -->
31-
<!-- 1182: Unused variables -->
32-
<OtherFlags>$(OtherFlags) --nowarn:1182</OtherFlags>
33-
3428
<!-- 3218: ArgumentsInSigAndImplMismatch -->
3529
<OtherFlags>$(OtherFlags) --warnon:3218</OtherFlags>
3630
<!-- 3390: xmlDocBadlyFormed -->

‎src/Compiler/Facilities/AsyncMemoize.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ type internal AsyncMemoize<'TKey, 'TVersion, 'TValue
183183
when 'TKey: equality and 'TVersion: equality and 'TKey: not null and 'TVersion: not null>
184184
(?keepStrongly, ?keepWeakly, ?name: string, ?cancelUnawaitedJobs: bool, ?cancelDuplicateRunningJobs: bool) =
185185

186-
let name = defaultArg name "N/A"
186+
let _name = defaultArg name "N/A"
187187
let cancelUnawaitedJobs = defaultArg cancelUnawaitedJobs true
188188
let cancelDuplicateRunningJobs = defaultArg cancelDuplicateRunningJobs false
189189

‎src/Compiler/Service/TransparentCompiler.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2355,7 +2355,7 @@ type internal TransparentCompiler
23552355
(
23562356
fileName: string,
23572357
sourceText: ISourceTextNew,
2358-
caret: Position option,
2358+
_caret: Position option,
23592359
documentSource: DocumentSource,
23602360
previewEnabled: bool option,
23612361
loadedTimeStamp: DateTime option,

‎src/Compiler/SyntaxTree/LexerStore.fs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@ let private tryGetStoreData<'T when 'T: not null> (lexbuf: Lexbuf) key =
3232
| true, data -> Some(data :?> 'T)
3333
| _ -> None
3434

35-
let private setStoreData (lexbuf: Lexbuf) key data = lexbuf.BufferLocalStore[key] <- data
36-
3735
//------------------------------------------------------------------------
3836
// A SynArgNameGenerator for the current file, used by the parser
3937
//------------------------------------------------------------------------

‎src/Compiler/SyntaxTree/SyntaxTreeOps.fs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1024,9 +1024,9 @@ let parsedHashDirectiveArgumentsNoCheck (input: ParsedHashDirectiveArgument list
10241024
(function
10251025
| ParsedHashDirectiveArgument.String(s, _, _) -> s
10261026
| ParsedHashDirectiveArgument.SourceIdentifier(_, v, _) -> v
1027-
| ParsedHashDirectiveArgument.Int32(n, m) -> string n
1028-
| ParsedHashDirectiveArgument.Ident(ident, m) -> ident.idText
1029-
| ParsedHashDirectiveArgument.LongIdent(ident, m) -> longIdentToString ident)
1027+
| ParsedHashDirectiveArgument.Int32(n, _) -> string n
1028+
| ParsedHashDirectiveArgument.Ident(ident, _) -> ident.idText
1029+
| ParsedHashDirectiveArgument.LongIdent(ident, _) -> longIdentToString ident)
10301030
input
10311031

10321032
let parsedHashDirectiveStringArguments (input: ParsedHashDirectiveArgument list) (_langVersion: LanguageVersion) =

‎src/Compiler/TypedTree/TypedTreeOps.fs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9241,7 +9241,7 @@ let GetDisallowedNullness (g:TcGlobals) (ty:TType) =
92419241
| None -> []
92429242
| Some t -> hasWithNullAnyWhere t withNull
92439243

9244-
| TType_app (tcr, tinst, nullnessOrig) ->
9244+
| TType_app (tcr, tinst, _) ->
92459245
let tyArgs = tinst |> List.collect (fun t -> hasWithNullAnyWhere t false)
92469246

92479247
match alreadyWrappedInOuterWithNull, tcr.TypeAbbrev with
@@ -9260,7 +9260,7 @@ let GetDisallowedNullness (g:TcGlobals) (ty:TType) =
92609260
let inner = tupTypes |> List.collect (fun t -> hasWithNullAnyWhere t false)
92619261
if alreadyWrappedInOuterWithNull then ty :: inner else inner
92629262

9263-
| TType_anon (anon,tys) ->
9263+
| TType_anon (tys=tys) ->
92649264
let inner = tys |> List.collect (fun t -> hasWithNullAnyWhere t false)
92659265
if alreadyWrappedInOuterWithNull then ty :: inner else inner
92669266
| TType_fun (d, r, _) ->

‎src/FSharp.Build/CreateFSharpManifestResourceName.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ type CreateFSharpManifestResourceName public () =
1818
linkFileName: string,
1919
rootNamespace: string, // may be null
2020
dependentUponFileName: string, // may be null
21-
binaryStream: Stream // may be null
21+
_binaryStream: Stream // may be null
2222
) : string =
2323

2424
// The Visual CSharp and XBuild CSharp toolchains transform resource names like this:

‎src/FSharp.Build/FSharpEmbedResourceText.fs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -447,7 +447,7 @@ open Printf
447447
let lines =
448448
File.ReadAllLines(fileName)
449449
|> Array.mapi (fun i s -> i, s) // keep line numbers
450-
|> Array.filter (fun (i, s) -> not (s.StartsWith "#")) // filter out comments
450+
|> Array.filter (fun (_i, s) -> not (s.StartsWith "#")) // filter out comments
451451

452452
printMessage "Parsing %s" fileName
453453
let stringInfos = lines |> Array.map (fun (i, s) -> ParseLine fileName i s)
@@ -511,7 +511,7 @@ open Printf
511511
printMessage "Generating resource methods for %s" outFileName
512512
// gen each resource method
513513
stringInfos
514-
|> Seq.iter (fun (lineNum, (optErrNum, ident), str, holes, netFormatString) ->
514+
|> Seq.iter (fun (lineNum, (optErrNum, ident), str, holes, _netFormatString) ->
515515
let formalArgs = new System.Text.StringBuilder()
516516
let actualArgs = new System.Text.StringBuilder()
517517
let mutable firstTime = true
@@ -589,7 +589,7 @@ open Printf
589589
fprintfn outSignature " static member RunStartupValidation: unit -> unit"
590590

591591
stringInfos
592-
|> Seq.iter (fun (lineNum, (optErrNum, ident), str, holes, netFormatString) ->
592+
|> Seq.iter (fun (_lineNum, (_optErrNum, ident), _str, _holes, _netFormatString) ->
593593
fprintfn out " ignore(GetString(\"%s\"))" ident)
594594

595595
fprintfn out " ()" // in case there are 0 strings, we need the generated code to parse
@@ -598,7 +598,7 @@ open Printf
598598
xd.LoadXml(xmlBoilerPlateString)
599599

600600
stringInfos
601-
|> Seq.iter (fun (lineNum, (optErrNum, ident), str, holes, netFormatString) ->
601+
|> Seq.iter (fun (_lineNum, (_optErrNum, ident), _str, _holes, netFormatString) ->
602602
let xn = xd.CreateElement("data")
603603
xn.SetAttribute("name", ident) |> ignore
604604
xn.SetAttribute("xml:space", "preserve") |> ignore

‎src/FSharp.Build/Fsc.fs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ type public Fsc() as this =
6969
let mutable tailcalls: bool = true
7070
let mutable targetProfile: string MaybeNull = null
7171
let mutable targetType: string MaybeNull = null
72-
let mutable toolExe: string = "fsc.exe"
7372

7473
let defaultToolPath =
7574
let locationOfThisDll =
@@ -733,8 +732,6 @@ type public Fsc() as this =
733732
match host with
734733
| null -> base.ExecuteTool(pathToTool, responseFileCommands, commandLineCommands)
735734
| _ ->
736-
let sources = sources |> Array.map (fun i -> i.ItemSpec)
737-
738735
let invokeCompiler baseCallDelegate =
739736
try
740737
let ret =
@@ -765,7 +762,7 @@ type public Fsc() as this =
765762
->
766763
fsc.Log.LogError(tie.InnerException.Message, [||])
767764
-1
768-
| e -> reraise ()
765+
| _ -> reraise ()
769766

770767
let baseCallDelegate =
771768
Func<int>(fun () -> fsc.BaseExecuteTool(pathToTool, responseFileCommands, commandLineCommands))

‎src/FSharp.Build/Fsi.fs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,15 +37,12 @@ type public Fsi() as this =
3737
let mutable provideCommandLineArgs = false
3838
let mutable references: ITaskItem[] = [||]
3939
let mutable referencePath: string MaybeNull = null
40-
let mutable resources: ITaskItem[] = [||]
4140
let mutable skipCompilerExecution = false
4241
let mutable sources: ITaskItem[] = [||]
4342
let mutable loadSources: ITaskItem[] = [||]
4443
let mutable useSources: ITaskItem[] = [||]
4544
let mutable tailcalls: bool = true
4645
let mutable targetProfile: string MaybeNull = null
47-
let mutable targetType: string MaybeNull = null
48-
let mutable toolExe: string = "fsi.exe"
4946

5047
let mutable toolPath: string =
5148
let locationOfThisDll =

‎src/FSharp.Build/MapSourceRoots.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ type MapSourceRoots() =
130130

131131
for root in mappedSourceRoots do
132132
match root.GetMetadata SourceControl with
133-
| HasValue v when isSourceControlled -> mapNestedRootIfEmpty root
133+
| HasValue _ when isSourceControlled -> mapNestedRootIfEmpty root
134134
| NullOrEmpty when not isSourceControlled -> mapNestedRootIfEmpty root
135135
| _ -> ()
136136

‎src/FSharp.DependencyManager.Nuget/FSharp.DependencyManager.Nuget.fsproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
<AssemblyName>FSharp.DependencyManager.Nuget</AssemblyName>
99
<AllowCrossTargeting>true</AllowCrossTargeting>
1010
<DefineConstants>$(DefineConstants);COMPILER</DefineConstants>
11-
<OtherFlags>$(OtherFlags) --warnon:1182</OtherFlags>
1211
<Tailcalls>true</Tailcalls> <!-- .tail annotations always emitted for this binary, even in debug mode -->
1312
<Configurations>Debug;Release</Configurations>
1413
</PropertyGroup>

‎tests/FSharp.Build.UnitTests/MapSourceRootsTests.fs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ open Xunit
99
open System.Collections.Generic
1010
open FSharp.Test
1111

12+
#nowarn "1182" //Unused arguments
13+
1214
type MockEngine() =
1315
member val Errors = ResizeArray() with get
1416
member val Warnings = ResizeArray() with get

‎tests/FSharp.Compiler.Private.Scripting.UnitTests/DependencyManagerInteractiveTests.fs

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,6 @@ type DependencyManagerInteractiveTests() =
3939
let getErrors ((_value: Result<FsiValue option, exn>), (errors: FSharpDiagnostic[])) =
4040
errors
4141

42-
let ignoreValue = getValue >> ignore
43-
4442
[<Fact>]
4543
member _.``SmokeTest - #r nuget``() =
4644
let text = """
@@ -58,7 +56,7 @@ type DependencyManagerInteractiveTests() =
5856
#r @"nuget:System.Collections.Immutable.DoesNotExist, version=1.5.0"
5957
0"""
6058
use script = new scriptHost()
61-
let opt, errors = script.Eval(text)
59+
let _opt, errors = script.Eval(text)
6260
Assert.Equal(errors.Length, 1)
6361

6462
(*
@@ -152,8 +150,6 @@ type DependencyManagerInteractiveTests() =
152150

153151
[<Fact>]
154152
member _.``Multiple Instances of DependencyProvider should be isolated``() =
155-
156-
let assemblyProbingPaths () = Seq.empty<string>
157153
let nativeProbingRoots () = Seq.empty<string>
158154

159155
use dp1 = new DependencyProvider(NativeResolutionProbe(nativeProbingRoots), false)
@@ -282,7 +278,6 @@ TorchSharp.Tensor.LongTensor.From([| 0L .. 100L |]).Device
282278
| ErrorReportType.Warning -> printfn "PackageManagementWarning %d : %s" code message
283279
ResolvingErrorReport (report)
284280

285-
let mutable resolverPackageRoots = Seq.empty<string>
286281
let mutable resolverPackageRoots = Seq.empty<string>
287282
let mutable resolverReferences = Seq.empty<string>
288283

@@ -383,11 +378,9 @@ printfn ""%A"" result
383378
ResolvingErrorReport (report)
384379

385380
let mutable resolverPackageRoots = Seq.empty<string>
386-
let mutable resolverPackageRoots = Seq.empty<string>
387381

388382
let mutable resolverReferences = Seq.empty<string>
389383
let nativeProbingRoots () = resolverPackageRoots
390-
let assemblyPaths () = resolverReferences
391384

392385
// Restore packages, Get Reference dll paths and package roots
393386
let result =
@@ -526,10 +519,7 @@ x |> Seq.iter(fun r ->
526519
ResolvingErrorReport (report)
527520

528521
let mutable resolverPackageRoots = Seq.empty<string>
529-
let mutable resolverReferences = Seq.empty<string>
530-
531522
let nativeProbingRoots () = resolverPackageRoots
532-
let assemblyProbingPaths () = resolverReferences
533523

534524
// Restore packages, Get Reference dll paths and package roots
535525
let result =
@@ -552,10 +542,7 @@ x |> Seq.iter(fun r ->
552542
ResolvingErrorReport (report)
553543

554544
let mutable resolverPackageRoots = Seq.empty<string>
555-
let mutable resolverReferences = Seq.empty<string>
556-
557545
let nativeProbingRoots () = resolverPackageRoots
558-
let assemblyProbingPaths () = resolverReferences
559546

560547
// Restore packages, Get Reference dll paths and package roots
561548
let result =
@@ -740,7 +727,7 @@ x |> Seq.iter(fun r ->
740727
use script = new FSharpScript(quiet = false, langVersion = LangVersion.V47)
741728

742729
use capture = new TestConsole.ExecutionCapture()
743-
let opt = script.Eval("#help") |> getValue
730+
let _opt = script.Eval("#help") |> getValue
744731

745732
let output = capture.OutText
746733

@@ -772,7 +759,7 @@ x |> Seq.iter(fun r ->
772759
use script = new FSharpScript(quiet = false, langVersion = LangVersion.Preview)
773760

774761
use capture = new TestConsole.ExecutionCapture()
775-
let opt = script.Eval("#help") |> getValue
762+
let _opt = script.Eval("#help") |> getValue
776763

777764
let output = capture.OutText
778765

@@ -871,7 +858,7 @@ x |> Seq.iter(fun r ->
871858
let idm = dp.TryFindDependencyManagerByKey(Seq.empty, "", reportError, "nuget")
872859

873860
// Resolve and cache the results won't time out
874-
let result = dp.Resolve(idm, ".fsx", [|"r", "FSharp.Data,3.3.3"; "r", "timeout=10000"|], reportError, "net9.0", null, "", "", "", -1) // Wait forever
861+
let _result = dp.Resolve(idm, ".fsx", [|"r", "FSharp.Data,3.3.3"; "r", "timeout=10000"|], reportError, "net9.0", null, "", "", "", -1) // Wait forever
875862

876863
// Clear the results
877864
foundCorrectError <- false

0 commit comments

Comments
 (0)