Skip to content

Commit 03a3f6a

Browse files
committed
resolving more review comments
1 parent d258ba9 commit 03a3f6a

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

src/Microsoft.ML.OnnxTransform/OnnxCatalog.cs

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,12 @@ public static class OnnxCatalog
1111
{
1212
/// <summary>
1313
/// Applies a pre-trained Onnx model.
14+
/// </summary>
15+
/// <remarks>
1416
/// All column names are provided, the input data column names/types must exactly match
1517
/// all model input names. All possible output columns are then generated, with names/types
1618
/// specified by the model.
17-
/// </summary>
19+
/// </remarks>
1820
/// <param name="catalog">The transform's catalog.</param>
1921
/// <param name="modelFile">The path of the file containing the ONNX model.</param>
2022
/// <param name="gpuDeviceId">Optional GPU device ID to run execution on, <see langword="null" /> to run on CPU.</param>
@@ -30,8 +32,8 @@ public static OnnxScoringEstimator ApplyOnnxModel(this TransformsCatalog catalog
3032
/// </summary>
3133
/// <param name="catalog">The transform's catalog.</param>
3234
/// <param name="modelFile">The path of the file containing the ONNX model.</param>
33-
/// <param name="outputColumnName">The input column.</param>
34-
/// <param name="inputColumnName">The output column resulting from the transformation.</param>
35+
/// <param name="outputColumnName">The output column resulting from the transformation.</param>
36+
/// <param name="inputColumnName">The input column.</param>
3537
/// <param name="gpuDeviceId">Optional GPU device ID to run execution on, <see langword="null" /> to run on CPU.</param>
3638
/// <param name="fallbackToCpu">If GPU error, raise exception or fallback to CPU.</param>
3739
public static OnnxScoringEstimator ApplyOnnxModel(this TransformsCatalog catalog,
@@ -47,8 +49,8 @@ public static OnnxScoringEstimator ApplyOnnxModel(this TransformsCatalog catalog
4749
/// </summary>
4850
/// <param name="catalog">The transform's catalog.</param>
4951
/// <param name="modelFile">The path of the file containing the ONNX model.</param>
50-
/// <param name="outputColumnNames">The input columns.</param>
51-
/// <param name="inputColumnNames">The output columns resulting from the transformation.</param>
52+
/// <param name="outputColumnNames">The output columns resulting from the transformation.</param>
53+
/// <param name="inputColumnNames">The input columns.</param>
5254
/// <param name="gpuDeviceId">Optional GPU device ID to run execution on, <see langword="null" /> to run on CPU.</param>
5355
/// <param name="fallbackToCpu">If GPU error, raise exception or fallback to CPU.</param>
5456
public static OnnxScoringEstimator ApplyOnnxModel(this TransformsCatalog catalog,

src/Microsoft.ML.Transforms/KeyToVectorMapping.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,9 @@ private static VersionInfo GetVersionInfo()
5858

5959
private const string RegistrationName = "KeyToBinary";
6060

61-
// The names of the output and input column pairs on which the transformation is performed.
61+
/// <summary>
62+
/// The names of the output and input column pairs on which the transformation is performed.
63+
/// </summary>
6264
public IReadOnlyCollection<(string outputColumnName, string inputColumnName)> Columns => ColumnPairs.AsReadOnly();
6365

6466
private string TestIsKey(ColumnType type)

0 commit comments

Comments
 (0)