Internalize little less trivial stuff.

Author: codemzs

src/Microsoft.ML.FastTree/BoostingFastTree.cs

@@ -15,11 +15,11 @@ public abstract class BoostingFastTreeTrainerBase<TArgs, TTransformer, TModel> :
         where TArgs : BoostedTreeArgs, new()
         where TModel : class
     {
-        protected BoostingFastTreeTrainerBase(IHostEnvironment env, TArgs args, SchemaShape.Column label) : base(env, args, label)
+        internal BoostingFastTreeTrainerBase(IHostEnvironment env, TArgs args, SchemaShape.Column label) : base(env, args, label)
         {
         }
 
-        protected BoostingFastTreeTrainerBase(IHostEnvironment env,
+        internal BoostingFastTreeTrainerBase(IHostEnvironment env,
             SchemaShape.Column label,
             string featureColumn,
             string weightColumn,
@@ -33,7 +33,7 @@ protected BoostingFastTreeTrainerBase(IHostEnvironment env,
             Args.LearningRates = learningRate;
         }
 
-        protected override void CheckArgs(IChannel ch)
+        internal override void CheckArgs(IChannel ch)
         {
             if (Args.OptimizationAlgorithm == BoostedTreeArgs.OptimizationAlgorithmType.AcceleratedGradientDescent)
                 Args.UseLineSearch = true;
@@ -116,7 +116,7 @@ internal override IGradientAdjuster MakeGradientWrapper(IChannel ch)
                 return new BestStepRegressionGradientWrapper();
         }
 
-        protected override bool ShouldStop(IChannel ch, ref IEarlyStoppingCriterion earlyStoppingRule, ref int bestIteration)
+        internal override bool ShouldStop(IChannel ch, ref IEarlyStoppingCriterion earlyStoppingRule, ref int bestIteration)
         {
             if (Args.EarlyStoppingRule == null)
                 return false;
@@ -148,7 +148,7 @@ protected override bool ShouldStop(IChannel ch, ref IEarlyStoppingCriterion earl
             return shouldStop;
         }
 
-        protected override int GetBestIteration(IChannel ch)
+        internal override int GetBestIteration(IChannel ch)
         {
             int bestIteration = Ensemble.NumTrees;
             if (!Args.WriteLastEnsemble && PruningTest != null)
@@ -162,15 +162,15 @@ protected override int GetBestIteration(IChannel ch)
         /// <summary>
         /// Retrieves max tree output if best regression step option is active or returns negative value otherwise.
         /// </summary>
-        protected double BsrMaxTreeOutput()
+        internal double BsrMaxTreeOutput()
         {
             if (Args.BestStepRankingRegressionTrees)
                 return Args.MaxTreeOutput;
             else
                 return -1;
         }
 
-        protected override bool ShouldRandomStartOptimizer()
+        internal override bool ShouldRandomStartOptimizer()
         {
             return Args.RandomStart;
         }