Skip to content

Commit 5254ccd

Browse files
committed
Fix two tests and address a comment
1 parent 842bc13 commit 5254ccd

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

src/Microsoft.ML.StandardTrainers/Standard/LogisticRegression/MulticlassLogisticRegression.cs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"Multiclass LR Executor",
3333
MaximumEntropyModelParameters.LoaderSignature)]
3434

35-
[assembly: EntryPointModule(typeof(LbfgsMaximumEntropyTrainer))]
35+
[assembly: LoadableClass(typeof(void), typeof(LbfgsMaximumEntropyTrainer), null, typeof(SignatureEntryPointModule), LbfgsMaximumEntropyTrainer.LoadNameValue)]
3636

3737
namespace Microsoft.ML.Trainers
3838
{
@@ -41,7 +41,7 @@ namespace Microsoft.ML.Trainers
4141
public sealed class LbfgsMaximumEntropyTrainer : LbfgsTrainerBase<LbfgsMaximumEntropyTrainer.Options,
4242
MulticlassPredictionTransformer<MaximumEntropyModelParameters>, MaximumEntropyModelParameters>
4343
{
44-
internal const string Summary = "Train maximum entropy model for multiclass classification using L-BFGS";
44+
internal const string Summary = "Logistic Regression is a method in statistics used to predict the probability of occurrence of an event and can be used as a classification algorithm.The algorithm predicts the probability of occurrence of an event by fitting data to a logistical function.";
4545
internal const string LoadNameValue = "MultiClassLogisticRegression";
4646
internal const string UserNameValue = "Multi-class Logistic Regression";
4747
internal const string ShortName = "mlr";
@@ -971,9 +971,7 @@ public sealed class LinearMulticlassModelParameters : LinearMulticlassModelParam
971971
private static VersionInfo VersionInfo =>
972972
new VersionInfo(
973973
modelSignature: "MCLINEAR",
974-
// verWrittenCur: 0x00010001, // Initial
975-
// verWrittenCur: 0x00010002, // Added class names
976-
verWrittenCur: 0x00010003, // Added model stats
974+
verWrittenCur: 0x00010001,
977975
verReadableCur: 0x00010001,
978976
verWeCanReadBack: 0x00010001,
979977
loaderSignature: LoaderSignature,

test/BaselineOutput/Common/Command/CommandTrainMlrWithStats-summary.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
LogisticRegressionMulticlassClassificationTrainer bias and non-zero weights
1+
LbfgsMaximumEntropyTrainer bias and non-zero weights
22
Iris-setosa+(Bias) 2.265129
33
Iris-versicolor+(Bias) 0.7695086
44
Iris-virginica+(Bias) -3.034663

0 commit comments

Comments
 (0)