Skip to content

Commit 5c20ebb

Browse files
author
Rogan Carr
committed
Addressing PR comments.
1 parent 0ffecfc commit 5c20ebb

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/SelectColumns.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,19 +42,19 @@ public static void Example()
4242
var rowEnumerable = mlContext.CreateEnumerable<SampleInfertDataTransformed>(transformedData, reuseRowObject: false);
4343

4444
// And finally, we can write out the rows of the dataset, looking at the columns of interest.
45-
Console.WriteLine($"Label and Educations columns obtained post-transformation.");
45+
Console.WriteLine($"Age and Educations columns obtained post-transformation.");
4646
foreach (var row in rowEnumerable)
4747
{
48-
Console.WriteLine($"Label: {row.Age} Education: {row.Education}");
48+
Console.WriteLine($"Age: {row.Age} Education: {row.Education}");
4949
}
5050

5151
// Expected output:
52-
// Label and Education columns obtained post-transformation.
53-
// Label: 26 Education: 0 - 5yrs
54-
// Label: 42 Education: 0 - 5yrs
55-
// Label: 39 Education: 0 - 5yrs
56-
// Label: 34 Education: 0 - 5yrs
57-
// Label: 35 Education: 6 - 11yrs
52+
// Age and Education columns obtained post-transformation.
53+
// Age: 26 Education: 0 - 5yrs
54+
// Age: 42 Education: 0 - 5yrs
55+
// Age: 39 Education: 0 - 5yrs
56+
// Age: 34 Education: 0 - 5yrs
57+
// Age: 35 Education: 6 - 11yrs
5858
}
5959

6060
private class SampleInfertDataTransformed

src/Microsoft.ML.Data/Transforms/ExtensionsCatalog.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,10 @@ public static ColumnSelectingEstimator DropColumns(this TransformsCatalog catalo
7575
/// <remarks>
7676
/// <format type="text/markdown">
7777
/// <see cref="SelectColumns"/> operates on the schema of an input IDataView,
78-
/// either dropping unselected columns from the schema or keeping them but hiding them from the user. Keeping columns hidden
78+
/// either dropping unselected columns from the schema or keeping them but marking them as hidden in the schema. Keeping columns hidden
7979
/// is recommended when it is necessary to understand how the inputs of a pipeline map to outputs of the pipeline. This feature
80-
/// is used, for example, in saving models so that the model can be easily debugged at a later time. For more information,
81-
/// please refer to [IDataView Design Principles](~/../docs/samples/docs/code/IDataViewDesignPrinciples.md).
80+
/// is useful, for example, in debugging a pipeline of transforms by allowing you to print out results from the middle of the pipeline.
81+
/// For more information on hidden columns, please refer to [IDataView Design Principles](~/../docs/samples/docs/code/IDataViewDesignPrinciples.md).
8282
/// </format>
8383
/// </remarks>
8484
/// <param name="catalog">The transform's catalog.</param>
@@ -87,7 +87,7 @@ public static ColumnSelectingEstimator DropColumns(this TransformsCatalog catalo
8787
/// <example>
8888
/// <format type="text/markdown">
8989
/// <![CDATA[
90-
/// [!code-csharp[Concat](~/../docs/samples/docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/SelectColumns.cs)]
90+
/// [!code-csharp[SelectColumns](~/../docs/samples/docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/SelectColumns.cs)]
9191
/// ]]>
9292
/// </format>
9393
/// </example>

0 commit comments

Comments
 (0)