Remaining

Author: artidoro

src/Microsoft.ML.Data/Depricated/Instances/HeaderSchema.cs

@@ -151,7 +151,7 @@ private static VersionInfo GetVersionInfo()
                 loaderAssemblyName: typeof(FeatureNameCollection).Assembly.FullName);
         }
 
-        public static void Save(ModelSaveContext ctx, in VBuffer<ReadOnlyMemory<char>> names)
+        internal static void Save(ModelSaveContext ctx, in VBuffer<ReadOnlyMemory<char>> names)
         {
             Contracts.AssertValue(ctx);
             ctx.CheckAtModel();

src/Microsoft.ML.FastTree/TreeEnsemble/InternalQuantileRegressionTree.cs

@@ -50,7 +50,7 @@ public InternalQuantileRegressionTree(byte[] buffer, ref int position)
             _instanceWeights = buffer.ToDoubleArray(ref position);
         }
 
-        public override void Save(ModelSaveContext ctx)
+        internal override void Save(ModelSaveContext ctx)
         {
             // *** Binary format ***
             // double[]: Labels Distribution.

src/Microsoft.ML.FastTree/TreeEnsemble/InternalRegressionTree.cs

@@ -409,7 +409,7 @@ protected void Save(ModelSaveContext ctx, TreeType code)
             writer.WriteDoubleArray(_previousLeafValue);
         }
 
-        public virtual void Save(ModelSaveContext ctx)
+        internal virtual void Save(ModelSaveContext ctx)
         {
             Save(ctx, TreeType.Regression);
         }

src/Microsoft.ML.FastTree/TreeEnsemble/InternalTreeEnsemble.cs

@@ -56,7 +56,7 @@ public InternalTreeEnsemble(ModelLoadContext ctx, bool usingDefaultValues, bool
             _firstInputInitializationContent = ctx.LoadStringOrNull();
         }
 
-        public void Save(ModelSaveContext ctx)
+        internal void Save(ModelSaveContext ctx)
         {
             // *** Binary format ***
             // int: Number of trees

src/Microsoft.ML.FastTree/TreeEnsembleFeaturizer.cs

@@ -387,7 +387,7 @@ public TreeEnsembleFeaturizerBindableMapper(IHostEnvironment env, ModelLoadConte
             _totalLeafCount = CountLeaves(_ensemble);
         }
 
-        public void Save(ModelSaveContext ctx)
+        void ICanSaveModel.Save(ModelSaveContext ctx)
         {
             _host.CheckValue(ctx, nameof(ctx));
             ctx.CheckAtModel();

src/Microsoft.ML.HalLearners/VectorWhitening.cs

@@ -464,7 +464,7 @@ private static void TrainModels(IHostEnvironment env, IChannel ch, float[][] col
             }
         }
 
-        public override void Save(ModelSaveContext ctx)
+        private protected override void SaveModel(ModelSaveContext ctx)
         {
             Host.CheckValue(ctx, nameof(ctx));
             ctx.CheckAtModel();

src/Microsoft.ML.ImageAnalytics/ImageGrayscale.cs

@@ -141,7 +141,7 @@ private static IDataTransform Create(IHostEnvironment env, ModelLoadContext ctx,
         private static IRowMapper Create(IHostEnvironment env, ModelLoadContext ctx, Schema inputSchema)
             => Create(env, ctx).MakeRowMapper(inputSchema);
 
-        public override void Save(ModelSaveContext ctx)
+        private protected override void SaveModel(ModelSaveContext ctx)
         {
             Host.CheckValue(ctx, nameof(ctx));
 

src/Microsoft.ML.ImageAnalytics/ImageLoader.cs

@@ -138,7 +138,7 @@ protected override void CheckInputColumn(Schema inputSchema, int col, int srcCol
                 throw Host.ExceptSchemaMismatch(nameof(inputSchema), "input", ColumnPairs[col].inputColumnName, TextType.Instance.ToString(), inputSchema[srcCol].Type.ToString());
         }
 
-        public override void Save(ModelSaveContext ctx)
+        private protected override void SaveModel(ModelSaveContext ctx)
         {
             Host.CheckValue(ctx, nameof(ctx));
 

src/Microsoft.ML.ImageAnalytics/ImagePixelExtractor.cs

@@ -252,7 +252,7 @@ private static IDataTransform Create(IHostEnvironment env, ModelLoadContext ctx,
         private static IRowMapper Create(IHostEnvironment env, ModelLoadContext ctx, Schema inputSchema)
             => Create(env, ctx).MakeRowMapper(inputSchema);
 
-        public override void Save(ModelSaveContext ctx)
+        private protected override void SaveModel(ModelSaveContext ctx)
         {
             Host.CheckValue(ctx, nameof(ctx));
 

src/Microsoft.ML.ImageAnalytics/ImageResizer.cs

@@ -235,7 +235,7 @@ private static IDataTransform Create(IHostEnvironment env, ModelLoadContext ctx,
         private static IRowMapper Create(IHostEnvironment env, ModelLoadContext ctx, Schema inputSchema)
             => Create(env, ctx).MakeRowMapper(inputSchema);
 
-        public override void Save(ModelSaveContext ctx)
+        private protected override void SaveModel(ModelSaveContext ctx)
         {
             Host.CheckValue(ctx, nameof(ctx));
 

src/Microsoft.ML.ImageAnalytics/VectorToImageTransform.cs

@@ -195,7 +195,7 @@ public ColInfoEx(ModelLoadContext ctx)
                 Interleave = ctx.Reader.ReadBoolByte();
             }
 
-            public void Save(ModelSaveContext ctx)
+            internal void Save(ModelSaveContext ctx)
             {
                 Contracts.AssertValue(ctx);
 
@@ -306,7 +306,7 @@ public static VectorToImageTransform Create(IHostEnvironment env, ModelLoadConte
                 });
         }
 
-        public override void Save(ModelSaveContext ctx)
+        private protected override void SaveModel(ModelSaveContext ctx)
         {
             Host.CheckValue(ctx, nameof(ctx));
             ctx.CheckAtModel();

src/Microsoft.ML.OnnxTransform/OnnxTransform.cs

@@ -261,7 +261,7 @@ public OnnxTransformer(IHostEnvironment env, string[] outputColumnNames, string[
         {
         }
 
-        public override void Save(ModelSaveContext ctx)
+        private protected override void SaveModel(ModelSaveContext ctx)
         {
             Host.AssertValue(ctx);
 
@@ -368,7 +368,7 @@ private protected override Func<int, bool> GetDependenciesCore(Func<int, bool> a
                 return col => Enumerable.Range(0, _parent.Outputs.Length).Any(i => activeOutput(i)) && _inputColIndices.Any(i => i == col);
             }
 
-            public override void Save(ModelSaveContext ctx) => _parent.Save(ctx);
+            private protected override void SaveModel(ModelSaveContext ctx) => _parent.SaveModel(ctx);
 
             private interface INamedOnnxValueGetter
             {

src/Microsoft.ML.PCA/PcaTransformer.cs

@@ -140,7 +140,7 @@ public TransformInfo(ModelLoadContext ctx)
                 Contracts.CheckDecode(MeanProjected == null || (MeanProjected.Length == Rank && FloatUtils.IsFinite(MeanProjected)));
             }
 
-            public void Save(ModelSaveContext ctx)
+            internal void Save(ModelSaveContext ctx)
             {
                 Contracts.AssertValue(ctx);
 
@@ -279,7 +279,7 @@ private static PrincipalComponentAnalysisTransformer Create(IHostEnvironment env
             return new PrincipalComponentAnalysisTransformer(host, ctx);
         }
 
-        public override void Save(ModelSaveContext ctx)
+        private protected override void SaveModel(ModelSaveContext ctx)
         {
             Host.CheckValue(ctx, nameof(ctx));
             ctx.CheckAtModel();

src/Microsoft.ML.Parquet/ParquetLoader.cs

@@ -406,7 +406,7 @@ public RowCursor[] GetRowCursorSet(IEnumerable<DataViewSchema.Column> columnsNee
             return new RowCursor[] { GetRowCursor(columnsNeeded, rand) };
         }
 
-        public void Save(ModelSaveContext ctx)
+        void ICanSaveModel.Save(ModelSaveContext ctx)
         {
             Contracts.CheckValue(ctx, nameof(ctx));
             ctx.CheckAtModel();

src/Microsoft.ML.Parquet/PartitionedFileLoader.cs

@@ -253,7 +253,7 @@ public static PartitionedFileLoader Create(IHostEnvironment env, ModelLoadContex
                 ch => new PartitionedFileLoader(host, ctx, files));
         }
 
-        public void Save(ModelSaveContext ctx)
+        void ICanSaveModel.Save(ModelSaveContext ctx)
         {
             Contracts.CheckValue(ctx, nameof(ctx));
             ctx.CheckAtModel();

src/Microsoft.ML.Parquet/PartitionedPathParser.cs

@@ -148,7 +148,7 @@ public static SimplePartitionedPathParser Create(IHostEnvironment env, ModelLoad
                 ch => new SimplePartitionedPathParser(host, ctx));
         }
 
-        public void Save(ModelSaveContext ctx)
+        void ICanSaveModel.Save(ModelSaveContext ctx)
         {
             Contracts.CheckValue(ctx, nameof(ctx));
             ctx.SetVersionInfo(GetVersionInfo());
@@ -261,7 +261,7 @@ public static ParquetPartitionedPathParser Create(IHostEnvironment env, ModelLoa
                 ch => new ParquetPartitionedPathParser(host, ctx));
         }
 
-        public void Save(ModelSaveContext ctx)
+        void ICanSaveModel.Save(ModelSaveContext ctx)
         {
             Contracts.CheckValue(ctx, nameof(ctx));
             ctx.SetVersionInfo(GetVersionInfo());

src/Microsoft.ML.Recommender/MatrixFactorizationPredictor.cs

@@ -142,7 +142,7 @@ public static MatrixFactorizationPredictor Create(IHostEnvironment env, ModelLoa
         /// <summary>
         /// Save model to the given context
         /// </summary>
-        public void Save(ModelSaveContext ctx)
+        void ICanSaveModel.Save(ModelSaveContext ctx)
         {
             ctx.CheckAtModel();
             ctx.SetVersionInfo(GetVersionInfo());
@@ -375,7 +375,7 @@ public Row GetRow(Row input, Func<int, bool> active)
         }
     }
 
-    public sealed class MatrixFactorizationPredictionTransformer : PredictionTransformerBase<MatrixFactorizationPredictor, GenericScorer>, ICanSaveModel
+    public sealed class MatrixFactorizationPredictionTransformer : PredictionTransformerBase<MatrixFactorizationPredictor, GenericScorer>
     {
         public const string LoaderSignature = "MaFactPredXf";
         public string MatrixColumnIndexColumnName { get; }
@@ -469,7 +469,7 @@ public override Schema GetOutputSchema(Schema inputSchema)
             return Transform(new EmptyDataView(Host, inputSchema)).Schema;
         }
 
-        public void Save(ModelSaveContext ctx)
+        private protected override void SaveModel(ModelSaveContext ctx)
         {
             Host.CheckValue(ctx, nameof(ctx));
             ctx.CheckAtModel();

src/Microsoft.ML.StandardLearners/FactorizationMachine/FieldAwareFactorizationMachineModelParameters.cs

@@ -283,7 +283,7 @@ public float[] GetLatentWeights()
         }
     }
 
-    public sealed class FieldAwareFactorizationMachinePredictionTransformer : PredictionTransformerBase<FieldAwareFactorizationMachineModelParameters, BinaryClassifierScorer>, ICanSaveModel
+    public sealed class FieldAwareFactorizationMachinePredictionTransformer : PredictionTransformerBase<FieldAwareFactorizationMachineModelParameters, BinaryClassifierScorer>
     {
         public const string LoaderSignature = "FAFMPredXfer";
 
@@ -389,7 +389,7 @@ public override Schema GetOutputSchema(Schema inputSchema)
         /// Saves the transformer to file.
         /// </summary>
         /// <param name="ctx">The <see cref="ModelSaveContext"/> that facilitates saving to the <see cref="Repository"/>.</param>
-        public void Save(ModelSaveContext ctx)
+        private protected override void SaveModel(ModelSaveContext ctx)
         {
             Host.CheckValue(ctx, nameof(ctx));
             ctx.CheckAtModel();

src/Microsoft.ML.StandardLearners/Standard/ModelStatistics.cs

@@ -166,7 +166,7 @@ internal static LinearModelStatistics Create(IHostEnvironment env, ModelLoadCont
             return new LinearModelStatistics(env, ctx);
         }
 
-        public void Save(ModelSaveContext ctx)
+        void ICanSaveModel.Save(ModelSaveContext ctx)
         {
             Contracts.AssertValue(_env);
             _env.CheckValue(ctx, nameof(ctx));

src/Microsoft.ML.TensorFlow/TensorflowTransform.cs

@@ -706,7 +706,7 @@ internal static (TFDataType[] tfOutputTypes, ColumnType[] outputTypes) GetOutput
 
         private protected override IRowMapper MakeRowMapper(Schema inputSchema) => new Mapper(this, inputSchema);
 
-        public override void Save(ModelSaveContext ctx)
+        private protected override void SaveModel(ModelSaveContext ctx)
         {
             Host.AssertValue(ctx);
             ctx.CheckAtModel();
@@ -874,7 +874,7 @@ public Mapper(TensorFlowTransformer parent, Schema inputSchema) :
                 }
             }
 
-            public override void Save(ModelSaveContext ctx) => _parent.Save(ctx);
+            private protected override void SaveModel(ModelSaveContext ctx) => _parent.SaveModel(ctx);
 
             private class OutputCache
             {

src/Microsoft.ML.Transforms/RandomFourierFeaturizing.cs

@@ -162,7 +162,7 @@ public TransformInfo(IHostEnvironment env, ModelLoadContext ctx, string director
                 InitializeFourierCoefficients(roundedUpNumFeatures, roundedUpD);
             }
 
-            public void Save(ModelSaveContext ctx, string directoryName)
+            internal void Save(ModelSaveContext ctx, string directoryName)
             {
                 Contracts.AssertValue(ctx);