Finish forgotten utils since I apparently got distracted

Author: TomFinley

src/Microsoft.ML.Core/Utilities/ReservoirSampler.cs

@@ -13,7 +13,8 @@ namespace Microsoft.ML.Runtime.Internal.Utilities
     /// The sample is created in one pass by calling <see cref="Sample"/> for every data point in the stream. Implementations should have
     /// a delegate for getting the next data point, which is invoked if the current data point should go into the reservoir.
     /// </summary>
-    public interface IReservoirSampler<T>
+    [BestFriend]
+    internal interface IReservoirSampler<T>
     {
         /// <summary>
         /// If the number of elements sampled is less than the reservoir size, this should return the number of elements sampled.
@@ -49,7 +50,8 @@ public interface IReservoirSampler<T>
     /// for every data point in the stream. In case the next data point does not get 'picked' into the reservoir, the delegate is not invoked.
     /// Sampling is done according to the algorithm in this paper: <a href="https://epubs.siam.org/doi/pdf/10.1137/1.9781611972740.53">https://epubs.siam.org/doi/pdf/10.1137/1.9781611972740.53</a>.
     /// </summary>
-    public sealed class ReservoirSamplerWithoutReplacement<T> : IReservoirSampler<T>
+    [BestFriend]
+    internal sealed class ReservoirSamplerWithoutReplacement<T> : IReservoirSampler<T>
     {
         // This array contains a cache of the elements composing the reservoir.
         private readonly T[] _cache;
@@ -122,7 +124,8 @@ public IEnumerable<T> GetSample()
     /// for every data point in the stream. In case the next data point does not get 'picked' into the reservoir, the delegate is not invoked.
     /// Sampling is done according to the algorithm in this paper: <a href="https://epubs.siam.org/doi/pdf/10.1137/1.9781611972740.53">https://epubs.siam.org/doi/pdf/10.1137/1.9781611972740.53</a>.
     /// </summary>
-    public sealed class ReservoirSamplerWithReplacement<T> : IReservoirSampler<T>
+    [BestFriend]
+    internal sealed class ReservoirSamplerWithReplacement<T> : IReservoirSampler<T>
     {
         // This array contains pointers to the elements in the _cache array that are currently in the reservoir (may contain duplicates).
         private readonly int[] _reservoir;

src/Microsoft.ML.Core/Utilities/ResourceManagerUtils.cs

@@ -16,7 +16,8 @@ namespace Microsoft.ML.Runtime.Internal.Utilities
     /// This class takes care of downloading resources needed by ML.NET components. Resources are located in
     /// a pre-defined location, that can be overridden by defining Environment variable <see cref="CustomResourcesUrlEnvVariable"/>.
     /// </summary>
-    public sealed class ResourceManagerUtils
+    [BestFriend]
+    internal sealed class ResourceManagerUtils
     {
         private static volatile ResourceManagerUtils _instance;
         public static ResourceManagerUtils Instance
@@ -301,7 +302,9 @@ public static ResourceDownloadResults GetErrorMessage(out string errorMessage, p
             return errorResult;
         }
 
+#pragma warning disable IDE1006
         [DllImport("libc", SetLastError = true)]
         private static extern int chmod(string pathname, int mode);
+#pragma warning restore IDE1006
     }
 }

src/Microsoft.ML.Core/Utilities/Stats.cs

@@ -11,7 +11,8 @@ namespace Microsoft.ML.Runtime.Internal.Utilities
     /// <summary>
     /// A class containing common statistical functions
     /// </summary>
-    public static class Stats
+    [BestFriend]
+    internal static class Stats
     {
         /// <summary>
         /// Returns a number uniformly sampled from 0...(rangeSize-1)

src/Microsoft.ML.Core/Utilities/SubsetStream.cs

@@ -22,7 +22,8 @@ namespace Microsoft.ML.Runtime.Internal.Utilities
     /// subset stream, the underlying stream will always remain open and
     /// undisposed.
     /// </summary>
-    public sealed class SubsetStream : Stream
+    [BestFriend]
+    internal sealed class SubsetStream : Stream
     {
         private readonly Stream _stream;
         // The position of the stream.

src/Microsoft.ML.Core/Utilities/SummaryStatistics.cs

@@ -6,7 +6,7 @@
 
 namespace Microsoft.ML.Runtime.Internal.Utilities
 {
-    public abstract class SummaryStatisticsBase
+    internal abstract class SummaryStatisticsBase
     {
         // Sum of squared difference from the current mean.
         protected double M2;
@@ -152,7 +152,8 @@ public void Add(SummaryStatisticsBase s)
         }
     }
 
-    public sealed class SummaryStatisticsUpToSecondOrderMoments : SummaryStatisticsBase
+    [BestFriend]
+    internal sealed class SummaryStatisticsUpToSecondOrderMoments : SummaryStatisticsBase
     {
         /// <summary>
         /// A convenient way to combine the observations of two Stats objects
@@ -177,7 +178,8 @@ public sealed class SummaryStatisticsUpToSecondOrderMoments : SummaryStatisticsB
     /// https://en.wikipedia.org/wiki/Algorithms_for_calculating_variance
     /// All quantities are weighted, except for <c>RawCount</c>.
     /// </summary>
-    public sealed class SummaryStatistics : SummaryStatisticsBase
+    [BestFriend]
+    internal sealed class SummaryStatistics : SummaryStatisticsBase
     {
         // Sum of cubed difference from the current mean.
         private double _m3;

src/Microsoft.ML.Core/Utilities/SupervisedBinFinder.cs

@@ -20,7 +20,8 @@ namespace Microsoft.ML.Runtime.Internal.Utilities
     /// The class can be used several times sequentially, it is stateful and not thread-safe.
     /// Both Single and Double precision processing is implemented, and is identical.
     /// </summary>
-    public sealed class SupervisedBinFinder
+    [BestFriend]
+    internal sealed class SupervisedBinFinder
     {
         private readonly struct ValuePair<T> : IComparable<ValuePair<T>>
             where T : IComparable<T>

src/Microsoft.ML.Core/Utilities/TextReaderStream.cs

@@ -14,7 +14,8 @@ namespace Microsoft.ML.Runtime.Internal.Utilities
     /// compensates by inserting <c>\n</c> line feed characters at the end of every
     /// input line, including the last one.
     /// </summary>
-    public sealed class TextReaderStream : Stream
+    [BestFriend]
+    internal sealed class TextReaderStream : Stream
     {
         private readonly TextReader _baseReader;
         private readonly Encoding _encoding;

src/Microsoft.ML.Core/Utilities/ThreadUtils.cs

@@ -59,7 +59,8 @@ public static Thread CreateForegroundThread(ThreadStart start)
     /// that the workers have finished by its own means, will call <see cref="ThrowIfSet"/> to throw
     /// the set exception as an inner exception, in the wrapping thread.
     /// </summary>
-    public sealed class ExceptionMarshaller : IDisposable
+    [BestFriend]
+    internal sealed class ExceptionMarshaller : IDisposable
     {
         private readonly CancellationTokenSource _ctSource;
         private readonly object _lock;
@@ -130,7 +131,8 @@ public void ThrowIfSet(IExceptionContext ectx)
     /// Provides a task scheduler that ensures a maximum concurrency level while
     /// running on top of the ThreadPool.
     /// </summary>
-    public sealed class LimitedConcurrencyLevelTaskScheduler : TaskScheduler
+    [BestFriend]
+    internal sealed class LimitedConcurrencyLevelTaskScheduler : TaskScheduler
     {
         // Whether the current thread is processing work items.
         [ThreadStatic]

src/Microsoft.ML.Core/Utilities/Tree.cs

@@ -17,7 +17,8 @@ namespace Microsoft.ML.Runtime.Internal.Utilities
     /// </summary>
     /// <typeparam name="TKey">Children are keyed with values of this type</typeparam>
     /// <typeparam name="TValue">The type of the node value</typeparam>
-    public sealed class Tree<TKey, TValue> : IDictionary<TKey, Tree<TKey, TValue>>
+    [BestFriend]
+    internal sealed class Tree<TKey, TValue> : IDictionary<TKey, Tree<TKey, TValue>>
     {
         // The key of this node in the parent, assuming this is a child node at all.
         // This back reference is necessary to complete any "remove" operations.

src/Microsoft.ML.Core/Utilities/VBufferUtils.cs

@@ -14,7 +14,8 @@ namespace Microsoft.ML.Runtime.Internal.Utilities
     /// <summary>
     /// Convenience utilities for vector operations on <see cref="VBuffer{T}"/>.
     /// </summary>
-    public static class VBufferUtils
+    [BestFriend]
+    internal static class VBufferUtils
     {
         private const float SparsityThreshold = 0.25f;
 

src/Microsoft.ML.Data/DataLoadSave/Binary/Zlib/Zlib.cs

@@ -12,6 +12,7 @@ internal static class Zlib
     {
         public const string DllPath = "zlib.dll";
 
+#pragma warning disable IDE1006
         [DllImport(DllPath), SuppressUnmanagedCodeSecurity]
         private static extern unsafe Constants.RetCode deflateInit2_(ZStream* strm, int level, int method, int windowBits,
             int memLevel, Constants.Strategy strategy, byte* version, int streamSize);
@@ -44,6 +45,7 @@ public static unsafe Constants.RetCode InflateInit2(ZStream* strm, int windowBit
 
         [DllImport(DllPath), SuppressUnmanagedCodeSecurity]
         public static extern unsafe Constants.RetCode inflateEnd(ZStream* strm);
+#pragma warning restore IDE1006
     }
 
     [StructLayout(LayoutKind.Sequential)]

src/Microsoft.ML.Data/Evaluators/AucAggregator.cs

@@ -11,7 +11,7 @@ namespace Microsoft.ML.Runtime.Data
 {
     public abstract partial class EvaluatorBase<TAgg>
     {
-        protected abstract class AucAggregatorBase
+        internal abstract class AucAggregatorBase
         {
             protected Single Score;
             protected Single Label;
@@ -30,7 +30,7 @@ public void ProcessRow(Single label, Single score, Single weight = 1)
             public abstract Double ComputeWeightedAuc(out Double unweighted);
         }
 
-        protected abstract class AucAggregatorBase<T> : AucAggregatorBase
+        internal abstract class AucAggregatorBase<T> : AucAggregatorBase
         {
             private readonly ReservoirSamplerWithoutReplacement<T> _posReservoir;
             private readonly ReservoirSamplerWithoutReplacement<T> _negReservoir;
@@ -117,7 +117,7 @@ public override Double ComputeWeightedAuc(out Double unweighted)
             protected abstract Double ComputeWeightedAucCore(out double unweighted);
         }
 
-        protected sealed class UnweightedAucAggregator : AucAggregatorBase<Single>
+        internal sealed class UnweightedAucAggregator : AucAggregatorBase<Single>
         {
             public UnweightedAucAggregator(IRandom rand, int reservoirSize)
                 : base(rand, reservoirSize)
@@ -210,7 +210,7 @@ protected override void AddExample(List<Single> examples)
             }
         }
 
-        protected sealed class WeightedAucAggregator : AucAggregatorBase<WeightedAucAggregator.AucInfo>
+        internal sealed class WeightedAucAggregator : AucAggregatorBase<WeightedAucAggregator.AucInfo>
         {
             public struct AucInfo
             {
@@ -345,7 +345,7 @@ protected override void AddExample(List<AucInfo> examples)
             }
         }
 
-        public abstract class AuPrcAggregatorBase
+        internal abstract class AuPrcAggregatorBase
         {
             protected Single Score;
             protected Single Label;
@@ -364,7 +364,7 @@ public void ProcessRow(Single label, Single score, Single weight = 1)
             public abstract Double ComputeWeightedAuPrc(out Double unweighted);
         }
 
-        protected abstract class AuPrcAggregatorBase<T> : AuPrcAggregatorBase
+        private protected abstract class AuPrcAggregatorBase<T> : AuPrcAggregatorBase
         {
             protected readonly ReservoirSamplerWithoutReplacement<T> Reservoir;
 
@@ -393,7 +393,7 @@ public override Double ComputeWeightedAuPrc(out Double unweighted)
             protected abstract Double ComputeWeightedAuPrcCore(out Double unweighted);
         }
 
-        protected sealed class UnweightedAuPrcAggregator : AuPrcAggregatorBase<UnweightedAuPrcAggregator.Info>
+        private protected sealed class UnweightedAuPrcAggregator : AuPrcAggregatorBase<UnweightedAuPrcAggregator.Info>
         {
             public struct Info
             {
@@ -466,7 +466,7 @@ protected override ValueGetter<Info> GetSampleGetter()
             }
         }
 
-        protected sealed class WeightedAuPrcAggregator : AuPrcAggregatorBase<WeightedAuPrcAggregator.Info>
+        private protected sealed class WeightedAuPrcAggregator : AuPrcAggregatorBase<WeightedAuPrcAggregator.Info>
         {
             public struct Info
             {

src/Microsoft.ML.Data/Evaluators/BinaryClassifierEvaluator.cs

@@ -535,7 +535,7 @@ private struct RocInfo
             public readonly List<Double> WeightedRecall;
             public readonly List<Double> WeightedFalsePositiveRate;
 
-            public readonly AuPrcAggregatorBase AuPrcAggregator;
+            internal readonly AuPrcAggregatorBase AuPrcAggregator;
             public double WeightedAuPrc;
             public double UnweightedAuPrc;
 

src/Microsoft.ML.Data/Properties/AssemblyInfo.cs

@@ -10,6 +10,7 @@
 
 [assembly: InternalsVisibleTo(assemblyName: "Microsoft.ML.Legacy" + PublicKey.Value)]
 [assembly: InternalsVisibleTo(assemblyName: "Microsoft.ML.Maml" + PublicKey.Value)]
+[assembly: InternalsVisibleTo(assemblyName: "Microsoft.ML.ResultProcessor" + PublicKey.Value)]
 
 [assembly: InternalsVisibleTo(assemblyName: "Microsoft.ML.Data" + PublicKey.Value)]
 [assembly: InternalsVisibleTo(assemblyName: "Microsoft.ML.Api" + PublicKey.Value)]

src/Microsoft.ML.Data/Utilities/StreamUtils.cs

@@ -9,7 +9,8 @@
 namespace Microsoft.ML.Runtime.Internal.Utilities
 {
     // REVIEW: Implement properly on CoreCLR.
-    public static class StreamUtils
+    [BestFriend]
+    internal static class StreamUtils
     {
         public static Stream OpenInStream(string fileName)
         {

src/Microsoft.ML.Data/Utilities/TimerScope.cs

@@ -3,17 +3,16 @@
 // See the LICENSE file in the project root for more information.
 
 using System;
-using Microsoft.ML.Runtime;
-using Microsoft.ML.Runtime.Data;
 
 namespace Microsoft.ML.Runtime.Internal.Utilities
 {
     using Stopwatch = System.Diagnostics.Stopwatch;
 
     /// <summary>
-    /// A timer scope class that starts a Stopwatch when created, calculates and prints elapsed time, physical and virtual memory usages before sending these to the telemetry when disposed.
+    /// A timer scope class that starts a <see cref="Stopwatch"/> when created, calculates and prints elapsed time, physical and virtual memory usages before sending these to the telemetry when disposed.
     /// </summary>
-    public sealed class TimerScope : IDisposable
+    [BestFriend]
+    internal sealed class TimerScope : IDisposable
     {
         // Note that this class does not own nor dispose of this channel.
         private readonly IChannel _ch;

src/Microsoft.ML.Data/Utils/IntSequencePool.cs renamed to src/Microsoft.ML.Data/Utils/SequencePool.cs

@@ -3,13 +3,7 @@
 // See the LICENSE file in the project root for more information.
 
 using System;
-using System.Collections.Generic;
-using System.Collections;
 using System.IO;
-using System.Linq;
-using System.Threading;
-using System.Text;
-using Microsoft.ML.Runtime.Model;
 
 namespace Microsoft.ML.Runtime.Internal.Utilities
 {
@@ -19,7 +13,8 @@ namespace Microsoft.ML.Runtime.Internal.Utilities
     /// A dictionary of uint sequences of variable length. Stores the sequences as
     /// byte sequences encoded with LEB128. Empty sequences (or null) are also valid.
     /// </summary>
-    public sealed class SequencePool
+    [BestFriend]
+    internal sealed class SequencePool
     {
         // uint sequences are hashed into _mask+1 buckets. _buckets contains the ID of the first
         // sequence that falls in it (or -1 if it is empty).

src/Microsoft.ML.PipelineInference/DatasetFeaturesInference.cs

@@ -21,19 +21,19 @@ public static class DatasetFeatureInference
     {
         public sealed class Stats
         {
-            [JsonIgnore] public SummaryStatistics Statistics;
+            [JsonIgnore] private SummaryStatistics _statistics;
 
             [JsonIgnore] public double Sum;
 
             public Stats()
             {
-                Statistics = new SummaryStatistics();
+                _statistics = new SummaryStatistics();
             }
 
             public void Add(double x)
             {
                 Sum += x;
-                Statistics.Add(x);
+                _statistics.Add(x);
             }
 
             public void Add(IEnumerable<int> x)
@@ -43,31 +43,31 @@ public void Add(IEnumerable<int> x)
             }
 
             [JsonProperty]
-            public long Count => Statistics.RawCount;
+            public long Count => _statistics.RawCount;
 
             [JsonProperty]
-            public double? NonZeroValueCount => Statistics.RawCount > 20 ? (double?)Statistics.Nonzero : null;
+            public double? NonZeroValueCount => _statistics.RawCount > 20 ? (double?)_statistics.Nonzero : null;
 
             [JsonProperty]
-            public double? Variance => Statistics.RawCount > 20 ? (double?)Statistics.SampleVariance : null;
+            public double? Variance => _statistics.RawCount > 20 ? (double?)_statistics.SampleVariance : null;
 
             [JsonProperty]
-            public double? StandardDeviation => Statistics.RawCount > 20 ? (double?)Statistics.SampleStdDev : null;
+            public double? StandardDeviation => _statistics.RawCount > 20 ? (double?)_statistics.SampleStdDev : null;
 
             [JsonProperty]
-            public double? Skewness => Statistics.RawCount > 20 ? (double?)Statistics.Skewness : null;
+            public double? Skewness => _statistics.RawCount > 20 ? (double?)_statistics.Skewness : null;
 
             [JsonProperty]
-            public double? Kurtosis => Statistics.RawCount > 20 ? (double?)Statistics.Kurtosis : null;
+            public double? Kurtosis => _statistics.RawCount > 20 ? (double?)_statistics.Kurtosis : null;
 
             [JsonProperty]
-            public double? Mean => Statistics.RawCount > 20 ? (double?)Statistics.Mean : null;
+            public double? Mean => _statistics.RawCount > 20 ? (double?)_statistics.Mean : null;
 
             [JsonIgnore]
-            public double Min => Statistics.Min;
+            public double Min => _statistics.Min;
 
             [JsonIgnore]
-            public double Max => Statistics.Max;
+            public double Max => _statistics.Max;
         }
 
         public sealed class Column