Skip to content

Commit ac3a9e0

Browse files
committed
Review comments.
1 parent 49d47b3 commit ac3a9e0

File tree

4 files changed

+8
-9
lines changed

4 files changed

+8
-9
lines changed

docs/samples/Microsoft.ML.Samples/Dynamic/Calibrator.cs

+1-5
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
1-
// Licensed to the .NET Foundation under one or more agreements.
2-
// The .NET Foundation licenses this file to you under the MIT license.
3-
// See the LICENSE file in the project root for more information.
4-
5-
using System;
1+
using System;
62
using System.Linq;
73
using Microsoft.ML.Calibrator;
84
using Microsoft.ML.Data;

src/Microsoft.ML.Core/BestFriendAttribute.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ namespace Microsoft.ML
1313
#endif
1414
{
1515
/// <summary>
16-
/// Intended to be applied to types and members marked as internal to indicate that friend access of this
16+
/// Intended to be applied to types and members with internal scope to indicate that friend access of this
1717
/// internal item is OK from another assembly. This restriction applies only to assemblies that declare the
1818
/// <see cref="WantsToBeBestFriendsAttribute"/> assembly level attribute. Note that this attribute is not
1919
/// transferrable: an internal member with this attribute does not somehow make a containing internal type

src/Microsoft.ML.Data/Prediction/Calibrator.cs

+1
Original file line numberDiff line numberDiff line change
@@ -1703,6 +1703,7 @@ public override ICalibrator CreateCalibrator(IChannel ch)
17031703
}
17041704

17051705
/// <summary>
1706+
/// The pair-adjacent violators calibrator.
17061707
/// The function that is implemented by this calibrator is:
17071708
/// f(x) = v_i, if minX_i &lt;= x &lt;= maxX_i
17081709
/// = linear interpolate between v_i and v_i+1, if maxX_i &lt; x &lt; minX_i+1

src/Microsoft.ML.Data/Prediction/CalibratorCatalog.cs

+5-3
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ protected override Delegate MakeGetter(Row input, int iinfo, Func<int, bool> act
260260
}
261261

262262
/// <summary>
263-
/// The PlattCalibratorEstimator.
263+
/// The Platt calibrator estimator.
264264
/// </summary>
265265
/// <remarks>
266266
/// For the usage pattern see the example in <see cref="CalibratorEstimatorBase{TICalibrator}"/>.
@@ -291,6 +291,8 @@ private protected override CalibratorTransformer<PlattCalibrator> Create(IHostEn
291291

292292
/// <summary>
293293
/// Obtains the probability values by applying the sigmoid: f(x) = 1 / (1 + exp(-slope * x + offset).
294+
/// Note that unlike, say, <see cref="PlattCalibratorEstimator"/>, the fit function here is trivial
295+
/// and just "fits" a calibrator with the provided parameters.
294296
/// </summary>
295297
/// <remarks>
296298
/// For the usage pattern see the example in <see cref="CalibratorEstimatorBase{TICalibrator}"/>.
@@ -347,7 +349,7 @@ internal PlattCalibratorTransformer(IHostEnvironment env, ModelLoadContext ctx)
347349
}
348350

349351
/// <summary>
350-
/// The naive binning-based calibratorEstimator.
352+
/// The naive binning-based calbirator estimator.
351353
/// </summary>
352354
/// <remarks>
353355
/// It divides the range of the outputs into equally sized bins. In each bin,
@@ -399,7 +401,7 @@ internal NaiveCalibratorTransformer(IHostEnvironment env, ModelLoadContext ctx)
399401
}
400402

401403
/// <summary>
402-
/// The PavCalibratorEstimator.
404+
/// The pair-adjacent violators calibrator estimator.
403405
/// </summary>
404406
/// <remarks>
405407
/// For the usage pattern see the example in <see cref="CalibratorEstimatorBase{TICalibrator}"/>.

0 commit comments

Comments
 (0)