Skip to content

Commit be4b42d

Browse files
authored
Enable MSML_TypeParamName for the full solution (#4762)
1 parent ad9b2b0 commit be4b42d

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

.editorconfig

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,6 @@ dotnet_diagnostic.MSML_NoInstanceInitializers.severity = none
2424
# MSML_ParameterLocalVarName: Parameter or local variable name not standard
2525
dotnet_diagnostic.MSML_ParameterLocalVarName.severity = none
2626

27-
# MSML_TypeParamName: Type parameter name not standard
28-
dotnet_diagnostic.MSML_TypeParamName.severity = none
29-
3027
[test/Microsoft.ML.CodeAnalyzer.Tests/**.cs]
3128
# BaseTestClass does not apply for analyzer testing.
3229
# MSML_ExtendBaseTestClass: Test classes should be derived from BaseTestClass

test/Microsoft.ML.AutoML.Tests/UserInputValidationTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ public void TestValidationDataSchemaChecksIgnoreHiddenColumns()
336336
}
337337

338338

339-
private static void ValidateLabelTypeTestCore<LabelRawType>(TaskKind task, PrimitiveDataViewType labelType, bool labelTypeShouldBeValid)
339+
private static void ValidateLabelTypeTestCore<TLabelRawType>(TaskKind task, PrimitiveDataViewType labelType, bool labelTypeShouldBeValid)
340340
{
341341
var dataViewBuilder = new ArrayDataViewBuilder(new MLContext(1));
342342
dataViewBuilder.AddColumn(DefaultColumnNames.Features, NumberDataViewType.Single, 0f);
@@ -346,7 +346,7 @@ private static void ValidateLabelTypeTestCore<LabelRawType>(TaskKind task, Primi
346346
}
347347
else
348348
{
349-
dataViewBuilder.AddColumn(DefaultColumnNames.Label, labelType, Activator.CreateInstance<LabelRawType>());
349+
dataViewBuilder.AddColumn(DefaultColumnNames.Label, labelType, Activator.CreateInstance<TLabelRawType>());
350350
}
351351
var dataView = dataViewBuilder.GetDataView();
352352
var validationExceptionThrown = false;

0 commit comments

Comments
 (0)