Skip to content

Commit eaaa8f4

Browse files
committed
Address comments and update entry-point catalog
1 parent 1fe8d51 commit eaaa8f4

File tree

3 files changed

+604
-403
lines changed

3 files changed

+604
-403
lines changed

src/Microsoft.ML.FastTree/FastTree.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ private protected void TrainCore(IChannel ch)
238238
using (Timer.Time(TimerEvent.TotalTrain))
239239
Train(ch);
240240
if (FastTreeTrainerOptions.ExecutionTime)
241-
PrintExecutionTimes(ch);
241+
PrintExecutionTime(ch);
242242
TrainedEnsemble = Ensemble;
243243
if (FeatureMap != null)
244244
TrainedEnsemble.RemapFeatures(FeatureMap);
@@ -258,7 +258,7 @@ private protected virtual void InitializeThreads(int numThreads)
258258
ThreadTaskManager.Initialize(numThreads);
259259
}
260260

261-
private protected virtual void PrintExecutionTimes(IChannel ch)
261+
private protected virtual void PrintExecutionTime(IChannel ch)
262262
{
263263
ch.Info("Execution time breakdown:\n{0}", Timer.GetString());
264264
}

src/Microsoft.ML.FastTree/FastTreeArguments.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@ public abstract class TreeOptions : LearnerInputBaseWithGroupId
298298
public Double SoftmaxTemperature;
299299

300300
/// <summary>
301-
/// Print execution time breakdown to stdout.
301+
/// Print execution time breakdown to ML.NET channel.
302302
/// </summary>
303303
[Argument(ArgumentType.AtMostOnce, HelpText = "Print execution time breakdown to stdout", ShortName = "et,ExecutionTimes")]
304304
public bool ExecutionTime;
@@ -397,17 +397,19 @@ public abstract class TreeOptions : LearnerInputBaseWithGroupId
397397
/// <summary>
398398
/// Print metrics graph for the first test set.
399399
/// </summary>
400+
[BestFriend]
400401
[Argument(ArgumentType.LastOccurenceWins, HelpText = "Print metrics graph for the first test set", ShortName = "graph", Hide = true)]
401402
[TGUI(NotGui = true)]
402-
public bool PrintTestGraph;
403+
internal bool PrintTestGraph;
403404

404405
/// <summary>
405406
/// Print Train and Validation metrics in graph.
406407
/// </summary>
407408
//It is only enabled if printTestGraph is also set
409+
[BestFriend]
408410
[Argument(ArgumentType.LastOccurenceWins, HelpText = "Print Train and Validation metrics in graph", ShortName = "graphtv", Hide = true)]
409411
[TGUI(NotGui = true)]
410-
public bool PrintTrainValidGraph;
412+
internal bool PrintTrainValidGraph;
411413

412414
/// <summary>
413415
/// Calculate metric values for train/valid/test every k rounds.

0 commit comments

Comments
 (0)