disable test parallelization for ML.Test assembly to avoid crash (#4896)

frank-dong-ms-zz · web-flow · commit f0a8a76a4034 · 2020-02-27T14:29:44.000-08:00
* disable test parallelization for ML.Test assembly to avoid crash

* refine comments
diff --git a/test/Microsoft.ML.Tests/DatabaseLoaderTests.cs b/test/Microsoft.ML.Tests/DatabaseLoaderTests.cs
@@ -170,8 +170,6 @@ public void IrisVectorLightGbm()
         }
 
         [LightGBMFact]
-        //Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined
-        [Trait("Category", "SkipInCI")]
         public void IrisVectorLightGbmWithLoadColumnName()
         {
             if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
diff --git a/test/Microsoft.ML.Tests/FeatureContributionTests.cs b/test/Microsoft.ML.Tests/FeatureContributionTests.cs
@@ -91,8 +91,6 @@ public void TestPoissonRegression()
         }
 
         [Fact]
-        //Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined
-        [Trait("Category", "SkipInCI")]
         public void TestGAMRegression()
         {
             TestFeatureContribution(ML.Regression.Trainers.Gam(), GetSparseDataset(numberOfInstances: 100), "GAMRegression");
diff --git a/test/Microsoft.ML.Tests/OnnxConversionTest.cs b/test/Microsoft.ML.Tests/OnnxConversionTest.cs
@@ -339,8 +339,6 @@ public void TestVectorWhiteningOnnxConversionTest()
         }
 
         [Fact]
-        //Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined
-        [Trait("Category", "SkipInCI")]
         public void PlattCalibratorOnnxConversionTest()
         {
             var mlContext = new MLContext(seed: 1);
diff --git a/test/Microsoft.ML.Tests/Properties/AssemblyInfo.cs b/test/Microsoft.ML.Tests/Properties/AssemblyInfo.cs
@@ -0,0 +1,9 @@
+﻿// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+using Xunit;
+
+// TODO: [TEST_STABILITY] disable test parallelization for this assembly as running test in parallel sometimes cause test host process to crash
+[assembly: CollectionBehavior(DisableTestParallelization = true)]
+
diff --git a/test/Microsoft.ML.Tests/Scenarios/Api/CookbookSamples/CookbookSamplesDynamicApi.cs b/test/Microsoft.ML.Tests/Scenarios/Api/CookbookSamples/CookbookSamplesDynamicApi.cs
@@ -365,8 +365,6 @@ public void GlobalFeatureImportance()
         }
 
         [Fact]
-        //Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined
-        [Trait("Category", "SkipInCI")]
         public void GetLinearModelWeights()
         {
             var dataPath = GetDataPath("housing.txt");
diff --git a/test/Microsoft.ML.Tests/TrainerEstimators/TrainerEstimators.cs b/test/Microsoft.ML.Tests/TrainerEstimators/TrainerEstimators.cs
@@ -87,8 +87,6 @@ public void KMeansEstimator()
         /// HogwildSGD TrainerEstimator test (logistic regression).
         /// </summary>
         [Fact]
-        //Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined
-        [Trait("Category", "SkipInCI")]
         public void TestEstimatorHogwildSGD()
         {
             var trainers = new[] { ML.BinaryClassification.Trainers.SgdCalibrated(l2Regularization: 0, numberOfIterations: 80),
diff --git a/test/Microsoft.ML.Tests/TrainerEstimators/TreeEstimators.cs b/test/Microsoft.ML.Tests/TrainerEstimators/TreeEstimators.cs
@@ -69,8 +69,6 @@ public void LightGBMBinaryEstimator()
         }
 
         [LightGBMFact]
-        //Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined
-        [Trait("Category", "SkipInCI")]
         public void LightGBMBinaryEstimatorUnbalanced()
         {
             var (pipe, dataView) = GetBinaryClassificationPipeline();
@@ -95,8 +93,6 @@ public void LightGBMBinaryEstimatorUnbalanced()
         /// LightGBMBinaryTrainer CorrectSigmoid test
         /// </summary>
         [LightGBMFact]
-        //Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined
-        [Trait("Category", "SkipInCI")]
         public void LightGBMBinaryEstimatorCorrectSigmoid()
         {
             var (pipe, dataView) = GetBinaryClassificationPipeline();
diff --git a/test/Microsoft.ML.Tests/Transformers/NormalizerTests.cs b/test/Microsoft.ML.Tests/Transformers/NormalizerTests.cs
@@ -751,8 +751,6 @@ public void GcnWorkout()
         }
 
         [Fact]
-        //Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined
-        [Trait("Category", "SkipInCI")]
         public void TestGcnNormCommandLine()
         {
             Assert.Equal(Maml.Main(new[] { @"showschema loader=Text{col=A:R4:0-10} xf=GcnTransform{col=B:A} in=f:\2.txt" }), (int)0);

Original file line number	Diff line number	Diff line change
`@@ -170,8 +170,6 @@ public void IrisVectorLightGbm()`
`170`	`170`	`}`
`171`	`171`
`172`	`172`	`[LightGBMFact]`
`173`		`- //Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined`
`174`		`- [Trait("Category", "SkipInCI")]`
`175`	`173`	`public void IrisVectorLightGbmWithLoadColumnName()`
`176`	`174`	`{`
`177`	`175`	`if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows))`
Original file line number	Diff line number	Diff line change
`@@ -91,8 +91,6 @@ public void TestPoissonRegression()`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`[Fact]`
`94`		`- //Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined`
`95`		`- [Trait("Category", "SkipInCI")]`
`96`	`94`	`public void TestGAMRegression()`
`97`	`95`	`{`
`98`	`96`	`TestFeatureContribution(ML.Regression.Trainers.Gam(), GetSparseDataset(numberOfInstances: 100), "GAMRegression");`
Original file line number	Diff line number	Diff line change
`@@ -339,8 +339,6 @@ public void TestVectorWhiteningOnnxConversionTest()`
`339`	`339`	`}`
`340`	`340`
`341`	`341`	`[Fact]`
`342`		`- //Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined`
`343`		`- [Trait("Category", "SkipInCI")]`
`344`	`342`	`public void PlattCalibratorOnnxConversionTest()`
`345`	`343`	`{`
`346`	`344`	`var mlContext = new MLContext(seed: 1);`
Original file line number	Diff line number	Diff line change
`@@ -365,8 +365,6 @@ public void GlobalFeatureImportance()`
`365`	`365`	`}`
`366`	`366`
`367`	`367`	`[Fact]`
`368`		`- //Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined`
`369`		`- [Trait("Category", "SkipInCI")]`
`370`	`368`	`public void GetLinearModelWeights()`
`371`	`369`	`{`
`372`	`370`	`var dataPath = GetDataPath("housing.txt");`
Original file line number	Diff line number	Diff line change
`@@ -87,8 +87,6 @@ public void KMeansEstimator()`
`87`	`87`	`/// HogwildSGD TrainerEstimator test (logistic regression).`
`88`	`88`	`/// </summary>`
`89`	`89`	`[Fact]`
`90`		`- //Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined`
`91`		`- [Trait("Category", "SkipInCI")]`
`92`	`90`	`public void TestEstimatorHogwildSGD()`
`93`	`91`	`{`
`94`	`92`	`var trainers = new[] { ML.BinaryClassification.Trainers.SgdCalibrated(l2Regularization: 0, numberOfIterations: 80),`
Original file line number	Diff line number	Diff line change
`@@ -69,8 +69,6 @@ public void LightGBMBinaryEstimator()`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`[LightGBMFact]`
`72`		`- //Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined`
`73`		`- [Trait("Category", "SkipInCI")]`
`74`	`72`	`public void LightGBMBinaryEstimatorUnbalanced()`
`75`	`73`	`{`
`76`	`74`	`var (pipe, dataView) = GetBinaryClassificationPipeline();`
`@@ -95,8 +93,6 @@ public void LightGBMBinaryEstimatorUnbalanced()`
`95`	`93`	`/// LightGBMBinaryTrainer CorrectSigmoid test`
`96`	`94`	`/// </summary>`
`97`	`95`	`[LightGBMFact]`
`98`		`- //Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined`
`99`		`- [Trait("Category", "SkipInCI")]`
`100`	`96`	`public void LightGBMBinaryEstimatorCorrectSigmoid()`
`101`	`97`	`{`
`102`	`98`	`var (pipe, dataView) = GetBinaryClassificationPipeline();`
Original file line number	Diff line number	Diff line change
`@@ -751,8 +751,6 @@ public void GcnWorkout()`
`751`	`751`	`}`
`752`	`752`
`753`	`753`	`[Fact]`
`754`		`- //Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined`
`755`		`- [Trait("Category", "SkipInCI")]`
`756`	`754`	`public void TestGcnNormCommandLine()`
`757`	`755`	`{`
`758`	`756`	`Assert.Equal(Maml.Main(new[] { @"showschema loader=Text{col=A:R4:0-10} xf=GcnTransform{col=B:A} in=f:\2.txt" }), (int)0);`