-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Documentation samples for binary classifiers #1257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'd like to work on this one, but wouldn't want to enter in a collision with someone. Is it possible to be assigned to this one? |
Thanks @bojanmisic. It doesn't look like we can assign it, but claiming it on the comments might be good enough. Tag me if you have questions. |
Maybe add a new label "assigned"? @shauheen, any comment? |
Well, once someone claims it, we can simply remove the |
@sfilipi, thanks! I believe the link to the cookbook examples has shifted, since the file has been changed recently. Would you like me to use static or dynamic API? |
Dynamic is fine; I was going to log another bug for the static examples, after arranging the structure of that project. |
@bojanmisic checking: are you still planning to work on this? |
@sfilipi, yes! I plan to work on that during the weekend. I have a strong will to contribute, just been crushed with work last two weeks. Sorry for the inconvenience, if you think someone can get it earlier, feel free to reassign. |
@bojanmisic just checking, before putting the Assigned label and removing the other labels. It is yours, take your time. Take a look at PR #136. I am adding a dateset for binary trainers there.Feel free to adopt if it doesn't get merged soon. |
Can I help on the documentation? |
@bojanmisic / @rekhakodali could you please help out with some documentation and samples? |
@shmoradims, I'll be glad to contribute. Feel free to add me to the table for 1 or more (you can add me to both above) trainers, and I'll start working on those asap. I don't have edit permissions for the issue. |
@shmoradims @bojanmisic I'll be glad to take a couple of those, as well, if it helps out. |
Closing, as most samples for binary classifiers are complete, and issue #2522 captures the broader work of trainer samples. |
Similar to the sample code for SDCA regression, we need samples for the binary classifiers:
SDCA
AveragedPerceptron
FastTree
LightGBM
There are two things to do, to resolve this issue:
Add a sample for each of the trainers in Microsoft.ML.Samples/Trainers.cs
The samples can look similar to the cookbook example
Download the adult dataset for the data to use.
Take a look at the SDCA example, for reference.
Add a link to the xml documentation of SDCA
AveragedPerceptron
FastTree
LightGBM
to reference the new sample methods, like the one in SDCA has.
The text was updated successfully, but these errors were encountered: