Skip to content

Suggestion related to Working with Columns #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ddobric opened this issue May 11, 2018 · 1 comment
Closed

Suggestion related to Working with Columns #127

ddobric opened this issue May 11, 2018 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ddobric
Copy link

ddobric commented May 11, 2018

Right now we use Column attribute to decorate how to read columns. Additionally we mark column with text "Label" to indicate that it is a label.

If label column is missing ore not correctly named we get: "InvalidOperationException: Column 'Label' not found"

Suggestion:
It might be better to use dedicated attributes like FeatureColumn and LabelColumn instead of freely written text. It is a statically typed and more .NET (C#) agnostic.

@sfilipi
Copy link
Member

sfilipi commented Dec 7, 2018

@ddobric your feedback is incorporated in the static api described in #474, #581 and the cookbook.

Closing this since the discussion of the same topic in the other Issues is brader.

@sfilipi sfilipi closed this as completed Dec 7, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants