Skip to content

Remove ISchematized interface #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Zruty0 opened this issue Nov 1, 2018 · 1 comment
Closed

Remove ISchematized interface #1502

Zruty0 opened this issue Nov 1, 2018 · 1 comment
Assignees
@wschin

Comments

@Zruty0
Copy link
Contributor

Zruty0 commented Nov 1, 2018

ISchematized interface is not consumed anywhere: we can safely remove it.

While we are at it, we could also rename IRowToRowMapper.Schema to OutputSchema to match InputSchema.
This was referenced Nov 5, 2018
Merged
Closed
@wschin wschin self-assigned this Nov 28, 2018
@wschin
Copy link
Member

wschin commented Nov 28, 2018 •
edited
Loading

I don't see a Schema in IRowToRowMapper after removing ISchematized. Can ISchematized be removed?

[Update] For whatever classes Schema provided by ISchematized is used, we add a new Schema to those classes.

@wschin wschin mentioned this issue Nov 28, 2018
Merged
@wschin wschin mentioned this issue Dec 14, 2018
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wschin wschin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wschin @Zruty0