Skip to content

CpuMath has a bad project reference to ML.Core #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eerhardt opened this issue Nov 20, 2018 · 3 comments
Closed

CpuMath has a bad project reference to ML.Core #1688

eerhardt opened this issue Nov 20, 2018 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@eerhardt
Copy link
Member

See #1659 (comment)

We recently made CpuMath depend on ML.Core, but this is broken.

The Microsoft.ML nuget package depends on the Microsoft.ML.CpuMath NuGet package. So having the CpuMath.dll depend on Microsoft.ML.Core is backwards.

See #542 for the reasoning why this was done that way.

@jwood803
Copy link
Contributor

@eerhardt I was looking at this while messing with an additional fix for #1566. Am I correct in thinking that Microsoft.ML.Core should have a NuGet package reference to Microsoft.Ml.CpuMath? Since it's in the same project does it need to reference the nupkgproj?

@shauheen shauheen added the bug Something isn't working label Nov 21, 2018
@shauheen shauheen added this to the 1118 milestone Nov 21, 2018
@Zruty0
Copy link
Contributor

Zruty0 commented Nov 21, 2018

I wonder why don't we simply make it one NuGet?

@eerhardt
Copy link
Member Author

#534 Explains why we didn’t make it one NuGet package

@ghost ghost locked as resolved and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants