-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Name of MakePredictionFunction is confusing (to me). #1761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I agree, I provided that feedback some time ago. It is confusing for a C# or object oriented developer. That's why in some samples we were naming the variable/object as predictionEngine instead of predictionFunction. I think it is called that way because in generic machine learning might be the term, but this is good feedback to have. 👍 @TomFinley - Thoughts? |
I agree that "function" is an overloaded term that will confuse .NET developers. I might actually prefer to "solve" this problem by deleting @Zruty0 appeared to introduce this class IIRC (though it's tough to be sure after 2.5 months), I think he and I both believed this new thing ( In #973 I changed it so that both used |
Two notes:
|
Hi @markusweimer ,
We would want There is one other problem which we haven't quite tackled yet, but we should probably do pretty soon, and that is that
Yes, |
Actually, as heretical as it may sound, maybe we could now call it a 'predictor'? |
Maybe. |
I was following the start example in the Readme, and when I came to the line with MakePredictionFunction, I got a bit confused and had to go over it a few times before I could continue:
I expected the return value of
MakePredictionFunction()
to a function-type thing, but instead it was an object. This was hard for me not because of pedantic correctness, but rather from a usability standpoint as a beginner trying to keep my concepts straight (estimators, transformers, models, etc.) this took me a step back and I had to go over the section several times to make sure I hadn't missed something.Is there a better name that would be less confusing?
MakePredictionObject()
MakePredictionEngine()
MakePredictor()
The text was updated successfully, but these errors were encountered: