-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Follow up on Calibrator estimators #1871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There are 2 cases of calibrators: one where we set the parameters (slope, offset) manually, and one where we learn them. Both cases will need an estimator: first one will just be a regular trainer, and the second will be a trivial estimator. I world prefer these 2 cases to be invoked via 2 different methods, instead of a single overload. |
It seems to me that these when fit, given that they're parameterized with model parameters, should be producing a model with I am at least confident we should not have two mechanisms for doing this. Right now we have two, and I'm not sure why:
|
Hi @Ivanidzo4ka , you are omitting 2 I think. The estimator for calibration is still not accessible through machinelearning/src/Microsoft.ML.Data/Prediction/CalibratorCatalog.cs Lines 279 to 282 in eb60021
There is still not |
Ok, let's at least add it to Project 13, otherwise it has chance to be missed. |
There are a few follow ups to the work to create calibrator estimators:
1- The public classes in Microsoft.ML.Core/Prediction/Calibrator.cs need to have descriptive XML documentation.
2- The Calibrators need to be added as property to the BinaryClassificationContext
3- Some of the Calibrators have a public constructor, that allows initializing the parameters. Does it make sense to expose and wire those parameters to the CalibratorEstimators, and set them from there?
So they will all look like FixedPalttCalibratorEstimator
cc @Zruty0
The text was updated successfully, but these errors were encountered: