Skip to content

Microsoft.ML.Internal.Internallearn namespace requires certain internalization #2590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Ivanidzo4ka opened this issue Feb 16, 2019 · 0 comments · Fixed by #2667
Closed

Microsoft.ML.Internal.Internallearn namespace requires certain internalization #2590

Ivanidzo4ka opened this issue Feb 16, 2019 · 0 comments · Fixed by #2667
Assignees
@codemzs
Labels
API Issues pertaining the friendly API
Milestone
0219

Comments

@Ivanidzo4ka
Copy link
Contributor

At least
public sealed class SlotDropper should become internal.
public static class PredictionUtil should become internal
public static class TypeUtils
also all public delegates in this namespace can be made internal.
@Ivanidzo4ka Ivanidzo4ka added the API Issues pertaining the friendly API label Feb 16, 2019
@codemzs codemzs self-assigned this Feb 20, 2019
@codemzs codemzs mentioned this issue Feb 20, 2019
Merged
@shauheen shauheen added this to the 0219 milestone Feb 21, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@codemzs codemzs

Labels
API Issues pertaining the friendly API
Projects
None yet
Milestone
0219
3 participants
@codemzs @Ivanidzo4ka @shauheen