Skip to content

Enhance CustomMapping documentation #2657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eerhardt opened this issue Feb 20, 2019 · 2 comments
Closed

Enhance CustomMapping documentation #2657

eerhardt opened this issue Feb 20, 2019 · 2 comments
Labels
documentation Related to documentation of ML.NET P1 Priority of the issue for triage purpose: Needs to be fixed soon.

Comments

@eerhardt
Copy link
Member

See discussion #2569 (comment)

this is definitely something we'll want to document very carefully. It is a bit odd, this pattern of mutable input as a return value. (I of course know exactly why we do it, but a user will not.)

We should ensure we explain (in the cookbook, docs.microsoft.com, or otherwise) how this pattern works, and give the reasons why we do it like this.

/cc @TomFinley

@eerhardt eerhardt added the documentation Related to documentation of ML.NET label Feb 20, 2019
@eerhardt
Copy link
Member Author

Also, we should add some <see tags to and from CustomMappingEstimator.

See #2569 (comment) for the suggestion.

@shmoradims shmoradims added the P1 Priority of the issue for triage purpose: Needs to be fixed soon. label May 21, 2019
@artidoro
Copy link
Contributor

artidoro commented Jul 3, 2019

We added samples for the custom mapping estimator and improved the documentation.
If you feel that this should be improved further please reopen the issue and specify what we should add.

@artidoro artidoro closed this as completed Jul 3, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Related to documentation of ML.NET P1 Priority of the issue for triage purpose: Needs to be fixed soon.
Projects
None yet
Development

No branches or pull requests

3 participants