Skip to content

Add code analyzer support for CustomMapping #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eerhardt opened this issue Feb 20, 2019 · 0 comments
Open

Add code analyzer support for CustomMapping #2670

eerhardt opened this issue Feb 20, 2019 · 0 comments
Labels
enhancement New feature or request P2 Priority of the issue for triage purpose: Needs to be fixed at some point.

Comments

@eerhardt
Copy link
Member

See the conversation here:

#2569 (comment)

It is very easy to incorrectly write a custom mapping transformer. We should consider adding a code analyzer that ensures users do it correctly.

On the same lines, since we explicitly don't check any of our Microsoft.ML assemblies for custom mapping transformers, we should write an internal code analyzer that ensures we don't try to do that in our product.

@mstfbl mstfbl assigned mstfbl and unassigned mstfbl Jan 9, 2020
@mstfbl mstfbl added enhancement New feature or request P1 Priority of the issue for triage purpose: Needs to be fixed soon. labels Jan 9, 2020
@frank-dong-ms-zz frank-dong-ms-zz self-assigned this Jun 11, 2020
@frank-dong-ms-zz frank-dong-ms-zz added P2 Priority of the issue for triage purpose: Needs to be fixed at some point. and removed P1 Priority of the issue for triage purpose: Needs to be fixed soon. labels Jun 12, 2020
@frank-dong-ms-zz frank-dong-ms-zz removed their assignment Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Priority of the issue for triage purpose: Needs to be fixed at some point.
Projects
None yet
Development

No branches or pull requests

3 participants