Skip to content

Should the Microsoft.ML.*.StaticPipe namespaces fold into the Microsoft.ML.StaticPipe? #2746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sfilipi opened this issue Feb 26, 2019 · 2 comments
Labels
API Issues pertaining the friendly API P2 Priority of the issue for triage purpose: Needs to be fixed at some point.

Comments

@sfilipi
Copy link
Member

sfilipi commented Feb 26, 2019

As we are aligning the namespaces of the trainers and transforms main package, Microsoft.ML; and moving them from subcategories to the main root, we should probably do the same for the StaticPipe assembly and namespaces.

So potentially move things like:
Microsoft.ML.StaticPipe.Runtime
Microsoft.ML.HalLearners.StaticPipe
Microsoft.ML.Transforms.StaticPipe
Microsoft.ML.LightGBM.StaticPipe

to
Microsoft.ML.StaticPipe

@TomFinley TomFinley added the API Issues pertaining the friendly API label Feb 27, 2019
@TomFinley
Copy link
Contributor

Well, given that they're based on extension methods, I'd say so for everytthing but Runtime.

Runtime though deals with structures for writing the static extensions. I might prefer to keep them in a separate nuget so they're not in people's faces.

However (and i know you know this as you've already put it in backlog) this deals with experimental code so it is not essential for v1 release.

@ganik ganik added the P2 Priority of the issue for triage purpose: Needs to be fixed at some point. label May 23, 2019
@wschin
Copy link
Member

wschin commented Jul 2, 2019

Static APIs will be deprecated soon, so I think this issue can be closed.

@wschin wschin closed this as completed Jul 2, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Issues pertaining the friendly API P2 Priority of the issue for triage purpose: Needs to be fixed at some point.
Projects
None yet
Development

No branches or pull requests

4 participants