Skip to content

Scrubbing time series related transformers #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ivanidzo4ka opened this issue Mar 4, 2019 · 6 comments
Closed

Scrubbing time series related transformers #2834

Ivanidzo4ka opened this issue Mar 4, 2019 · 6 comments
Labels
API Issues pertaining the friendly API

Comments

@Ivanidzo4ka
Copy link
Contributor

Ivanidzo4ka commented Mar 4, 2019

Sub task of #2827
IidChangePointEstimator
IidSpikeEstimator
SsaChangePointEstimator
SsaSpikeEstimator

@Ivanidzo4ka Ivanidzo4ka added the API Issues pertaining the friendly API label Mar 4, 2019
@eerhardt
Copy link
Member

eerhardt commented Mar 4, 2019

Time Series isn't a "stable" API for v1.0 according to #2279 (comment). Which means this shouldn't be in "Project 13".

@codemzs
Copy link
Member

codemzs commented Mar 4, 2019

@eerhardt What is the definition of stable API?

@eerhardt
Copy link
Member

eerhardt commented Mar 4, 2019

That issue is calling out: "Which packages ship as version 1.0.0 when Microsoft.ML ships 1.0.0"?

Since TimeSeries isn't in that list, it won't be shipping 1.0.0 when the rest of the stable packages are shipped.

In general, the definition of a stable API is one that won't accept API breaking changes going forward.

@Ivanidzo4ka
Copy link
Contributor Author

Can we at least change names of extension methods to something more bearable than

public static IidChangePointEstimator IidChangePointEstimator(this TransformsCatalog catalog, string outputColumnName, string inputColumnName,

@eerhardt
Copy link
Member

eerhardt commented Mar 4, 2019

Can we at least change names of extension methods to something more bearable than

(Totally my opinion): Yes, we can do that. AFTER all the other APIs that are stable for v1.0.0 are bearable for long-term consumption.

@wschin
Copy link
Member

wschin commented Jul 2, 2019

We decided to release time series package as it (in terms of the class names), so this issue can be closed.

@wschin wschin closed this as completed Jul 2, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Issues pertaining the friendly API
Projects
None yet
Development

No branches or pull requests

4 participants