Skip to content

UseStopRemover parameter in TextFeaturizer does not make sense. #2838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zeahmed opened this issue Mar 4, 2019 · 0 comments · Fixed by #2911
Closed

UseStopRemover parameter in TextFeaturizer does not make sense. #2838

zeahmed opened this issue Mar 4, 2019 · 0 comments · Fixed by #2911
Assignees
@zeahmed
Labels
API Issues pertaining the friendly API bug Something isn't working
Milestone
0319

Comments

@zeahmed
Copy link
Contributor

zeahmed commented Mar 4, 2019 •
edited
Loading

machinelearning/src/Microsoft.ML.Transforms/Text/TextFeaturizingEstimator.cs

Line 157 in 5746ec9

public bool UseStopRemover { get; set; } = false;

I think it should be renamed to UseStopWordRemover? Xml comments need to be updated to too.
@zeahmed zeahmed added API Issues pertaining the friendly API bug Something isn't working labels Mar 4, 2019
@zeahmed zeahmed self-assigned this Mar 5, 2019
@shauheen shauheen added this to the 0319 milestone Mar 5, 2019
@zeahmed zeahmed mentioned this issue Mar 11, 2019
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zeahmed zeahmed

Labels
API Issues pertaining the friendly API bug Something isn't working
Projects
None yet
Milestone
0319
Development

Successfully merging a pull request may close this issue.

Exposed ngram extraction options in TextFeaturizer zeahmed/machinelearning
2 participants
@shauheen @zeahmed