You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #2827, one of the items is to make sure the estimators and their catalog extensions have matching names. Like in trainers, we should keep the suffix estimator only in the estimator name, and remove it from the catalog extension, something like the following:
NameEstimator Name(...)
The question now is: How do we reconcile the names and which convention should we follow?
Most estimator names follow the convention: ActionPerformingEstimator, while in the catalog usually we use the convetion: PerformAction.
In #2827, one of the items is to make sure the estimators and their catalog extensions have matching names. Like in trainers, we should keep the suffix estimator only in the estimator name, and remove it from the catalog extension, something like the following:
NameEstimator Name(...)
The question now is: How do we reconcile the names and which convention should we follow?
Most estimator names follow the convention:
ActionPerformingEstimator
, while in the catalog usually we use the convetion:PerformAction
.Some examples are:
KeyToBinaryVectorMappingEstimator
MapKeyToBinaryVector
MutualInformationFeatureSelectingEstimator
SelectFeaturesBasedOnMutualInformation
CountFeatureSelectingEstimator
SelectFeaturesBasedOnCount
cc/ @sfilipi @TomFinley @glebuk @eerhardt @rogancarr @ivanbasov
The text was updated successfully, but these errors were encountered: