Skip to content

Perf: Optimization for FactorizationMachine #3000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
glebuk opened this issue Mar 18, 2019 · 1 comment
Closed

Perf: Optimization for FactorizationMachine #3000

glebuk opened this issue Mar 18, 2019 · 1 comment
Labels
enhancement New feature or request P2 Priority of the issue for triage purpose: Needs to be fixed at some point. perf Performance and Benchmarking related

Comments

@glebuk
Copy link
Contributor

glebuk commented Mar 18, 2019 •
edited
Loading

Benchmarking using VTune has found several bottlenecks in Factrization Machine training algorithm.

  • Some phases training that are not parallelized. Consider adding parallel computation.
  • Evaluate using AVX/AVX2 (C++ or C# instrinsics) in factorizationmachinenative.dll which currently implements C++ SSE code
  • Consider optimizing the following hotspot
Function Module CPU Time
Microsoft::ML::Internal::Utilities::DoubleParser::TryParseCore Microsoft.ML.Core.dll 27.390s
CalculateGradientAndUpdateNative factorizationmachinenative.dll 22.609s
HelperImpl::FetchNextField Microsoft.ML.Data.dll 13.826s
CalculateIntermediateVariablesNative factorizationmachinenative.dll 12.201s
Microsoft::ML::Internal::Utilities::DoubleParser::TryParse Microsoft.ML.Core.dll 9.666s
@glebuk glebuk added enhancement New feature or request perf Performance and Benchmarking related labels Mar 18, 2019
@glebuk glebuk changed the title Perf: Intel ptimization for FactorizationMachine Perf: Optimization for FactorizationMachine Mar 18, 2019
@pkumar07 pkumar07 mentioned this issue May 29, 2019
Closed
@pkumar07 pkumar07 mentioned this issue Jul 1, 2019
Merged
@yaeldekel yaeldekel added the P2 Priority of the issue for triage purpose: Needs to be fixed at some point. label Jan 10, 2020
@frank-dong-ms-zz
Copy link
Contributor

Done in below PR, close the issue now:
#3940

@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request P2 Priority of the issue for triage purpose: Needs to be fixed at some point. perf Performance and Benchmarking related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yaeldekel @glebuk @frank-dong-ms-zz