Skip to content

Rename ImageType to ImageDataViewType #3050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eerhardt opened this issue Mar 21, 2019 · 1 comment
Closed

Rename ImageType to ImageDataViewType #3050

eerhardt opened this issue Mar 21, 2019 · 1 comment
Assignees
@abgoswam
Labels
API Issues pertaining the friendly API
Milestone
0319

Comments

@eerhardt
Copy link
Member

With #2297 we decided to suffix all the IDataView type classes with DataViewType instead of just Type. However, we missed ImageType:

machinelearning/src/Microsoft.ML.ImageAnalytics/ImageType.cs

Line 12 in 70ef7ec

public sealed class ImageType : StructuredDataViewType

We should rename this class as well to match the rest in the hierarchy. This will need to be done before v1.0 since it would be a breaking change to rename it later.
@eerhardt eerhardt added the API Issues pertaining the friendly API label Mar 21, 2019
@eerhardt eerhardt mentioned this issue Mar 21, 2019
Merged
@eerhardt
Copy link
Member Author

cc @Ivanidzo4ka @TomFinley @shauheen

@shauheen shauheen added this to the 0319 milestone Mar 21, 2019
@abgoswam abgoswam mentioned this issue Mar 21, 2019
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abgoswam abgoswam

Labels
API Issues pertaining the friendly API
Projects
None yet
Milestone
0319
Development

No branches or pull requests
3 participants
@shauheen @eerhardt @abgoswam