-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Cannot access leaf nodes of trained trees #3083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@wschin @abgoswam @TomFinley is this is good candidate for the Experimental nuget? cc @shauheen |
I suppose, for the short term. In the more medium term, it looks like this code is duplicating much of the same logic that exists in tree featurization, specifically, getting the leaf values for an example. Once we make tree featurziation part of the public API, then perhaps we could use that instead. (This would also probably simplify SMAC. I think SMAC's writing by @george-microsoft predates @yaeldekel's introduction of the tree featurizer, so presumably that was not an option at the time.) Presumably we want tree featurization exposed in our public API at some point. It was a useful embedding. But, currently it appears to adhere to the old |
We have reintroduced the tree featurizer and we have an API to access the trained tree ensemble parameters (leaves and other things). See:
I am closing this issue, but feel free to reopen it in case we are still missing some functionality. |
In this review #2753, I notice the methods to traverse thru trained tree ensembles have been removed from the public API
@wschin @TomFinley
I understand the logic for removing.
However, in our forked copy of SMAC, we require / have been using this functionality. Any advice on how to proceed?
The text was updated successfully, but these errors were encountered: