Skip to content

Can't pass TransformerChain to AnomalyDetection.ChangeModelThreshold #4077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
colbylwilliams opened this issue Aug 7, 2019 · 2 comments
Open

Can't pass TransformerChain to AnomalyDetection.ChangeModelThreshold #4077

colbylwilliams opened this issue Aug 7, 2019 · 2 comments
Labels
enhancement New feature or request P2 Priority of the issue for triage purpose: Needs to be fixed at some point.

Comments

@colbylwilliams
Copy link
Member

ML.NET v1.3.1

AnomalyDetectionCatalog.ChangeModelThreshold was added to fix issue 3990. However, I believe it should also support passing in an ITransformerChain where the LastTransformer is a AnomalyPredictionTransformer in addition to a single AnomalyPredictionTransformer.

Because ChangeModelThreshold must be called after Fit, in most real-world scenarios users will likely have a TransformerChain instead of a single ITransformer. But as ChangeModelThreshold is currently implemented, it can't be used in this context.
@colbylwilliams
Copy link
Member Author

cc: @artidoro @bamurtaugh @CESARDELATORRE

@antoniovs1029 antoniovs1029 added enhancement New feature or request P2 Priority of the issue for triage purpose: Needs to be fixed at some point. labels Jan 10, 2020
@spoilerdo
Copy link

any updates to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request P2 Priority of the issue for triage purpose: Needs to be fixed at some point.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@colbylwilliams @spoilerdo @antoniovs1029