We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The two methods in DnnCatalog:
DnnCatalog
machinelearning/src/Microsoft.ML.Dnn/DnnCatalog.cs
Lines 49 to 63 in c9f616f
and
Lines 120 to 143 in c9f616f
have a lot of optional parameters, and users may get confused on which ones are important, and which aren't.
I've seen comments from @terrajobst in the past saying:
In UX studies we have seen that many developers struggle with methods that have many optional arguments.
In ML.NET, the pattern we have established is that we have 2 overloads:
Options
We should follow this pattern with these DNN APIs as well. See the discussions and related PRs to #1798.
/cc @ebarsoumMS @codemzs
The text was updated successfully, but these errors were encountered:
@eerhardt We are aware and already tracking this issue and it will be implemented before we go GA.
Sorry, something went wrong.
I will be looking into this.
Thanks @ashbhandare
Successfully merging a pull request may close this issue.
The two methods in
DnnCatalog
:machinelearning/src/Microsoft.ML.Dnn/DnnCatalog.cs
Lines 49 to 63 in c9f616f
and
machinelearning/src/Microsoft.ML.Dnn/DnnCatalog.cs
Lines 120 to 143 in c9f616f
have a lot of optional parameters, and users may get confused on which ones are important, and which aren't.
I've seen comments from @terrajobst in the past saying:
In ML.NET, the pattern we have established is that we have 2 overloads:
Options
object, which contains all the options to the method - simple and advanced.We should follow this pattern with these DNN APIs as well. See the discussions and related PRs to #1798.
/cc @ebarsoumMS @codemzs
The text was updated successfully, but these errors were encountered: