Skip to content

AppendCacheCheckpoint is ignored at the beginning of the pipeline #4909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yaeldekel opened this issue Mar 3, 2020 · 2 comments
Closed

AppendCacheCheckpoint is ignored at the beginning of the pipeline #4909

yaeldekel opened this issue Mar 3, 2020 · 2 comments
Assignees
Labels
bug Something isn't working P2 Priority of the issue for triage purpose: Needs to be fixed at some point.

Comments

@yaeldekel
Copy link

When an empty EstimatorChain is created, and AppendCacheCheckpoint is called before adding any estimators, then no caching occurs.
The expected behavior should be to either cache the data before fitting the first estimator in the chain, or disallow calling AppendCacheCheckpoint on empty chains, so that the user knows to cache the data explicitly before fitting. (I think the first solution is preferable, but open to other opinions).

@mstfbl mstfbl added bug Something isn't working P2 Priority of the issue for triage purpose: Needs to be fixed at some point. labels Mar 3, 2020
@artemiusgreat
Copy link

And this is the code to reproduce the issue :)
#4926 (comment)

@frank-dong-ms-zz frank-dong-ms-zz self-assigned this Jul 1, 2020
@frank-dong-ms-zz
Copy link
Contributor

This issue is different issue with issue #4926, issue #4926 is converting from EstimatorChain to IEstimator and lose information like need cache. This issue is when try to call AppendCacheCheckpoint after an empty EstimatorChain and no cache will happen.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working P2 Priority of the issue for triage purpose: Needs to be fixed at some point.
Projects
None yet
Development

No branches or pull requests

4 participants