Skip to content

Binary learners need to have IComponentFactory implementation in order to work with OVA. #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ivanidzo4ka opened this issue Aug 8, 2018 · 0 comments
Assignees
Milestone

Comments

@Ivanidzo4ka
Copy link
Contributor

With #622 OVA expects predictor type to be IComponentFactory, and in current moment only learner which exposed itself as component is FastTree, and it exposes itself only as ITrainer instead of ITrainer<IPredictorProducing> required for OVA.

Which mean we have to go through all our Binary learners and expose them as ComponentKind and create proper factories. Same probably states for Regression, MultiClass, and Ranking.

@Ivanidzo4ka Ivanidzo4ka self-assigned this Aug 8, 2018
@shauheen shauheen added the bug Something isn't working label Aug 9, 2018
@shauheen shauheen added this to the 0818 milestone Aug 9, 2018
@Ivanidzo4ka Ivanidzo4ka added Answered and removed bug Something isn't working labels Aug 9, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants