You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've found 2 indirect references in our product that I'm not sure how to proceed on.
LearnerFeatureSelectionTransform depends on SDCA, but ML.Transforms doesn't have a reference to ML.StandardLearners.
The 'train' commands in ML.Data (CV, Train, TrainTest) all have a default Trainer of AveragedPerceptron. but AveragedPerceptron lives in the ML.StandardLearners assembly. And ML.StandardLearners references ML.Data, but this dependency is in the wrong order.
A couple of options:
Change these parameters to be 'user required', i.e. they don't have a default and fail if you didn't specify it.
Move some code around so the dependencies line up correctly. For example, we could move our 'train' commands out of ML.Data and into a higher assembly.
For (1) above, we could move LearnerFeatureSelectionTransform into ML.StandardLearners instead of being in ML.Transforms. Or we could add the dependency from ML.Transforms to ML.StandardLearners.
Continue to use Dependency Injection and just assume/hope the component is there at runtime.
From an internal conversation with @TomFinley, we are thinking of taking option (1) above - make these parameters required and not have a default.
I've found 2 indirect references in our product that I'm not sure how to proceed on.
LearnerFeatureSelectionTransform
depends onSDCA
, butML.Transforms
doesn't have a reference toML.StandardLearners
.ML.Data
(CV
,Train
,TrainTest
) all have a default Trainer ofAveragedPerceptron
. butAveragedPerceptron
lives in theML.StandardLearners
assembly. AndML.StandardLearners
referencesML.Data
, but this dependency is in the wrong order.A couple of options:
ML.Data
and into a higher assembly.LearnerFeatureSelectionTransform
intoML.StandardLearners
instead of being inML.Transforms
. Or we could add the dependency fromML.Transforms
to ML.StandardLearners.From an internal conversation with @TomFinley, we are thinking of taking option (1) above - make these parameters required and not have a default.
Thoughts?
cc @TomFinley @Zruty0 @codemzs @Ivanidzo4ka
The text was updated successfully, but these errors were encountered: