Skip to content

Address additional comments on the TensorFlowTransform PR #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abgoswam opened this issue Aug 30, 2018 · 2 comments
Closed

Address additional comments on the TensorFlowTransform PR #779

abgoswam opened this issue Aug 30, 2018 · 2 comments
Assignees
Milestone

Comments

@abgoswam
Copy link
Member

abgoswam commented Aug 30, 2018

Post merge, there are some additional comments that were added to the TensorFlowTransform PR #704 .
Also, during the bug bash there was a request to update the documentation in a few places.

Creating an issue to address these asks.

Listing down the issues being addressed:

  1. Check for number of rows in unit test TensorFlowTransformCifar . comment

  2. Fix TensorFlowTransformCifarLearningPipelineTest test. comment

  3. Update the TensorFlowTransform documentation to include a pointer to the nugets required for running the TensorFlowTransform.

@TomFinley
Copy link
Contributor

There are some additional comments that need to be addressed

Hi @abgoswam . Could we possibly expand on these? It is difficult to review your PR without knowing what the intent of it is.

More generally, it is generally a good idea for issues to be descriptive.

@abgoswam
Copy link
Member Author

Hi @TomFinley . I have updated the description

@shauheen shauheen added this to the 0918 milestone Aug 31, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants