Skip to content

TestEstimatorCore fails when training on EmptyDataView for the listed transforms. #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zeahmed opened this issue Sep 20, 2018 · 0 comments · Fixed by #4696
Closed

TestEstimatorCore fails when training on EmptyDataView for the listed transforms. #969

zeahmed opened this issue Sep 20, 2018 · 0 comments · Fixed by #4696
Labels
P1 Priority of the issue for triage purpose: Needs to be fixed soon.

Comments

@zeahmed
Copy link
Contributor

zeahmed commented Sep 20, 2018

TestEstimatorCore method tests the schema of estimator that of transformer. It trains estimator on EmptyDataView and get the schema. Then, it fits the estimator on actual data, and get the schema from transformer.

Ngram

It then verifies of both schema are same. However for the case of ngram transform, schema learnt from EmptyDataView is different from actually learned from data. The actual cause is size of ngram is zero in case of training on EmptyDataView which causes output vector type to be variable length. Additionally, some other meta are not filled properly in this case.

PCA Transform

Can not applied on EmptyDataView. Exception is thrown regrading empty data view.

Because of this following tests are failing right now.

WordBagWorkout
NgramWorkout
PcaWorkout

Need to think how to fix it.

@zeahmed zeahmed changed the title TestEstimatorCore fails when training on EmptyDataView for Ngram based transforms. TestEstimatorCore fails when training on EmptyDataView for the listed transforms. Sep 25, 2018
@codemzs codemzs closed this as completed Jun 30, 2019
@yaeldekel yaeldekel reopened this Jan 23, 2020
@Lynx1820 Lynx1820 added the P1 Priority of the issue for triage purpose: Needs to be fixed soon. label Jan 28, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1 Priority of the issue for triage purpose: Needs to be fixed soon.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants