diff --git a/test/Directory.Build.props b/test/Directory.Build.props index d5a86e7fbd..ee5d507566 100644 --- a/test/Directory.Build.props +++ b/test/Directory.Build.props @@ -1,6 +1,19 @@ + + true + + + $(NoWarn),1573,1591,1712 + + trx $(OutputPath) diff --git a/test/Microsoft.ML.TestFramework/CopyAction.cs b/test/Microsoft.ML.TestFramework/CopyAction.cs index 4ea65bbbd5..b7ec2327db 100644 --- a/test/Microsoft.ML.TestFramework/CopyAction.cs +++ b/test/Microsoft.ML.TestFramework/CopyAction.cs @@ -38,7 +38,7 @@ private static void CopyAll(string sourcePath, string destinationPath) /// /// Since test folder doesn't have libraries from AutoLoad folder and Win libraries, /// we copy them for each test (only newest one). - // This allow execute tests locally. + /// This allow execute tests locally. /// public static void Execute() { diff --git a/test/Microsoft.ML.TestFramework/TestCategory.cs b/test/Microsoft.ML.TestFramework/TestCategory.cs index 30811f5b72..69913b3fc9 100644 --- a/test/Microsoft.ML.TestFramework/TestCategory.cs +++ b/test/Microsoft.ML.TestFramework/TestCategory.cs @@ -8,19 +8,18 @@ using Xunit.Abstractions; using Xunit.Sdk; -/// -/// This is a replacement for the MSTest [TestCategoryAttribute] on xunit -/// xunit does not have the concept of Category for tests and instead, the have [TraitAttribute(string key, string value)] -/// If we replace the MSTest [TestCategoryAttribute] for the [Trait("Category", "BVT")], we will surely fall at some time in cases -/// where people will typo on the "Category" key part of the Trait. -/// On order to achieve the same behaviour as on MSTest, a custom [TestCategory] was created -/// to mimic the MSTest one and avoid replace it on every existent test. -/// The tests can be filtered by xunit runners by usage of "-trait" on the command line with the expresion like -/// -trait "Category=BVT" for example that will only run the tests with [TestCategory("BVT")] on it. -/// - namespace Xunit { + /// + /// This is a replacement for the MSTest [TestCategoryAttribute] on xunit + /// xunit does not have the concept of Category for tests and instead, the have [TraitAttribute(string key, string value)] + /// If we replace the MSTest [TestCategoryAttribute] for the [Trait("Category", "BVT")], we will surely fall at some time in cases + /// where people will typo on the "Category" key part of the Trait. + /// On order to achieve the same behaviour as on MSTest, a custom [TestCategory] was created + /// to mimic the MSTest one and avoid replace it on every existent test. + /// The tests can be filtered by xunit runners by usage of "-trait" on the command line with the expresion like + /// -trait "Category=BVT" for example that will only run the tests with [TestCategory("BVT")] on it. + /// [TraitDiscoverer("CategoryDiscoverer", "TestExtensions")] [AttributeUsage(AttributeTargets.Class | AttributeTargets.Method, AllowMultiple = true)] public class TestCategoryAttribute : Attribute, ITraitAttribute diff --git a/test/Microsoft.ML.TestFramework/TestCommandBase.cs b/test/Microsoft.ML.TestFramework/TestCommandBase.cs index d634a250e2..4039a22476 100644 --- a/test/Microsoft.ML.TestFramework/TestCommandBase.cs +++ b/test/Microsoft.ML.TestFramework/TestCommandBase.cs @@ -7,6 +7,7 @@ using System.IO; using System.Linq; using Microsoft.ML.Runtime; +using Microsoft.ML.Runtime.Command; using Microsoft.ML.Runtime.Data; using Microsoft.ML.Runtime.EntryPoints; using Microsoft.ML.Runtime.Internal.Utilities; @@ -308,7 +309,7 @@ protected bool TestCore(RunContextBase ctx, string cmdName, string args, params /// /// The environment to use. /// - /// The writer to print the . Usually this should be the same writer that is used in . + /// The writer to print the . Usually this should be the same writer that is used in . /// /// The arguments for MAML. /// Whether to print the progress summary. If true, progress summary will appear in the end of baseline output file. @@ -591,7 +592,7 @@ protected OutputPath FoldModelPath(int fold) /// /// Creates an output path with a suffix based on the test name. For new tests please - /// do not use this, but instead utilize the + /// do not use this, but instead utilize the /// method. /// protected OutputPath CreateOutputPath(string suffix)