From 1f0b2a1f3540dfa8327057ed2ca104632b2c21cf Mon Sep 17 00:00:00 2001 From: Daniel Weber Date: Wed, 4 Jul 2018 09:53:44 +0200 Subject: [PATCH] Private setter for auto properties that are only assigned in the constructor can be omitted. --- .../src/System.Reactive/Joins/JoinObserver.cs | 2 +- .../src/System.Reactive/Joins/Pattern.cs | 274 +++++++++--------- .../Source/src/System.Reactive/Joins/Plan.cs | 66 ++--- .../System.Reactive/Joins/QueryablePattern.cs | 2 +- .../System.Reactive/Joins/QueryablePlan.cs | 4 +- 5 files changed, 174 insertions(+), 174 deletions(-) diff --git a/Rx.NET/Source/src/System.Reactive/Joins/JoinObserver.cs b/Rx.NET/Source/src/System.Reactive/Joins/JoinObserver.cs index aca5aaf18a..cc81ffcf3f 100644 --- a/Rx.NET/Source/src/System.Reactive/Joins/JoinObserver.cs +++ b/Rx.NET/Source/src/System.Reactive/Joins/JoinObserver.cs @@ -20,7 +20,7 @@ internal sealed class JoinObserver : ObserverBase>, IJoinObse private readonly IObservable _source; private readonly Action _onError; private readonly List _activePlans; - public Queue> Queue { get; private set; } + public Queue> Queue { get; } private IDisposable _subscription; private bool _isDisposed; diff --git a/Rx.NET/Source/src/System.Reactive/Joins/Pattern.cs b/Rx.NET/Source/src/System.Reactive/Joins/Pattern.cs index 4b42796371..bdc1435350 100644 --- a/Rx.NET/Source/src/System.Reactive/Joins/Pattern.cs +++ b/Rx.NET/Source/src/System.Reactive/Joins/Pattern.cs @@ -29,7 +29,7 @@ internal Pattern(IObservable first) First = first; } - internal IObservable First { get; private set; } + internal IObservable First { get; } /// /// Matches when all observable sequences have an available element and projects the elements by invoking the selector function. @@ -63,8 +63,8 @@ internal Pattern(IObservable first, IObservable second) Second = second; } - internal IObservable First { get; private set; } - internal IObservable Second { get; private set; } + internal IObservable First { get; } + internal IObservable Second { get; } /// /// Creates a pattern that matches when all three observable sequences have an available element. @@ -117,9 +117,9 @@ internal Pattern(IObservable first, IObservable second, IObs Third = third; } - internal IObservable First { get; private set; } - internal IObservable Second { get; private set; } - internal IObservable Third { get; private set; } + internal IObservable First { get; } + internal IObservable Second { get; } + internal IObservable Third { get; } /// /// Creates a pattern that matches when all four observable sequences have an available element. @@ -174,10 +174,10 @@ internal Pattern(IObservable first, IObservable second, IObs Fourth = fourth; } - internal IObservable First { get; private set; } - internal IObservable Second { get; private set; } - internal IObservable Third { get; private set; } - internal IObservable Fourth { get; private set; } + internal IObservable First { get; } + internal IObservable Second { get; } + internal IObservable Third { get; } + internal IObservable Fourth { get; } /// /// Creates a pattern that matches when all five observable sequences have an available element. @@ -234,11 +234,11 @@ internal Pattern(IObservable first, IObservable second, IObs Fifth = fifth; } - internal IObservable First { get; private set; } - internal IObservable Second { get; private set; } - internal IObservable Third { get; private set; } - internal IObservable Fourth { get; private set; } - internal IObservable Fifth { get; private set; } + internal IObservable First { get; } + internal IObservable Second { get; } + internal IObservable Third { get; } + internal IObservable Fourth { get; } + internal IObservable Fifth { get; } /// /// Creates a pattern that matches when all six observable sequences have an available element. @@ -297,12 +297,12 @@ internal Pattern(IObservable first, IObservable second, IObs Sixth = sixth; } - internal IObservable First { get; private set; } - internal IObservable Second { get; private set; } - internal IObservable Third { get; private set; } - internal IObservable Fourth { get; private set; } - internal IObservable Fifth { get; private set; } - internal IObservable Sixth { get; private set; } + internal IObservable First { get; } + internal IObservable Second { get; } + internal IObservable Third { get; } + internal IObservable Fourth { get; } + internal IObservable Fifth { get; } + internal IObservable Sixth { get; } /// /// Creates a pattern that matches when all seven observable sequences have an available element. @@ -363,13 +363,13 @@ internal Pattern(IObservable first, IObservable second, IObs Seventh = seventh; } - internal IObservable First { get; private set; } - internal IObservable Second { get; private set; } - internal IObservable Third { get; private set; } - internal IObservable Fourth { get; private set; } - internal IObservable Fifth { get; private set; } - internal IObservable Sixth { get; private set; } - internal IObservable Seventh { get; private set; } + internal IObservable First { get; } + internal IObservable Second { get; } + internal IObservable Third { get; } + internal IObservable Fourth { get; } + internal IObservable Fifth { get; } + internal IObservable Sixth { get; } + internal IObservable Seventh { get; } /// /// Creates a pattern that matches when all eight observable sequences have an available element. @@ -432,14 +432,14 @@ internal Pattern(IObservable first, IObservable second, IObs Eighth = eighth; } - internal IObservable First { get; private set; } - internal IObservable Second { get; private set; } - internal IObservable Third { get; private set; } - internal IObservable Fourth { get; private set; } - internal IObservable Fifth { get; private set; } - internal IObservable Sixth { get; private set; } - internal IObservable Seventh { get; private set; } - internal IObservable Eighth { get; private set; } + internal IObservable First { get; } + internal IObservable Second { get; } + internal IObservable Third { get; } + internal IObservable Fourth { get; } + internal IObservable Fifth { get; } + internal IObservable Sixth { get; } + internal IObservable Seventh { get; } + internal IObservable Eighth { get; } /// /// Creates a pattern that matches when all nine observable sequences have an available element. @@ -504,15 +504,15 @@ internal Pattern(IObservable first, IObservable second, IObs Ninth = ninth; } - internal IObservable First { get; private set; } - internal IObservable Second { get; private set; } - internal IObservable Third { get; private set; } - internal IObservable Fourth { get; private set; } - internal IObservable Fifth { get; private set; } - internal IObservable Sixth { get; private set; } - internal IObservable Seventh { get; private set; } - internal IObservable Eighth { get; private set; } - internal IObservable Ninth { get; private set; } + internal IObservable First { get; } + internal IObservable Second { get; } + internal IObservable Third { get; } + internal IObservable Fourth { get; } + internal IObservable Fifth { get; } + internal IObservable Sixth { get; } + internal IObservable Seventh { get; } + internal IObservable Eighth { get; } + internal IObservable Ninth { get; } /// /// Creates a pattern that matches when all ten observable sequences have an available element. @@ -579,16 +579,16 @@ internal Pattern(IObservable first, IObservable second, IObs Tenth = tenth; } - internal IObservable First { get; private set; } - internal IObservable Second { get; private set; } - internal IObservable Third { get; private set; } - internal IObservable Fourth { get; private set; } - internal IObservable Fifth { get; private set; } - internal IObservable Sixth { get; private set; } - internal IObservable Seventh { get; private set; } - internal IObservable Eighth { get; private set; } - internal IObservable Ninth { get; private set; } - internal IObservable Tenth { get; private set; } + internal IObservable First { get; } + internal IObservable Second { get; } + internal IObservable Third { get; } + internal IObservable Fourth { get; } + internal IObservable Fifth { get; } + internal IObservable Sixth { get; } + internal IObservable Seventh { get; } + internal IObservable Eighth { get; } + internal IObservable Ninth { get; } + internal IObservable Tenth { get; } /// /// Creates a pattern that matches when all eleven observable sequences have an available element. @@ -657,17 +657,17 @@ internal Pattern(IObservable first, IObservable second, IObs Eleventh = eleventh; } - internal IObservable First { get; private set; } - internal IObservable Second { get; private set; } - internal IObservable Third { get; private set; } - internal IObservable Fourth { get; private set; } - internal IObservable Fifth { get; private set; } - internal IObservable Sixth { get; private set; } - internal IObservable Seventh { get; private set; } - internal IObservable Eighth { get; private set; } - internal IObservable Ninth { get; private set; } - internal IObservable Tenth { get; private set; } - internal IObservable Eleventh { get; private set; } + internal IObservable First { get; } + internal IObservable Second { get; } + internal IObservable Third { get; } + internal IObservable Fourth { get; } + internal IObservable Fifth { get; } + internal IObservable Sixth { get; } + internal IObservable Seventh { get; } + internal IObservable Eighth { get; } + internal IObservable Ninth { get; } + internal IObservable Tenth { get; } + internal IObservable Eleventh { get; } /// /// Creates a pattern that matches when all twelve observable sequences have an available element. @@ -738,18 +738,18 @@ internal Pattern(IObservable first, IObservable second, IObs Twelfth = twelfth; } - internal IObservable First { get; private set; } - internal IObservable Second { get; private set; } - internal IObservable Third { get; private set; } - internal IObservable Fourth { get; private set; } - internal IObservable Fifth { get; private set; } - internal IObservable Sixth { get; private set; } - internal IObservable Seventh { get; private set; } - internal IObservable Eighth { get; private set; } - internal IObservable Ninth { get; private set; } - internal IObservable Tenth { get; private set; } - internal IObservable Eleventh { get; private set; } - internal IObservable Twelfth { get; private set; } + internal IObservable First { get; } + internal IObservable Second { get; } + internal IObservable Third { get; } + internal IObservable Fourth { get; } + internal IObservable Fifth { get; } + internal IObservable Sixth { get; } + internal IObservable Seventh { get; } + internal IObservable Eighth { get; } + internal IObservable Ninth { get; } + internal IObservable Tenth { get; } + internal IObservable Eleventh { get; } + internal IObservable Twelfth { get; } /// /// Creates a pattern that matches when all thirteen observable sequences have an available element. @@ -822,19 +822,19 @@ internal Pattern(IObservable first, IObservable second, IObs Thirteenth = thirteenth; } - internal IObservable First { get; private set; } - internal IObservable Second { get; private set; } - internal IObservable Third { get; private set; } - internal IObservable Fourth { get; private set; } - internal IObservable Fifth { get; private set; } - internal IObservable Sixth { get; private set; } - internal IObservable Seventh { get; private set; } - internal IObservable Eighth { get; private set; } - internal IObservable Ninth { get; private set; } - internal IObservable Tenth { get; private set; } - internal IObservable Eleventh { get; private set; } - internal IObservable Twelfth { get; private set; } - internal IObservable Thirteenth { get; private set; } + internal IObservable First { get; } + internal IObservable Second { get; } + internal IObservable Third { get; } + internal IObservable Fourth { get; } + internal IObservable Fifth { get; } + internal IObservable Sixth { get; } + internal IObservable Seventh { get; } + internal IObservable Eighth { get; } + internal IObservable Ninth { get; } + internal IObservable Tenth { get; } + internal IObservable Eleventh { get; } + internal IObservable Twelfth { get; } + internal IObservable Thirteenth { get; } /// /// Creates a pattern that matches when all fourteen observable sequences have an available element. @@ -909,20 +909,20 @@ internal Pattern(IObservable first, IObservable second, IObs Fourteenth = fourteenth; } - internal IObservable First { get; private set; } - internal IObservable Second { get; private set; } - internal IObservable Third { get; private set; } - internal IObservable Fourth { get; private set; } - internal IObservable Fifth { get; private set; } - internal IObservable Sixth { get; private set; } - internal IObservable Seventh { get; private set; } - internal IObservable Eighth { get; private set; } - internal IObservable Ninth { get; private set; } - internal IObservable Tenth { get; private set; } - internal IObservable Eleventh { get; private set; } - internal IObservable Twelfth { get; private set; } - internal IObservable Thirteenth { get; private set; } - internal IObservable Fourteenth { get; private set; } + internal IObservable First { get; } + internal IObservable Second { get; } + internal IObservable Third { get; } + internal IObservable Fourth { get; } + internal IObservable Fifth { get; } + internal IObservable Sixth { get; } + internal IObservable Seventh { get; } + internal IObservable Eighth { get; } + internal IObservable Ninth { get; } + internal IObservable Tenth { get; } + internal IObservable Eleventh { get; } + internal IObservable Twelfth { get; } + internal IObservable Thirteenth { get; } + internal IObservable Fourteenth { get; } /// /// Creates a pattern that matches when all fifteen observable sequences have an available element. @@ -999,21 +999,21 @@ internal Pattern(IObservable first, IObservable second, IObs Fifteenth = fifteenth; } - internal IObservable First { get; private set; } - internal IObservable Second { get; private set; } - internal IObservable Third { get; private set; } - internal IObservable Fourth { get; private set; } - internal IObservable Fifth { get; private set; } - internal IObservable Sixth { get; private set; } - internal IObservable Seventh { get; private set; } - internal IObservable Eighth { get; private set; } - internal IObservable Ninth { get; private set; } - internal IObservable Tenth { get; private set; } - internal IObservable Eleventh { get; private set; } - internal IObservable Twelfth { get; private set; } - internal IObservable Thirteenth { get; private set; } - internal IObservable Fourteenth { get; private set; } - internal IObservable Fifteenth { get; private set; } + internal IObservable First { get; } + internal IObservable Second { get; } + internal IObservable Third { get; } + internal IObservable Fourth { get; } + internal IObservable Fifth { get; } + internal IObservable Sixth { get; } + internal IObservable Seventh { get; } + internal IObservable Eighth { get; } + internal IObservable Ninth { get; } + internal IObservable Tenth { get; } + internal IObservable Eleventh { get; } + internal IObservable Twelfth { get; } + internal IObservable Thirteenth { get; } + internal IObservable Fourteenth { get; } + internal IObservable Fifteenth { get; } /// /// Creates a pattern that matches when all sixteen observable sequences have an available element. @@ -1092,22 +1092,22 @@ internal Pattern(IObservable first, IObservable second, IObs Sixteenth = sixteenth; } - internal IObservable First { get; private set; } - internal IObservable Second { get; private set; } - internal IObservable Third { get; private set; } - internal IObservable Fourth { get; private set; } - internal IObservable Fifth { get; private set; } - internal IObservable Sixth { get; private set; } - internal IObservable Seventh { get; private set; } - internal IObservable Eighth { get; private set; } - internal IObservable Ninth { get; private set; } - internal IObservable Tenth { get; private set; } - internal IObservable Eleventh { get; private set; } - internal IObservable Twelfth { get; private set; } - internal IObservable Thirteenth { get; private set; } - internal IObservable Fourteenth { get; private set; } - internal IObservable Fifteenth { get; private set; } - internal IObservable Sixteenth { get; private set; } + internal IObservable First { get; } + internal IObservable Second { get; } + internal IObservable Third { get; } + internal IObservable Fourth { get; } + internal IObservable Fifth { get; } + internal IObservable Sixth { get; } + internal IObservable Seventh { get; } + internal IObservable Eighth { get; } + internal IObservable Ninth { get; } + internal IObservable Tenth { get; } + internal IObservable Eleventh { get; } + internal IObservable Twelfth { get; } + internal IObservable Thirteenth { get; } + internal IObservable Fourteenth { get; } + internal IObservable Fifteenth { get; } + internal IObservable Sixteenth { get; } /// /// Matches when all observable sequences have an available element and projects the elements by invoking the selector function. @@ -1129,4 +1129,4 @@ public Plan Then(Func CreateObserver( internal class Plan : Plan { - internal Pattern Expression { get; private set; } + internal Pattern Expression { get; } - internal Func Selector { get; private set; } + internal Func Selector { get; } internal Plan(Pattern expression, Func selector) { @@ -83,9 +83,9 @@ internal override ActivePlan Activate(Dictionary external internal class Plan : Plan { - internal Pattern Expression { get; private set; } + internal Pattern Expression { get; } - internal Func Selector { get; private set; } + internal Func Selector { get; } internal Plan(Pattern expression, Func selector) { @@ -131,9 +131,9 @@ internal override ActivePlan Activate(Dictionary external internal class Plan : Plan { - internal Pattern Expression { get; private set; } + internal Pattern Expression { get; } - internal Func Selector { get; private set; } + internal Func Selector { get; } internal Plan(Pattern expression, Func selector) { @@ -183,9 +183,9 @@ internal override ActivePlan Activate(Dictionary external internal class Plan : Plan { - internal Pattern Expression { get; private set; } + internal Pattern Expression { get; } - internal Func Selector { get; private set; } + internal Func Selector { get; } internal Plan(Pattern expression, Func selector) @@ -238,9 +238,9 @@ internal override ActivePlan Activate(Dictionary external internal class Plan : Plan { - internal Pattern Expression { get; private set; } + internal Pattern Expression { get; } - internal Func Selector { get; private set; } + internal Func Selector { get; } internal Plan(Pattern expression, Func selector) @@ -296,9 +296,9 @@ internal override ActivePlan Activate(Dictionary external internal class Plan : Plan { - internal Pattern Expression { get; private set; } + internal Pattern Expression { get; } - internal Func Selector { get; private set; } + internal Func Selector { get; } internal Plan(Pattern expression, Func selector) @@ -358,9 +358,9 @@ internal override ActivePlan Activate(Dictionary external internal class Plan : Plan { - internal Pattern Expression { get; private set; } + internal Pattern Expression { get; } - internal Func Selector { get; private set; } + internal Func Selector { get; } internal Plan(Pattern expression, Func selector) @@ -423,9 +423,9 @@ internal override ActivePlan Activate(Dictionary external internal class Plan : Plan { - internal Pattern Expression { get; private set; } + internal Pattern Expression { get; } - internal Func Selector { get; private set; } + internal Func Selector { get; } internal Plan(Pattern expression, Func selector) @@ -491,9 +491,9 @@ internal override ActivePlan Activate(Dictionary external internal class Plan : Plan { - internal Pattern Expression { get; private set; } + internal Pattern Expression { get; } - internal Func Selector { get; private set; } + internal Func Selector { get; } internal Plan(Pattern expression, Func selector) @@ -562,9 +562,9 @@ internal override ActivePlan Activate(Dictionary external internal class Plan : Plan { - internal Pattern Expression { get; private set; } + internal Pattern Expression { get; } - internal Func Selector { get; private set; } + internal Func Selector { get; } internal Plan(Pattern expression, Func selector) @@ -636,9 +636,9 @@ internal override ActivePlan Activate(Dictionary external internal class Plan : Plan { - internal Pattern Expression { get; private set; } + internal Pattern Expression { get; } - internal Func Selector { get; private set; } + internal Func Selector { get; } internal Plan(Pattern expression, Func selector) @@ -714,9 +714,9 @@ internal override ActivePlan Activate(Dictionary external internal class Plan : Plan { - internal Pattern Expression { get; private set; } + internal Pattern Expression { get; } - internal Func Selector { get; private set; } + internal Func Selector { get; } internal Plan(Pattern expression, Func selector) @@ -797,9 +797,9 @@ internal override ActivePlan Activate(Dictionary external internal class Plan : Plan { - internal Pattern Expression { get; private set; } + internal Pattern Expression { get; } - internal Func Selector { get; private set; } + internal Func Selector { get; } internal Plan(Pattern expression, Func selector) @@ -883,9 +883,9 @@ internal override ActivePlan Activate(Dictionary external internal class Plan : Plan { - internal Pattern Expression { get; private set; } + internal Pattern Expression { get; } - internal Func Selector { get; private set; } + internal Func Selector { get; } internal Plan(Pattern expression, Func selector) @@ -975,9 +975,9 @@ internal override ActivePlan Activate(Dictionary external internal class Plan : Plan { - internal Pattern Expression { get; private set; } + internal Pattern Expression { get; } - internal Func Selector { get; private set; } + internal Func Selector { get; } internal Plan(Pattern expression, Func selector) @@ -1069,9 +1069,9 @@ internal override ActivePlan Activate(Dictionary external } internal class Plan : Plan { - internal Pattern Expression { get; private set; } + internal Pattern Expression { get; } - internal Func Selector { get; private set; } + internal Func Selector { get; } internal Plan(Pattern expression, Func selector) @@ -1165,4 +1165,4 @@ internal override ActivePlan Activate(Dictionary external return activePlan; } } -} \ No newline at end of file +} diff --git a/Rx.NET/Source/src/System.Reactive/Joins/QueryablePattern.cs b/Rx.NET/Source/src/System.Reactive/Joins/QueryablePattern.cs index 261bf080e6..5dd4067f5e 100644 --- a/Rx.NET/Source/src/System.Reactive/Joins/QueryablePattern.cs +++ b/Rx.NET/Source/src/System.Reactive/Joins/QueryablePattern.cs @@ -26,7 +26,7 @@ protected QueryablePattern(Expression expression) /// /// Gets the expression tree representing the join pattern. /// - public Expression Expression { get; private set; } + public Expression Expression { get; } } /* The following code is generated by a tool checked in to $/.../Source/Tools/CodeGenerators. */ diff --git a/Rx.NET/Source/src/System.Reactive/Joins/QueryablePlan.cs b/Rx.NET/Source/src/System.Reactive/Joins/QueryablePlan.cs index 6ff55bf711..b4321126a3 100644 --- a/Rx.NET/Source/src/System.Reactive/Joins/QueryablePlan.cs +++ b/Rx.NET/Source/src/System.Reactive/Joins/QueryablePlan.cs @@ -1,4 +1,4 @@ -// Licensed to the .NET Foundation under one or more agreements. +// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the Apache 2.0 License. // See the LICENSE file in the project root for more information. @@ -22,7 +22,7 @@ internal QueryablePlan(Expression expression) /// /// Gets the expression tree representing the join pattern execution plan. /// - public Expression Expression { get; private set; } + public Expression Expression { get; } } }