Skip to content

Audit OOB packages for trimming #107111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
agocke opened this issue Aug 28, 2024 · 4 comments
Closed

Audit OOB packages for trimming #107111

agocke opened this issue Aug 28, 2024 · 4 comments
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework

Comments

@agocke
Copy link
Member

agocke commented Aug 28, 2024

We scan the entire shared framework for trim warnings, but some stuff (like System.Memory.Data) seems to have been missed by the scans. We should ensure everything in dotnet/runtime is trimmable.
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 28, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Aug 28, 2024
@jtschuster jtschuster added linkable-framework Issues associated with delivering a linker friendly framework area-Tools-ILLink .NET linker development as well as trimming analyzers and removed untriaged New issue has not been triaged by the area owner needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 28, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

@eerhardt
Copy link
Member

(like System.Memory.Data)

This assembly was taken care of with #54980 and #69012.

I think this issue is a duplicate of #75480.

@agocke
Copy link
Member Author

agocke commented Aug 28, 2024

Great! I will close this in favor of #75480

@agocke agocke closed this as completed Aug 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework
Projects
AppModel
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@agocke @eerhardt @jtschuster