-
Notifications
You must be signed in to change notification settings - Fork 5k
Enable linker analysis and add baselines for warnings #38033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Milestone
Comments
This was referenced Jul 29, 2020
Moving to 6.0 as this isn't needed for 5.0. |
2 tasks
Resolved by #40691. Closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
dotnet/linker#1030 will change the ILLinker that it will start adding warnings by default when it detects unsafe use of reflection. This will cause our libraries build to start emitting a lot of warnings (in the hundreds).
To keep our build clean, we should add a "baseline" of linker warnings to the repo, which will suppress the warnings. In the future, as we annotate the usages of reflection to make them linker-safe, we can remove the suppressions.
To suppress individual warnings, we can create a
LinkerSuppressions.cs
file in each project that will containUnconditionalSuppressMessage
attributes. @mateoatr is working on a mechanism that can generate these suppress message attributes that we can use to bootstrap the baselines.cc @vitek-karas
The text was updated successfully, but these errors were encountered: