Skip to content

Microsoft.NET.Runtime.Emscripten.* packages are missing from the preview3 output #50822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pranavkm opened this issue Apr 7, 2021 · 17 comments
Closed
Assignees
Milestone

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Apr 7, 2021

Tracking issue to make sure we address this for preview4. It looks like these packages aren't part of the set of packages being uploaded for preview3, perhaps some metadata about this is amiss.

@ghost ghost added area-Setup untriaged New issue has not been triaged by the area owner labels Apr 7, 2021
@lewing
Copy link
Member

lewing commented Apr 7, 2021

cc @steveisok @akoeplinger

Not sure what is going on here but let's figure it out for the next preview.

@lewing lewing added the arch-wasm WebAssembly architecture label Apr 7, 2021
@ghost
Copy link

ghost commented Apr 7, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Tracking issue to make sure we address this for preview4. It looks like these packages aren't part of the set of packages being uploaded for preview3, perhaps some metadata about this is amiss.

Author: pranavkm
Assignees: -
Labels:

arch-wasm, area-Setup, untriaged

Milestone: -

@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Apr 7, 2021
@lewing lewing added this to the 6.0.0 milestone Apr 7, 2021
@akoeplinger
Copy link
Member

So I looked at the https://dev.azure.com/dnceng/public/_packaging?_a=feed&feed=dotnet6-stage feed and it looks like there are no preview3 packages at all in that feed for both aspnetcore and runtime components:

image

image

Looks more like a general issue with the feed to me.

@mmitche

@lewing lewing removed the arch-wasm WebAssembly architecture label Apr 7, 2021
@mmitche
Copy link
Member

mmitche commented Apr 7, 2021

There was an issue with the staging pipeline that caused it not to populate this feed. Filed dotnet/arcade#7200

Use https://pkgs.dev.azure.com/dnceng/public/_packaging/6.0.100-preview.3.21202.5-2/nuget/v3/index.json for now.

@akoeplinger
Copy link
Member

Ok, thanks. I don't see the Emscripten packages there though.

@mmitche is there any special setup we need to do? I checked the darc channel mappings and it looks correct to me:

(3374) https://github.com/dotnet/emsdk @ main -> .NET 6
(3416) https://github.com/dotnet/emsdk @ release/6.0-preview3 -> .NET 6 Preview 3

@mmitche
Copy link
Member

mmitche commented Apr 7, 2021

@akoeplinger That build wasn't put through the staging pipeline. Is this the correct build? https://maestro-prod.westus2.cloudapp.azure.com/1850/https:%2F%2Fgithub.com%2Fdotnet%2Femsdk/latest/graph

Packages don't automatically appear in the output by being assigned the channel. For instance, you might easily end up with an incoherent product because installer might be referencing an older runtime than the latest runtime (e.g. accidental build). We stage installer and then its dependencies get pulled in transitively. We used to gather extensions too (prior to it being decommissioned in .NET 6).

We can update our process to gather this repo in addition to installer, if it's not ever referenced transitively.

@mmitche
Copy link
Member

mmitche commented Apr 7, 2021

/cc @lukas-lansky

@akoeplinger
Copy link
Member

It looks like the issue is because aspnetcore used dotnet/runtime as the repo in Version.Details.xml but these packages are produced by the dotnet/emsdk repo: https://github.com/dotnet/aspnetcore/blob/main/eng/Version.Details.xml#L288-L299

@akoeplinger
Copy link
Member

akoeplinger commented Apr 7, 2021

@mmitche yes the build you linked is the correct one edit: actually looks like aspnetcore is referencing 6.0.0-preview.3.21175.11. Is there a way to manually add it to the feed for now to unblock aspnetcore?

@mmitche
Copy link
Member

mmitche commented Apr 7, 2021

@akoeplinger I can't find any assets with those names and versions. It looks like aspnetcore is referencing packages that don't exist?

It looks emsdk should be flowing into aspnetcore. I've added a subscription for that.

@mmitche
Copy link
Member

mmitche commented Apr 7, 2021

See update here: dotnet/aspnetcore#31576

@akoeplinger
Copy link
Member

hm yeah looks like they used 6.0.0-preview.3.21175.11 copied from Microsoft.NETCore.App.Runtime.win-x64 in the preview3 Versions.Details.xml and that then didn't get updated: https://github.com/dotnet/aspnetcore/blob/release/6.0-preview3/eng/Version.Details.xml#L288-L299

you're right that the only preview 3 build of dotnet/emsdk is indeed 6.0.0-preview.3.21176.1. @pranavkm I think you'll need to fix that on your end :)

@mmitche
Copy link
Member

mmitche commented Apr 7, 2021

It's too late for p3 at this point, so this will have to be p4. The regular flow for this should now avoid this issue in the future.

@akoeplinger
Copy link
Member

I see that there's no darc subscription for dotnet/emsdk release/6.0-preview3 to dotnet/aspnetcore release/6.0-preview3, do we need to manually add those whenever a new release branch is created?

@akoeplinger
Copy link
Member

Ah I see there's https://github.com/dotnet/arcade/blob/main/scripts/create-net6-preview-flow.ps1, sounds like we should add emsdk there. I'll open a PR.

@mmitche
Copy link
Member

mmitche commented Apr 7, 2021

dotnet/arcade#7202

@akoeplinger
Copy link
Member

With dotnet/arcade#7202 we'll get the flows set up correctly for preview4 branching, I don't think there's anything left for us to do here.

@ghost ghost locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants