From 61afd9c2834ab4da01511d41bc88810f4fe35c3b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Cant=C3=BA?= Date: Tue, 16 Jul 2024 12:55:50 -0500 Subject: [PATCH] Disable tests that use a flaky FSW in Windows --- .../tests/FileSystemWatcher.Directory.Changed.cs | 1 + .../tests/FileSystemWatcher.Directory.Create.cs | 3 +++ .../tests/FileSystemWatcher.Directory.Delete.cs | 1 + .../tests/FileSystemWatcher.Directory.Move.cs | 2 ++ .../tests/FileSystemWatcher.Directory.NotifyFilter.cs | 3 +++ .../tests/FileSystemWatcher.File.Changed.cs | 1 + .../tests/FileSystemWatcher.File.Create.cs | 1 + .../tests/FileSystemWatcher.File.Delete.cs | 3 +++ .../tests/FileSystemWatcher.File.Move.cs | 2 ++ .../tests/FileSystemWatcher.File.NotifyFilter.cs | 2 ++ .../tests/FileSystemWatcher.InternalBufferSize.cs | 1 + .../tests/FileSystemWatcher.SymbolicLink.cs | 1 + .../tests/FileSystemWatcher.unit.cs | 3 +++ 13 files changed, 24 insertions(+) diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Changed.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Changed.cs index bef5def6c97bcb..4a5a619d1a7e5e 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Changed.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Changed.cs @@ -78,6 +78,7 @@ public void FileSystemWatcher_Directory_Changed_SymLink() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_Directory_Changed_SynchronizingObject() { string dir = CreateTestDirectory(TestDirectory, "dir"); diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Create.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Create.cs index 023cc679eb32b3..5771eeeb4afcf0 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Create.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Create.cs @@ -31,6 +31,7 @@ public void FileSystemWatcher_Directory_PathNotExists() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_Directory_Create() { using (var watcher = new FileSystemWatcher(TestDirectory)) @@ -46,6 +47,7 @@ public void FileSystemWatcher_Directory_Create() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_Directory_Create_InNestedDirectory() { string nestedDir = CreateTestDirectory(TestDirectory, "dir1", "nested"); @@ -98,6 +100,7 @@ public void FileSystemWatcher_Directory_Create_SymLink() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_Directory_Create_SynchronizingObject() { using (var watcher = new FileSystemWatcher(TestDirectory)) diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Delete.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Delete.cs index a30e355acccf69..e6963b2e14f7ff 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Delete.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Delete.cs @@ -64,6 +64,7 @@ public void FileSystemWatcher_Directory_Delete_DeepDirectoryStructure() } [ConditionalFact(typeof(MountHelper), nameof(MountHelper.CanCreateSymbolicLinks))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_Directory_Delete_SymLink() { string dir = CreateTestDirectory(TestDirectory, "dir"); diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Move.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Move.cs index 1b80e14167b3cc..5959660065e50c 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Move.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Move.cs @@ -77,6 +77,7 @@ public void Unix_Directory_Move_To_Different_Watched_Directory() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void Directory_Move_From_Unwatched_To_Watched() { DirectoryMove_FromUnwatchedToWatched(WatcherChangeTypes.Created); @@ -85,6 +86,7 @@ public void Directory_Move_From_Unwatched_To_Watched() [Theory] [InlineData(false)] [InlineData(true)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void Directory_Move_In_Nested_Directory(bool includeSubdirectories) { DirectoryMove_NestedDirectory(includeSubdirectories ? WatcherChangeTypes.Renamed : 0, includeSubdirectories); diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.NotifyFilter.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.NotifyFilter.cs index 2a692ad6056cb6..7a99fc6603eb4f 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.NotifyFilter.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.NotifyFilter.cs @@ -21,6 +21,7 @@ private static partial uint SetSecurityInfoByHandle( string name, uint objectTyp [Theory] [MemberData(nameof(FilterTypes))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_Directory_NotifyFilter_Attributes(NotifyFilters filter) { FileSystemWatcherTest.Execute(() => @@ -165,6 +166,7 @@ public void FileSystemWatcher_Directory_NotifyFilter_LastWriteTime_TwoFilters(No [Theory] [MemberData(nameof(FilterTypes))] [PlatformSpecific(TestPlatforms.Windows)] // Uses P/Invokes to set security info + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_Directory_NotifyFilter_Security(NotifyFilters filter) { string dir = CreateTestDirectory(TestDirectory, "dir"); @@ -222,6 +224,7 @@ public void FileSystemWatcher_Directory_NotifyFilter_LastWriteAndFileName() /// after each other. /// [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_Directory_NotifyFilter_ModifyAndCreate() { string dir = CreateTestDirectory(TestDirectory, "dir"); diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Changed.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Changed.cs index 44b41c3778e201..e4b3836bbaba8e 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Changed.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Changed.cs @@ -9,6 +9,7 @@ namespace System.IO.Tests public class File_Changed_Tests : FileSystemWatcherTest { [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_File_Changed_LastWrite() { string file = CreateTestFile(TestDirectory, "file"); diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Create.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Create.cs index 5c36caf0a38fd1..900bd5795845ec 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Create.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Create.cs @@ -85,6 +85,7 @@ public void FileSystemWatcher_File_Create_ForcedRestart() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_File_Create_InNestedDirectory() { string nestedDir = CreateTestDirectory(TestDirectory, "dir1", "nested"); diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Delete.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Delete.cs index ac076e4fd2202b..7aadee89206031 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Delete.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Delete.cs @@ -11,6 +11,7 @@ namespace System.IO.Tests public class File_Delete_Tests : FileSystemWatcherTest { [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_File_Delete() { using (var watcher = new FileSystemWatcher(TestDirectory)) @@ -27,6 +28,7 @@ public void FileSystemWatcher_File_Delete() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_File_Delete_ForcedRestart() { using (var watcher = new FileSystemWatcher(TestDirectory)) @@ -47,6 +49,7 @@ public void FileSystemWatcher_File_Delete_ForcedRestart() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_File_Delete_InNestedDirectory() { string nestedDir = CreateTestDirectory(TestDirectory, "dir1", "nested"); diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs index e03ebc8ee92a8c..342dd64ab78ca0 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs @@ -12,6 +12,7 @@ public class File_Move_Tests : FileSystemWatcherTest { [Fact] [PlatformSpecific(TestPlatforms.Windows)] // Expected WatcherChangeTypes are different based on OS + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void Windows_File_Move_To_Same_Directory() { FileMove_SameDirectory(WatcherChangeTypes.Renamed); @@ -126,6 +127,7 @@ public void Unix_File_Move_With_Set_NotifyFilter() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void File_Move_SynchronizingObject() { string dir = CreateTestDirectory(TestDirectory, "dir"); diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.NotifyFilter.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.NotifyFilter.cs index 7067ffc8997d7a..dfe5f9fc051541 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.NotifyFilter.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.NotifyFilter.cs @@ -139,6 +139,7 @@ public void FileSystemWatcher_File_NotifyFilter_LastWriteTime(NotifyFilters filt [Theory] [MemberData(nameof(FilterTypes))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_File_NotifyFilter_Size(NotifyFilters filter) { string file = CreateTestFile(TestDirectory, "file"); @@ -193,6 +194,7 @@ public void FileSystemWatcher_File_NotifyFilter_Size_TwoFilters(NotifyFilters fi [Theory] [MemberData(nameof(FilterTypes))] [PlatformSpecific(TestPlatforms.Windows)] // Uses P/Invokes to set security info + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_File_NotifyFilter_Security(NotifyFilters filter) { string file = CreateTestFile(TestDirectory, "file"); diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.InternalBufferSize.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.InternalBufferSize.cs index 6df52a9395793e..0d471cc9876730 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.InternalBufferSize.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.InternalBufferSize.cs @@ -74,6 +74,7 @@ public void FileSystemWatcher_InternalBufferSize(bool setToHigherCapacity) [Fact] [PlatformSpecific(TestPlatforms.Windows)] [OuterLoop("A little slow")] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_InternalBufferSize_SynchronizingObject() { ManualResetEvent unblockHandler = new ManualResetEvent(false); diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs index ba6e6c434108e2..9a3f5c907b47af 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs @@ -58,6 +58,7 @@ public void FileSystemWatcher_DirectorySymbolicLink_TargetsSelf_Fails() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_SymbolicLink_TargetsDirectory_Create() { // Arrange diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.unit.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.unit.cs index e1040f5bc8d040..1248a5744c5074 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.unit.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.unit.cs @@ -258,6 +258,7 @@ public void FileSystemWatcher_IncludeSubdirectories() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_InternalBufferSize() { FileSystemWatcher watcher = new FileSystemWatcher(); @@ -567,6 +568,7 @@ public void FileSystemWatcher_StopCalledOnBackgroundThreadDoesNotDeadlock() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_WatchingAliasedFolderResolvesToRealPathWhenWatching() { string dir = CreateTestDirectory(TestDirectory, "dir"); @@ -1001,6 +1003,7 @@ public void FileSystemWatcher_Directory_Create_Filter_Ctor() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_Directory_Delete_MultipleFilters() { using var tempDir = new TempDirectory();