diff --git a/Directory.Build.props b/Directory.Build.props index 821b777a6d2f67..e887d066f5c38b 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -389,6 +389,8 @@ true $(NoWarn);CS8500;CS8969 + + $(NoWarn);CS1591 portable true diff --git a/eng/intellisense.targets b/eng/intellisense.targets index d4e360957f206b..7e1cb0054d3115 100644 --- a/eng/intellisense.targets +++ b/eng/intellisense.targets @@ -1,5 +1,9 @@ + + true + + $([MSBuild]::NormalizeDirectory('$(NuGetPackageRoot)', 'microsoft.private.intellisense', '$(MicrosoftPrivateIntellisenseVersion)', 'IntellisenseFiles')) $([MSBuild]::NormalizePath('$(IntellisensePackageXmlRootFolder)', 'net', '1033', '$(AssemblyName).xml')) @@ -10,7 +14,7 @@ $(IntermediateOutputPath)$(TargetName).intellisense-package.xml - $(NoWarn);1591 + $(NoWarn);CS1591 + + + + diff --git a/src/libraries/Common/src/System/Security/Cryptography/X509Certificates/X509CertificateLoader.cs b/src/libraries/Common/src/System/Security/Cryptography/X509Certificates/X509CertificateLoader.cs index a4ef6480b0eea9..71e8c2c1802a4e 100644 --- a/src/libraries/Common/src/System/Security/Cryptography/X509Certificates/X509CertificateLoader.cs +++ b/src/libraries/Common/src/System/Security/Cryptography/X509Certificates/X509CertificateLoader.cs @@ -13,7 +13,9 @@ namespace System.Security.Cryptography.X509Certificates { [UnsupportedOSPlatform("browser")] +#pragma warning disable 1591 // TODO: Document this API. https://github.com/dotnet/runtime/issues/105974 public static partial class X509CertificateLoader +#pragma warning restore 1591 { private const int MemoryMappedFileCutoff = 1_048_576; diff --git a/src/libraries/Microsoft.Extensions.Http/src/DependencyInjection/HttpClientBuilderExtensions.cs b/src/libraries/Microsoft.Extensions.Http/src/DependencyInjection/HttpClientBuilderExtensions.cs index ec04971fb758c5..ebda07a8f77d1a 100644 --- a/src/libraries/Microsoft.Extensions.Http/src/DependencyInjection/HttpClientBuilderExtensions.cs +++ b/src/libraries/Microsoft.Extensions.Http/src/DependencyInjection/HttpClientBuilderExtensions.cs @@ -645,6 +645,7 @@ public static IHttpClientBuilder ConfigureAdditionalHttpMessageHandlers(this IHt return builder; } +#pragma warning disable 1591 // TODO: Document this API. https://github.com/dotnet/runtime/issues/105974 public static IHttpClientBuilder AddAsKeyed(this IHttpClientBuilder builder, ServiceLifetime lifetime = ServiceLifetime.Scoped) { ThrowHelper.ThrowIfNull(builder); @@ -703,6 +704,7 @@ public static IHttpClientBuilder RemoveAsKeyed(this IHttpClientBuilder builder) return builder; } +#pragma warning restore 1591 // workaround for https://github.com/dotnet/runtime/issues/102654 private static void UpdateEmptyNameHttpClient(IServiceCollection services, HttpClientMappingRegistry registry) diff --git a/src/libraries/Microsoft.Internal.Runtime.DotNetApiDocs.Transport/src/Microsoft.Internal.Runtime.DotNetApiDocs.Transport.proj b/src/libraries/Microsoft.Internal.Runtime.DotNetApiDocs.Transport/src/Microsoft.Internal.Runtime.DotNetApiDocs.Transport.proj index c3f609b832b6e6..6e0335216c3b51 100644 --- a/src/libraries/Microsoft.Internal.Runtime.DotNetApiDocs.Transport/src/Microsoft.Internal.Runtime.DotNetApiDocs.Transport.proj +++ b/src/libraries/Microsoft.Internal.Runtime.DotNetApiDocs.Transport/src/Microsoft.Internal.Runtime.DotNetApiDocs.Transport.proj @@ -28,7 +28,6 @@ - @@ -41,13 +40,16 @@ + + + - - diff --git a/src/libraries/System.Net.Http/src/System.Net.Http.csproj b/src/libraries/System.Net.Http/src/System.Net.Http.csproj index 1431ca945598f4..c6af468c253228 100644 --- a/src/libraries/System.Net.Http/src/System.Net.Http.csproj +++ b/src/libraries/System.Net.Http/src/System.Net.Http.csproj @@ -4,6 +4,7 @@ $(NetCoreAppCurrent)-windows;$(NetCoreAppCurrent)-linux;$(NetCoreAppCurrent)-osx;$(NetCoreAppCurrent)-freebsd;$(NetCoreAppCurrent)-maccatalyst;$(NetCoreAppCurrent)-ios;$(NetCoreAppCurrent)-tvos;$(NetCoreAppCurrent)-browser;$(NetCoreAppCurrent)-wasi;$(NetCoreAppCurrent)-illumos;$(NetCoreAppCurrent)-solaris;$(NetCoreAppCurrent)-haiku;$(NetCoreAppCurrent)-android;$(NetCoreAppCurrent) true $(DefineConstants);HTTP_DLL + false diff --git a/src/libraries/System.Numerics.Tensors/src/System/NIndex.cs b/src/libraries/System.Numerics.Tensors/src/System/NIndex.cs index 0ccfebea718b7e..ab14d2ed80c928 100644 --- a/src/libraries/System.Numerics.Tensors/src/System/NIndex.cs +++ b/src/libraries/System.Numerics.Tensors/src/System/NIndex.cs @@ -91,8 +91,10 @@ public static NIndex FromEnd(nint value) return new NIndex(~value); } +#pragma warning disable 1591 // TODO: Document this API. https://github.com/dotnet/runtime/issues/105981 public Index ToIndex() => checked((Index)this); public Index ToIndexUnchecked() => (Index)this; +#pragma warning restore 1591 /// Returns the NIndex value. public nint Value diff --git a/src/libraries/System.Numerics.Tensors/src/System/NRange.cs b/src/libraries/System.Numerics.Tensors/src/System/NRange.cs index 5335da4488e1ff..48211d5a4ee408 100644 --- a/src/libraries/System.Numerics.Tensors/src/System/NRange.cs +++ b/src/libraries/System.Numerics.Tensors/src/System/NRange.cs @@ -121,6 +121,7 @@ public override string ToString() private static void ThrowArgumentOutOfRangeException() => throw new ArgumentOutOfRangeException("length"); +#pragma warning disable 1591 // TODO: Document this API. https://github.com/dotnet/runtime/issues/105981 public static implicit operator NRange(Range range) => new NRange(range.Start, range.End); public static explicit operator Range(NRange value) => new Range((Index)value.Start, (Index)value.End); @@ -128,5 +129,6 @@ public override string ToString() public Range ToRange() => new Range(checked((Index)Start), checked((Index)End)); public Range ToRangeUnchecked() => new Range((Index)Start, (Index)End); +#pragma warning restore 1591 } } diff --git a/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/IReadOnlyTensor.cs b/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/IReadOnlyTensor.cs index de5611c765edcf..16319b224c1db8 100644 --- a/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/IReadOnlyTensor.cs +++ b/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/IReadOnlyTensor.cs @@ -5,6 +5,8 @@ using System.Collections.Generic; using System.Diagnostics.CodeAnalysis; +#pragma warning disable 1591 // TODO: Document this API. https://github.com/dotnet/runtime/issues/105981 + namespace System.Numerics.Tensors { [Experimental(Experimentals.TensorTDiagId, UrlFormat = Experimentals.SharedUrlFormat)] @@ -44,3 +46,5 @@ public interface IReadOnlyTensor : IEnumerable bool TryFlattenTo(scoped Span destination); } } + +#pragma warning restore 1591 diff --git a/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/ITensor.cs b/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/ITensor.cs index 83abcc1def2fb3..3a6ee32d03d2af 100644 --- a/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/ITensor.cs +++ b/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/ITensor.cs @@ -4,6 +4,8 @@ using System.Buffers; using System.Diagnostics.CodeAnalysis; +#pragma warning disable 1591 // TODO: Document this API. https://github.com/dotnet/runtime/issues/105981 + namespace System.Numerics.Tensors { [Experimental(Experimentals.TensorTDiagId, UrlFormat = Experimentals.SharedUrlFormat)] @@ -37,3 +39,5 @@ public interface ITensor new ref T GetPinnableReference(); } } + +#pragma warning restore 1591 diff --git a/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/ReadOnlyTensorSpan.cs b/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/ReadOnlyTensorSpan.cs index 5122ca3e8513af..b3cfe8d808d6f8 100644 --- a/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/ReadOnlyTensorSpan.cs +++ b/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/ReadOnlyTensorSpan.cs @@ -600,7 +600,9 @@ public bool TryCopyTo(scoped TensorSpan destination) } //public static explicit operator TensorSpan(Array? array); +#pragma warning disable 1591 // TODO: Document this API. https://github.com/dotnet/runtime/issues/105981 public static implicit operator ReadOnlyTensorSpan(T[]? array) => new ReadOnlyTensorSpan(array); +#pragma warning restore 1591 /// /// Returns a with the name of the type and the number of elements. diff --git a/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/Tensor.Factory.cs b/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/Tensor.Factory.cs index 5c9d78558cd718..373567e119c724 100644 --- a/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/Tensor.Factory.cs +++ b/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/Tensor.Factory.cs @@ -175,6 +175,7 @@ public static Tensor CreateUninitialized(scoped ReadOnlySpan lengths return new Tensor(values, lengths, strides, pinned); } +#pragma warning disable 1591 // TODO: Document this API. https://github.com/dotnet/runtime/issues/105981 public static ref readonly TensorSpan FillGaussianNormalDistribution(in TensorSpan destination, Random? random = null) where T : IFloatingPoint { Span span = MemoryMarshal.CreateSpan(ref destination._reference, (int)destination._shape._memoryLength); @@ -193,5 +194,6 @@ public static ref readonly TensorSpan FillUniformDistribution(in TensorSpa return ref destination; } +#pragma warning restore 1591 } } diff --git a/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/Tensor.cs b/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/Tensor.cs index 48d87aa7ca6da5..76434215704c0c 100644 --- a/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/Tensor.cs +++ b/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/Tensor.cs @@ -19,8 +19,10 @@ namespace System.Numerics.Tensors { [Experimental(Experimentals.TensorTDiagId, UrlFormat = Experimentals.SharedUrlFormat)] +#pragma warning disable 1591 // TODO: Document this API. https://github.com/dotnet/runtime/issues/105981 public sealed class Tensor : ITensor, T> +#pragma warning restore 1591 { /// A byref or a native ptr. internal readonly T[] _values; @@ -365,11 +367,13 @@ public Tensor this[Tensor filter] } } +#pragma warning disable 1591 // TODO: Document this API. https://github.com/dotnet/runtime/issues/105981 public static implicit operator Tensor(T[] array) => new Tensor(array, [array.Length]); public static implicit operator TensorSpan(Tensor value) => new TensorSpan(ref MemoryMarshal.GetArrayDataReference(value._values), value._lengths, value._strides, value._flattenedLength); public static implicit operator ReadOnlyTensorSpan(Tensor value) => new ReadOnlyTensorSpan(ref MemoryMarshal.GetArrayDataReference(value._values), value._lengths, value._strides, value.FlattenedLength); +#pragma warning restore 1591 /// /// Converts this to a pointing to the same backing memory."/> @@ -614,10 +618,12 @@ public void Dispose() } // REVIEW: PENDING API REVIEW TO DETERMINE IMPLEMENTATION +#pragma warning disable 1591 // TODO: Document this API. https://github.com/dotnet/runtime/issues/105981 public override int GetHashCode() { throw new NotImplementedException(); } +#pragma warning restore 1591 /// /// Get a string representation of the tensor. diff --git a/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorExtensions.cs b/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorExtensions.cs index 904bf14c634376..ac925475a27560 100644 --- a/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorExtensions.cs +++ b/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorExtensions.cs @@ -19,7 +19,9 @@ namespace System.Numerics.Tensors { [Experimental(Experimentals.TensorTDiagId, UrlFormat = Experimentals.SharedUrlFormat)] +#pragma warning disable 1591 // TODO: Document this API. https://github.com/dotnet/runtime/issues/105981 public static partial class Tensor +#pragma warning restore 1591 { #region AsReadOnlySpan /// @@ -6587,6 +6589,7 @@ public static ref readonly TensorSpan Xor(scoped in ReadOnlyTensorSpan } #endregion +#pragma warning disable 1591 // TODO: Document this API. https://github.com/dotnet/runtime/issues/105981 public static nint[] GetSmallestBroadcastableLengths(ReadOnlySpan shape1, ReadOnlySpan shape2) { if (!TensorHelpers.IsBroadcastableTo(shape1, shape2)) @@ -6604,6 +6607,7 @@ public static nint[] GetSmallestBroadcastableLengths(ReadOnlySpan shape1, return intermediateShape; } +#pragma warning restore 1591 #region TensorPrimitivesHelpers private delegate void PerformCalculationSpanInSpanOut(ReadOnlySpan input, Span output); diff --git a/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorSpan.cs b/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorSpan.cs index c2d12bd7e814c1..5c52cc68dc208e 100644 --- a/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorSpan.cs +++ b/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorSpan.cs @@ -629,7 +629,9 @@ public bool TryCopyTo(scoped TensorSpan destination) } //public static explicit operator TensorSpan(Array? array); +#pragma warning disable 1591 // TODO: Document this API. https://github.com/dotnet/runtime/issues/105981 public static implicit operator TensorSpan(T[]? array) => new TensorSpan(array); +#pragma warning restore 1591 /// /// Defines an implicit conversion of a to a diff --git a/src/libraries/System.Private.CoreLib/src/System/Buffers/Text/Base64Url/Base64UrlDecoder.cs b/src/libraries/System.Private.CoreLib/src/System/Buffers/Text/Base64Url/Base64UrlDecoder.cs index 7f11078b830537..6e7f07d1c76e47 100644 --- a/src/libraries/System.Private.CoreLib/src/System/Buffers/Text/Base64Url/Base64UrlDecoder.cs +++ b/src/libraries/System.Private.CoreLib/src/System/Buffers/Text/Base64Url/Base64UrlDecoder.cs @@ -15,8 +15,9 @@ namespace System.Buffers.Text { // AVX2 and Vector128 version based on https://github.com/gfoidl/Base64/blob/5383320e28cac6c7ac6f86502fb05d23a048a21d/source/gfoidl.Base64/Internal/Encodings/Base64UrlEncoding.cs - +#pragma warning disable 1591 // TODO: Document this API. https://github.com/dotnet/runtime/issues/105974 public static partial class Base64Url +#pragma warning restore 1591 { private const int MaxStackallocThreshold = 256; diff --git a/src/libraries/System.Private.DataContractSerialization/src/System.Private.DataContractSerialization.csproj b/src/libraries/System.Private.DataContractSerialization/src/System.Private.DataContractSerialization.csproj index c18edfd04579d7..a828163c5921a5 100644 --- a/src/libraries/System.Private.DataContractSerialization/src/System.Private.DataContractSerialization.csproj +++ b/src/libraries/System.Private.DataContractSerialization/src/System.Private.DataContractSerialization.csproj @@ -6,7 +6,6 @@ true false - false diff --git a/src/libraries/System.Private.Uri/src/System.Private.Uri.csproj b/src/libraries/System.Private.Uri/src/System.Private.Uri.csproj index d99efac28d8f62..7ed53d0bfc45f2 100644 --- a/src/libraries/System.Private.Uri/src/System.Private.Uri.csproj +++ b/src/libraries/System.Private.Uri/src/System.Private.Uri.csproj @@ -3,7 +3,6 @@ $(NetCoreAppCurrent) true - false diff --git a/src/libraries/System.Private.Xml.Linq/src/System.Private.Xml.Linq.csproj b/src/libraries/System.Private.Xml.Linq/src/System.Private.Xml.Linq.csproj index b3dd2e5111a514..604a04488e3cd7 100644 --- a/src/libraries/System.Private.Xml.Linq/src/System.Private.Xml.Linq.csproj +++ b/src/libraries/System.Private.Xml.Linq/src/System.Private.Xml.Linq.csproj @@ -3,7 +3,6 @@ $(NetCoreAppCurrent) System.Xml - false diff --git a/src/libraries/System.Private.Xml/src/System.Private.Xml.csproj b/src/libraries/System.Private.Xml/src/System.Private.Xml.csproj index b51641b62abb8b..a78f7c666e030b 100644 --- a/src/libraries/System.Private.Xml/src/System.Private.Xml.csproj +++ b/src/libraries/System.Private.Xml/src/System.Private.Xml.csproj @@ -5,7 +5,6 @@ System.Xml true false - false diff --git a/src/libraries/System.Speech/src/System.Speech.csproj b/src/libraries/System.Speech/src/System.Speech.csproj index 7daa3525b73da6..a33222426885a2 100644 --- a/src/libraries/System.Speech/src/System.Speech.csproj +++ b/src/libraries/System.Speech/src/System.Speech.csproj @@ -7,8 +7,14 @@ $(NoWarn);CS0649;SA1129;IDE0059;IDE0060;CA1822;CA1852 + + + $(NoWarn);CS1591 + true + false - false true true true