From 6f53bc742cf99f0a7746e36869584c16d0011127 Mon Sep 17 00:00:00 2001 From: Adam Sitnik Date: Wed, 8 Jan 2025 19:12:23 +0100 Subject: [PATCH 1/2] don't run Drawing-related tests that do things like creating Bitmaps on Mono, as it's not supported --- .../Common/tests/TestUtilities/System/PlatformDetection.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs b/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs index 7d9711aa78adb7..68d878fa1bacfd 100644 --- a/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs +++ b/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs @@ -169,8 +169,8 @@ private static bool GetLinqExpressionsBuiltWithIsInterpretingOnly() return !(bool)typeof(LambdaExpression).GetMethod("get_CanCompileToIL").Invoke(null, Array.Empty()); } - // Drawing is not supported on non windows platforms in .NET 7.0+. - public static bool IsDrawingSupported => IsWindows && IsNotWindowsNanoServer && IsNotWindowsServerCore; + // Drawing is not supported on non windows platforms in .NET 7.0+ and on Mono. + public static bool IsDrawingSupported => IsWindows && IsNotWindowsNanoServer && IsNotWindowsServerCore && IsNotMonoRuntime; public static bool IsAsyncFileIOSupported => !IsBrowser && !IsWasi; From faa2795af77f763103cbc0bf99e6bea748bf438a Mon Sep 17 00:00:00 2001 From: Adam Sitnik Date: Wed, 8 Jan 2025 19:12:36 +0100 Subject: [PATCH 2/2] re-enable the tests --- .../tests/BinaryFormatterTests.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs b/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs index 4e7e764d26f7e9..6dfeaf8fa4e22e 100644 --- a/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs +++ b/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs @@ -67,7 +67,6 @@ public void ValidateBasicObjectsRoundtrip(object obj, FormatterAssemblyStyle ass [Theory] [SkipOnCoreClr("Takes too long on Checked", ~RuntimeConfiguration.Release)] - [ActiveIssue("https://github.com/dotnet/runtime/issues/107553", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)] [MemberData(nameof(SerializableObjects_MemberData))] public void ValidateAgainstBlobs(object obj, TypeSerializableValue[] blobs) => ValidateAndRoundtrip(obj, blobs, false);