From eeb540ee305d352c0d0fdaa7d4f1fd93437b10ae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20K=C3=B6plinger?= Date: Wed, 19 Jul 2023 11:13:54 +0200 Subject: [PATCH] Fix outerloop tests in System.Formats.Tar The change from https://github.com/dotnet/runtime/pull/88280 caused an issue when discovering the test: ``` System.InvalidOperationException : An appropriate member 'ManualTestsEnabled' could not be found. The conditional method needs to be a static method, property, or field on the type System.Formats.Tar.Tests.ManualTestsAsync or any ancestor, of any visibility, accepting zero arguments, and having a return type of Boolean. ``` --- .../System.Formats.Tar/tests/Manual/ManualTestsAsync.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Formats.Tar/tests/Manual/ManualTestsAsync.cs b/src/libraries/System.Formats.Tar/tests/Manual/ManualTestsAsync.cs index 5262c715256179..445502dc135af6 100644 --- a/src/libraries/System.Formats.Tar/tests/Manual/ManualTestsAsync.cs +++ b/src/libraries/System.Formats.Tar/tests/Manual/ManualTestsAsync.cs @@ -16,7 +16,7 @@ public static IEnumerable WriteEntry_LongFileSize_TheoryDataAsync() // Fixes error xUnit1015: MemberData needs to be in the same class => ManualTests.WriteEntry_LongFileSize_TheoryData(); - [ConditionalTheory(nameof(ManualTests.ManualTestsEnabled))] + [ConditionalTheory(typeof(ManualTests), nameof(ManualTests.ManualTestsEnabled))] [MemberData(nameof(WriteEntry_LongFileSize_TheoryDataAsync))] [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.Android | TestPlatforms.Browser, "Needs too much disk space.")] public async Task WriteEntry_LongFileSizeAsync(TarEntryFormat entryFormat, long size, bool unseekableStream)